* [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
@ 2025-02-21 4:14 gareth.yu
2025-02-21 4:43 ` Kandpal, Suraj
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: gareth.yu @ 2025-02-21 4:14 UTC (permalink / raw)
To: intel-gfx
Cc: intel-xe, shawn.c.lee.intel.om, william.tseng, ankit.k.nautiyal,
Gareth Yu, Suraj Kandpal, Juha-Pekka Heikkil
From: Gareth Yu <gareth.yu@intel.com>
The condition change is because Gen 14 begins to support DSC 1.2
and need to check if the sink supports DSC1.2
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
Cc: Suraj Kandpal <suraj.kandpal@intel.com>
Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
Signed-off-by: Gareth Yu <gareth.yu@intel.com>
---
drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index b355c479eda3..555180e40b72 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state *pipe_config)
* upto uncompressed bpp-1, hence add calculations for all the rc
* parameters
*/
- if (DISPLAY_VER(dev_priv) >= 13) {
+ if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >= 2)) {
calculate_rc_params(vdsc_cfg);
} else {
if ((compressed_bpp == 8 ||
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 4:14 [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation gareth.yu
@ 2025-02-21 4:43 ` Kandpal, Suraj
2025-02-21 5:05 ` Yu, Gareth
2025-02-21 4:48 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Kandpal, Suraj @ 2025-02-21 4:43 UTC (permalink / raw)
To: Yu, Gareth, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Tseng, William,
Nautiyal, Ankit K, Heikkila, Juha-pekka
> -----Original Message-----
> From: Yu, Gareth <gareth.yu@intel.com>
> Sent: Friday, February 21, 2025 9:44 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; shawn.c.lee.intel.om; Tseng, William
> <william.tseng@intel.com>; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Yu,
> Gareth <gareth.yu@intel.com>; Kandpal, Suraj <suraj.kandpal@intel.com>;
> Heikkila, Juha-pekka <juha-pekka.heikkila@intel.com>
> Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2
> for rc params calculation
>
> From: Gareth Yu <gareth.yu@intel.com>
>
> The condition change is because Gen 14 begins to support DSC 1.2 and need to
> check if the sink supports DSC1.2
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> Signed-off-by: Gareth Yu <gareth.yu@intel.com>
Why has the authorship and Signed-off-by changed for essentially the same patch.
Also the commit message and versioning information has been removed any changes
Needs to go as a new version to the previous patch.
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index b355c479eda3..555180e40b72 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state
> *pipe_config)
> * upto uncompressed bpp-1, hence add calculations for all the rc
> * parameters
> */
> - if (DISPLAY_VER(dev_priv) >= 13) {
> + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >=
> +2)) {
Please add a bspec reference number in the commit message where it says we started support of DSC 1.2 from MTL
Regards,
Suraj Kandpal
> calculate_rc_params(vdsc_cfg);
> } else {
> if ((compressed_bpp == 8 ||
> --
> 2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 4:14 [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation gareth.yu
2025-02-21 4:43 ` Kandpal, Suraj
@ 2025-02-21 4:48 ` Patchwork
2025-02-21 5:06 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-24 9:06 ` [PATCH] " Jani Nikula
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2025-02-21 4:48 UTC (permalink / raw)
To: gareth.yu; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
URL : https://patchwork.freedesktop.org/series/145209/
State : warning
== Summary ==
Error: dim checkpatch failed
1e9add002d68 drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
-:25: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vdsc_cfg->dsc_version_minor >= 2'
#25: FILE: drivers/gpu/drm/i915/display/intel_vdsc.c:323:
+ if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >= 2)) {
total: 0 errors, 0 warnings, 1 checks, 8 lines checked
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 4:43 ` Kandpal, Suraj
@ 2025-02-21 5:05 ` Yu, Gareth
2025-02-21 5:12 ` Kandpal, Suraj
2025-02-21 5:26 ` Kandpal, Suraj
0 siblings, 2 replies; 8+ messages in thread
From: Yu, Gareth @ 2025-02-21 5:05 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Tseng, William,
Nautiyal, Ankit K, Heikkila, Juha-pekka
> -----Original Message-----
> From: Kandpal, Suraj <suraj.kandpal@intel.com>
> Sent: Friday, February 21, 2025 12:44 PM
> To: Yu, Gareth <gareth.yu@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; Tseng, William <william.tseng@intel.com>;
> Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila@intel.com>
> Subject: RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and
> DSC 1.2 for rc params calculation
>
>
>
> > -----Original Message-----
> > From: Yu, Gareth <gareth.yu@intel.com>
> > Sent: Friday, February 21, 2025 9:44 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: intel-xe@lists.freedesktop.org; shawn.c.lee.intel.om; Tseng,
> > William <william.tseng@intel.com>; Nautiyal, Ankit K
> > <ankit.k.nautiyal@intel.com>; Yu, Gareth <gareth.yu@intel.com>;
> > Kandpal, Suraj <suraj.kandpal@intel.com>; Heikkila, Juha-pekka
> > <juha-pekka.heikkila@intel.com>
> > Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and
> > DSC 1.2 for rc params calculation
> >
> > From: Gareth Yu <gareth.yu@intel.com>
> >
> > The condition change is because Gen 14 begins to support DSC 1.2 and
> > need to check if the sink supports DSC1.2
> >
> > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
> >
> > Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> > Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> > Signed-off-by: Gareth Yu <gareth.yu@intel.com>
>
> Why has the authorship and Signed-off-by changed for essentially the same
> patch.
> Also the commit message and versioning information has been removed any
> changes Needs to go as a new version to the previous patch.
This is a new patch to check both source and sink DSC version. The previous one (https://patchwork.freedesktop.org/patch/638403/?series=145136) is only to check sink condition.
>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > index b355c479eda3..555180e40b72 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct
> > intel_crtc_state
> > *pipe_config)
> > * upto uncompressed bpp-1, hence add calculations for all the rc
> > * parameters
> > */
> > - if (DISPLAY_VER(dev_priv) >= 13) {
> > + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor
> >=
> > +2)) {
>
> Please add a bspec reference number in the commit message where it says
> we started support of DSC 1.2 from MTL
BSPEC: 49259. Will add in the next version.
>
> Regards,
> Suraj Kandpal
>
> > calculate_rc_params(vdsc_cfg);
> > } else {
> > if ((compressed_bpp == 8 ||
> > --
> > 2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 4:14 [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation gareth.yu
2025-02-21 4:43 ` Kandpal, Suraj
2025-02-21 4:48 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2025-02-21 5:06 ` Patchwork
2025-02-24 9:06 ` [PATCH] " Jani Nikula
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2025-02-21 5:06 UTC (permalink / raw)
To: gareth.yu; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10957 bytes --]
== Series Details ==
Series: drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
URL : https://patchwork.freedesktop.org/series/145209/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16166 -> Patchwork_145209v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_145209v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_145209v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/index.html
Participating hosts (41 -> 42)
------------------------------
Additional (2): bat-arlh-2 fi-pnv-d510
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_145209v1:
### IGT changes ###
#### Possible regressions ####
* igt@kms_dsc@dsc-basic@pipe-a-dp-1:
- bat-dg2-9: [PASS][1] -> [FAIL][2] +1 other test fail
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-dg2-9/igt@kms_dsc@dsc-basic@pipe-a-dp-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-dg2-9/igt@kms_dsc@dsc-basic@pipe-a-dp-1.html
- bat-dg2-8: [PASS][3] -> [FAIL][4] +1 other test fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-dg2-8/igt@kms_dsc@dsc-basic@pipe-a-dp-1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-dg2-8/igt@kms_dsc@dsc-basic@pipe-a-dp-1.html
Known issues
------------
Here are the changes found in Patchwork_145209v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-arlh-2: NOTRUN -> [SKIP][5] ([i915#11346] / [i915#9318])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@eof:
- bat-arlh-2: NOTRUN -> [SKIP][6] ([i915#11345] / [i915#11346]) +3 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@fbdev@eof.html
* igt@fbdev@info:
- bat-arlh-2: NOTRUN -> [SKIP][7] ([i915#11346] / [i915#1849])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@fbdev@info.html
* igt@gem_lmem_swapping@basic:
- bat-arlh-2: NOTRUN -> [SKIP][8] ([i915#10213] / [i915#11346] / [i915#11671]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@gem_lmem_swapping@basic.html
* igt@gem_mmap@basic:
- bat-arlh-2: NOTRUN -> [SKIP][9] ([i915#11343] / [i915#11346])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][10] ([i915#10197] / [i915#10211] / [i915#11346] / [i915#11725])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_blits@basic:
- bat-arlh-2: NOTRUN -> [SKIP][11] ([i915#11346] / [i915#12637]) +4 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-arlh-2: NOTRUN -> [SKIP][12] ([i915#10206] / [i915#11346] / [i915#11724])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-arlh-2: NOTRUN -> [SKIP][13] ([i915#10209] / [i915#11346] / [i915#11681])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live:
- bat-twl-1: [PASS][14] -> [ABORT][15] ([i915#12919] / [i915#13503])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-twl-1/igt@i915_selftest@live.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-twl-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@gt_lrc:
- bat-twl-1: [PASS][16] -> [ABORT][17] ([i915#12919])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-twl-1/igt@i915_selftest@live@gt_lrc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-twl-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@workarounds:
- bat-mtlp-9: [PASS][18] -> [DMESG-FAIL][19] ([i915#12061])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-arlh-2: NOTRUN -> [SKIP][20] ([i915#10200] / [i915#11346] / [i915#11666] / [i915#12203])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-arlh-2: NOTRUN -> [SKIP][21] ([i915#10200] / [i915#11346] / [i915#11666]) +8 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@kms_addfb_basic@basic-x-tiled-legacy.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: [PASS][22] -> [SKIP][23] ([i915#9197]) +3 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_psr@psr-primary-mmap-gtt:
- fi-pnv-d510: NOTRUN -> [SKIP][24] +33 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/fi-pnv-d510/igt@kms_psr@psr-primary-mmap-gtt.html
* igt@kms_psr@psr-primary-page-flip:
- bat-arlh-2: NOTRUN -> [SKIP][25] ([i915#11346]) +32 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@kms_psr@psr-primary-page-flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-arlh-2: NOTRUN -> [SKIP][26] ([i915#10208] / [i915#11346] / [i915#8809])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-arlh-2: NOTRUN -> [SKIP][27] ([i915#10212] / [i915#11346] / [i915#11726])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-read:
- bat-arlh-2: NOTRUN -> [SKIP][28] ([i915#10214] / [i915#11346] / [i915#11726])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-arlh-2: NOTRUN -> [SKIP][29] ([i915#10216] / [i915#11346] / [i915#11723])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arlh-2/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@workarounds:
- bat-arls-6: [DMESG-FAIL][30] ([i915#12061]) -> [PASS][31] +1 other test pass
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/bat-arls-6/igt@i915_selftest@live@workarounds.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/bat-arls-6/igt@i915_selftest@live@workarounds.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-bsw-n3050: [DMESG-WARN][32] -> [PASS][33] +1 other test pass
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_16166/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
[i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
[i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
[i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
[i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
[i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
[i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
[i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
[i915#12637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12637
[i915#12919]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919
[i915#13503]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13503
[i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
[i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
Build changes
-------------
* Linux: CI_DRM_16166 -> Patchwork_145209v1
CI-20190529: 20190529
CI_DRM_16166: 773b5639a9ff0a33feccb29de7f2d852c6d7f221 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8245: 822e95b2560133bc21aa3065f70d7148f23f87cf @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_145209v1: 773b5639a9ff0a33feccb29de7f2d852c6d7f221 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_145209v1/index.html
[-- Attachment #2: Type: text/html, Size: 13623 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 5:05 ` Yu, Gareth
@ 2025-02-21 5:12 ` Kandpal, Suraj
2025-02-21 5:26 ` Kandpal, Suraj
1 sibling, 0 replies; 8+ messages in thread
From: Kandpal, Suraj @ 2025-02-21 5:12 UTC (permalink / raw)
To: Yu, Gareth, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Tseng, William,
Nautiyal, Ankit K, Heikkila, Juha-pekka
> -----Original Message-----
> From: Yu, Gareth <gareth.yu@intel.com>
> Sent: Friday, February 21, 2025 10:35 AM
> To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; Tseng, William <william.tseng@intel.com>;
> Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila@intel.com>
> Subject: RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC
> 1.2 for rc params calculation
>
>
>
> > -----Original Message-----
> > From: Kandpal, Suraj <suraj.kandpal@intel.com>
> > Sent: Friday, February 21, 2025 12:44 PM
> > To: Yu, Gareth <gareth.yu@intel.com>; intel-gfx@lists.freedesktop.org
> > Cc: intel-xe@lists.freedesktop.org; Tseng, William
> > <william.tseng@intel.com>; Nautiyal, Ankit K
> > <ankit.k.nautiyal@intel.com>; Heikkila, Juha-pekka <juha-
> > pekka.heikkila@intel.com>
> > Subject: RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1
> > and DSC 1.2 for rc params calculation
> >
> >
> >
> > > -----Original Message-----
> > > From: Yu, Gareth <gareth.yu@intel.com>
> > > Sent: Friday, February 21, 2025 9:44 AM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: intel-xe@lists.freedesktop.org; shawn.c.lee.intel.om; Tseng,
> > > William <william.tseng@intel.com>; Nautiyal, Ankit K
> > > <ankit.k.nautiyal@intel.com>; Yu, Gareth <gareth.yu@intel.com>;
> > > Kandpal, Suraj <suraj.kandpal@intel.com>; Heikkila, Juha-pekka
> > > <juha-pekka.heikkila@intel.com>
> > > Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and
> > > DSC 1.2 for rc params calculation
> > >
> > > From: Gareth Yu <gareth.yu@intel.com>
> > >
> > > The condition change is because Gen 14 begins to support DSC 1.2 and
> > > need to check if the sink supports DSC1.2
> > >
> > > Closes:
> > > https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
> > >
> > > Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> > > Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> > > Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> >
> > Why has the authorship and Signed-off-by changed for essentially the
> > same patch.
> > Also the commit message and versioning information has been removed
> > any changes Needs to go as a new version to the previous patch.
> This is a new patch to check both source and sink DSC version. The previous one
> (https://patchwork.freedesktop.org/patch/638403/?series=145136) is only to
> check sink condition.
That does not require a new patch series altogether a simple comment asking the previous
Author to add the DISPLAY_VER change should be the way to go. Add the DISPLAY_VERSION check
as a part of the older series.
Regards,
Suraj Kandpal
> >
> >
> > > ---
> > > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > index b355c479eda3..555180e40b72 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct
> > > intel_crtc_state
> > > *pipe_config)
> > > * upto uncompressed bpp-1, hence add calculations for all the rc
> > > * parameters
> > > */
> > > - if (DISPLAY_VER(dev_priv) >= 13) {
> > > + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor
> > >=
> > > +2)) {
> >
> > Please add a bspec reference number in the commit message where it
> > says we started support of DSC 1.2 from MTL
> BSPEC: 49259. Will add in the next version.
> >
> > Regards,
> > Suraj Kandpal
> >
> > > calculate_rc_params(vdsc_cfg);
> > > } else {
> > > if ((compressed_bpp == 8 ||
> > > --
> > > 2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 5:05 ` Yu, Gareth
2025-02-21 5:12 ` Kandpal, Suraj
@ 2025-02-21 5:26 ` Kandpal, Suraj
1 sibling, 0 replies; 8+ messages in thread
From: Kandpal, Suraj @ 2025-02-21 5:26 UTC (permalink / raw)
To: Yu, Gareth, intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Tseng, William,
Nautiyal, Ankit K, Heikkila, Juha-pekka
> -----Original Message-----
> From: Yu, Gareth <gareth.yu@intel.com>
> Sent: Friday, February 21, 2025 10:35 AM
> To: Kandpal, Suraj <suraj.kandpal@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org; Tseng, William <william.tseng@intel.com>;
> Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila@intel.com>
> Subject: RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC
> 1.2 for rc params calculation
>
>
>
> > -----Original Message-----
> > From: Kandpal, Suraj <suraj.kandpal@intel.com>
> > Sent: Friday, February 21, 2025 12:44 PM
> > To: Yu, Gareth <gareth.yu@intel.com>; intel-gfx@lists.freedesktop.org
> > Cc: intel-xe@lists.freedesktop.org; Tseng, William
> > <william.tseng@intel.com>; Nautiyal, Ankit K
> > <ankit.k.nautiyal@intel.com>; Heikkila, Juha-pekka <juha-
> > pekka.heikkila@intel.com>
> > Subject: RE: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1
> > and DSC 1.2 for rc params calculation
> >
> >
> >
> > > -----Original Message-----
> > > From: Yu, Gareth <gareth.yu@intel.com>
> > > Sent: Friday, February 21, 2025 9:44 AM
> > > To: intel-gfx@lists.freedesktop.org
> > > Cc: intel-xe@lists.freedesktop.org; shawn.c.lee.intel.om; Tseng,
> > > William <william.tseng@intel.com>; Nautiyal, Ankit K
> > > <ankit.k.nautiyal@intel.com>; Yu, Gareth <gareth.yu@intel.com>;
> > > Kandpal, Suraj <suraj.kandpal@intel.com>; Heikkila, Juha-pekka
> > > <juha-pekka.heikkila@intel.com>
> > > Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and
> > > DSC 1.2 for rc params calculation
> > >
> > > From: Gareth Yu <gareth.yu@intel.com>
> > >
> > > The condition change is because Gen 14 begins to support DSC 1.2 and
> > > need to check if the sink supports DSC1.2
> > >
> > > Closes:
> > > https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
> > >
> > > Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> > > Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> > > Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> >
> > Why has the authorship and Signed-off-by changed for essentially the
> > same patch.
> > Also the commit message and versioning information has been removed
> > any changes Needs to go as a new version to the previous patch.
> This is a new patch to check both source and sink DSC version. The previous one
> (https://patchwork.freedesktop.org/patch/638403/?series=145136) is only to
> check sink condition.
More things I forgot to mention the calculate RC Params also works for DSC 1.1
Check commit message of db514cac08fd4861a3b221bed5f21b441a1242c3
Also from what I gather we have had DSC1.2 support since ADLP so the whole condition in itself
Is not correct as I mentioned this needs more debug, follow up with logs asked in the issue.
Regards,
Suraj Kandpal
> >
> > > ---
> > > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > index b355c479eda3..555180e40b72 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> > > @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct
> > > intel_crtc_state
> > > *pipe_config)
> > > * upto uncompressed bpp-1, hence add calculations for all the rc
> > > * parameters
> > > */
> > > - if (DISPLAY_VER(dev_priv) >= 13) {
> > > + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor
> > >=
> > > +2)) {
> >
> > Please add a bspec reference number in the commit message where it
> > says we started support of DSC 1.2 from MTL
> BSPEC: 49259. Will add in the next version.
> >
> > Regards,
> > Suraj Kandpal
> >
> > > calculate_rc_params(vdsc_cfg);
> > > } else {
> > > if ((compressed_bpp == 8 ||
> > > --
> > > 2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
2025-02-21 4:14 [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation gareth.yu
` (2 preceding siblings ...)
2025-02-21 5:06 ` ✗ i915.CI.BAT: failure " Patchwork
@ 2025-02-24 9:06 ` Jani Nikula
3 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2025-02-24 9:06 UTC (permalink / raw)
To: gareth.yu, intel-gfx
Cc: intel-xe, shawn.c.lee.intel.om, william.tseng, ankit.k.nautiyal,
Gareth Yu, Suraj Kandpal, Juha-Pekka Heikkil
On Fri, 21 Feb 2025, gareth.yu@intel.com wrote:
> From: Gareth Yu <gareth.yu@intel.com>
>
> The condition change is because Gen 14 begins to support DSC 1.2
> and need to check if the sink supports DSC1.2
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index b355c479eda3..555180e40b72 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state *pipe_config)
> * upto uncompressed bpp-1, hence add calculations for all the rc
> * parameters
> */
> - if (DISPLAY_VER(dev_priv) >= 13) {
> + if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >= 2)) {
Please do not add unnecessary parenthesis. They're a distraction.
BR,
Jani.
> calculate_rc_params(vdsc_cfg);
> } else {
> if ((compressed_bpp == 8 ||
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-02-24 13:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-21 4:14 [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation gareth.yu
2025-02-21 4:43 ` Kandpal, Suraj
2025-02-21 5:05 ` Yu, Gareth
2025-02-21 5:12 ` Kandpal, Suraj
2025-02-21 5:26 ` Kandpal, Suraj
2025-02-21 4:48 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2025-02-21 5:06 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-24 9:06 ` [PATCH] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox