From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/4] drm/i915: Apply the combo PLL frac w/a on DG1
Date: Tue, 1 Apr 2025 19:37:49 +0300 [thread overview]
Message-ID: <20250401163752.6412-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250401163752.6412-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
DG1 apparently needs the combo PLL fractional divider w/a
with 38.4 MHz refclk as well. This isn't listed in bspec, but
looking at the hsd it looks like it was possibly just missed
due to no one having a DG1 around at the time.
This gives us slightly more accurate clocks on DG1.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index ec7feef1ef59..76ab55ee4b80 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -2604,6 +2604,7 @@ ehl_combo_pll_div_frac_wa_needed(struct intel_display *display)
{
return ((display->platform.elkhartlake &&
IS_DISPLAY_STEP(display, STEP_B0, STEP_FOREVER)) ||
+ display->platform.dg1 ||
display->platform.tigerlake ||
display->platform.alderlake_s ||
display->platform.alderlake_p) &&
--
2.45.3
next prev parent reply other threads:[~2025-04-01 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 16:37 [PATCH 0/4] drm/i915: DG1 fixes Ville Syrjala
2025-04-01 16:37 ` Ville Syrjala [this message]
2025-04-02 16:34 ` [PATCH 1/4] drm/i915: Apply the combo PLL frac w/a on DG1 Imre Deak
2025-04-01 16:37 ` [PATCH 2/4] drm/i915: Simplify combo PLL frac w/a Ville Syrjala
2025-04-02 17:17 ` [PATCH v2 " Ville Syrjala
2025-04-03 13:50 ` Imre Deak
2025-04-01 16:37 ` [PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1 Ville Syrjala
2025-04-01 17:34 ` Andi Shyti
2025-04-01 17:50 ` Ville Syrjälä
2025-04-01 23:13 ` Andi Shyti
2025-04-01 16:37 ` [PATCH 4/4] drm/i915/pci: Remove force_probe requirement for DG1 Ville Syrjala
2025-04-01 17:34 ` Andi Shyti
2025-04-01 18:13 ` ✗ Fi.CI.SPARSE: warning for drm/i915: DG1 fixes Patchwork
2025-04-01 18:31 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-01 21:50 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-02 17:54 ` ✗ Fi.CI.SPARSE: warning for drm/i915: DG1 fixes (rev2) Patchwork
2025-04-02 18:38 ` ✓ i915.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401163752.6412-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox