Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 2/4] drm/i915: Simplify combo PLL frac w/a
Date: Wed,  2 Apr 2025 20:17:20 +0300	[thread overview]
Message-ID: <20250402171720.9350-1-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250401163752.6412-3-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We are applying the combo PLL frac w/a to all TGL+ platforms, except
RKL. I *think* all RKL machines use a 24 MHz refclk (certainly all
machines in our CI do) and so technically never need the adjustment.
But let's assume the hardware is exactly the same anyway and simplify
the code by applying the w/a to all TGL+ platforms.

v2: Keep the 38.4 MHz check

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index 76ab55ee4b80..84df41086a89 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -2604,11 +2604,8 @@ ehl_combo_pll_div_frac_wa_needed(struct intel_display *display)
 {
 	return ((display->platform.elkhartlake &&
 		 IS_DISPLAY_STEP(display, STEP_B0, STEP_FOREVER)) ||
-		 display->platform.dg1 ||
-		 display->platform.tigerlake ||
-		 display->platform.alderlake_s ||
-		 display->platform.alderlake_p) &&
-		 display->dpll.ref_clks.nssc == 38400;
+		DISPLAY_VER(display) >= 12) &&
+		display->dpll.ref_clks.nssc == 38400;
 }
 
 struct icl_combo_pll_params {
-- 
2.45.3


  reply	other threads:[~2025-04-02 17:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 16:37 [PATCH 0/4] drm/i915: DG1 fixes Ville Syrjala
2025-04-01 16:37 ` [PATCH 1/4] drm/i915: Apply the combo PLL frac w/a on DG1 Ville Syrjala
2025-04-02 16:34   ` Imre Deak
2025-04-01 16:37 ` [PATCH 2/4] drm/i915: Simplify combo PLL frac w/a Ville Syrjala
2025-04-02 17:17   ` Ville Syrjala [this message]
2025-04-03 13:50     ` [PATCH v2 " Imre Deak
2025-04-01 16:37 ` [PATCH 3/4] drm/i915/gem: Allow EXEC_CAPTURE on recoverable contexts on DG1 Ville Syrjala
2025-04-01 17:34   ` Andi Shyti
2025-04-01 17:50     ` Ville Syrjälä
2025-04-01 23:13     ` Andi Shyti
2025-04-01 16:37 ` [PATCH 4/4] drm/i915/pci: Remove force_probe requirement for DG1 Ville Syrjala
2025-04-01 17:34   ` Andi Shyti
2025-04-01 18:13 ` ✗ Fi.CI.SPARSE: warning for drm/i915: DG1 fixes Patchwork
2025-04-01 18:31 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-01 21:50 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-02 17:54 ` ✗ Fi.CI.SPARSE: warning for drm/i915: DG1 fixes (rev2) Patchwork
2025-04-02 18:38 ` ✓ i915.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402171720.9350-1-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox