From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v8 1/9] drm/i915/alpm: use variable from intel_crtc_state instead of intel_psr
Date: Wed, 9 Apr 2025 19:32:50 +0530 [thread overview]
Message-ID: <20250409140258.785834-2-animesh.manna@intel.com> (raw)
In-Reply-To: <20250409140258.785834-1-animesh.manna@intel.com>
From: Jouni Högander <jouni.hogander@intel.com>
Currently code is making assumption that PSR is enabled when
intel_alpm_configure is called. This doesn't work if alpm is configured
before PSR is enabled.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 55f3ae1e68c9..1dbaa8f250aa 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -317,14 +317,14 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
u32 alpm_ctl;
if (DISPLAY_VER(display) < 20 ||
- (!intel_dp->psr.sel_update_enabled && !intel_dp_is_edp(intel_dp)))
+ (!crtc_state->has_sel_update && !intel_dp_is_edp(intel_dp)))
return;
/*
* Panel Replay on eDP is always using ALPM aux less. I.e. no need to
* check panel support at this point.
*/
- if ((intel_dp->psr.panel_replay_enabled && intel_dp_is_edp(intel_dp)) ||
+ if ((crtc_state->has_panel_replay && intel_dp_is_edp(intel_dp)) ||
(crtc_state->has_lobf && intel_alpm_aux_less_wake_supported(intel_dp))) {
alpm_ctl = ALPM_CTL_ALPM_ENABLE |
ALPM_CTL_ALPM_AUX_LESS_ENABLE |
--
2.29.0
next prev parent reply other threads:[~2025-04-09 14:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:02 [PATCH v8 0/9] LOBF enablement fix Animesh Manna
2025-04-09 14:02 ` Animesh Manna [this message]
2025-04-09 14:02 ` [PATCH v8 2/9] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-04-09 14:02 ` [PATCH v8 3/9] drm/i915/lobf: Add debug print for LOBF Animesh Manna
2025-04-09 14:02 ` [PATCH v8 4/9] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-04-09 14:02 ` [PATCH v8 5/9] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-04-09 14:02 ` [PATCH v8 6/9] drm/i915/lobf: Update lobf if any change in dependent parameters Animesh Manna
2025-04-15 5:40 ` Hogander, Jouni
2025-05-08 11:57 ` Jani Nikula
2025-04-09 14:02 ` [PATCH v8 7/9] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-04-15 5:54 ` Hogander, Jouni
2025-04-09 14:02 ` [PATCH v8 8/9] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-04-09 14:02 ` [PATCH v8 9/9] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-04-09 16:46 ` ✗ Fi.CI.CHECKPATCH: warning for LOBF enablement fix (rev8) Patchwork
2025-04-09 17:11 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-10 1:21 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-15 5:24 ` [PATCH v8 0/9] LOBF enablement fix Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409140258.785834-2-animesh.manna@intel.com \
--to=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jeevan.b@intel.com \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox