Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, jani.nikula@intel.com,
	jeevan.b@intel.com, Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v8 3/9] drm/i915/lobf: Add debug print for LOBF
Date: Wed,  9 Apr 2025 19:32:52 +0530	[thread overview]
Message-ID: <20250409140258.785834-4-animesh.manna@intel.com> (raw)
In-Reply-To: <20250409140258.785834-1-animesh.manna@intel.com>

Lobf is enabled part of ALPM configuration and if has_lobf
is set to true respective bit for LOBF will be set. Add debug
print while setting the bitfield of LOBF.

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 41f8b05cc11c..9227bb0b0c55 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -5,6 +5,8 @@
 
 #include <linux/debugfs.h>
 
+#include <drm/drm_print.h>
+
 #include "intel_alpm.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
@@ -353,8 +355,10 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
 			ALPM_CTL_EXTENDED_FAST_WAKE_TIME(intel_dp->alpm_parameters.fast_wake_lines);
 	}
 
-	if (crtc_state->has_lobf)
+	if (crtc_state->has_lobf) {
 		alpm_ctl |= ALPM_CTL_LOBF_ENABLE;
+		drm_dbg_kms(display->drm, "Link off between frames (LOBF) enabled\n");
+	}
 
 	alpm_ctl |= ALPM_CTL_ALPM_ENTRY_CHECK(intel_dp->alpm_parameters.check_entry_lines);
 
-- 
2.29.0


  parent reply	other threads:[~2025-04-09 14:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09 14:02 [PATCH v8 0/9] LOBF enablement fix Animesh Manna
2025-04-09 14:02 ` [PATCH v8 1/9] drm/i915/alpm: use variable from intel_crtc_state instead of intel_psr Animesh Manna
2025-04-09 14:02 ` [PATCH v8 2/9] drm/i915/lobf: Add lobf enablement in post plane update Animesh Manna
2025-04-09 14:02 ` Animesh Manna [this message]
2025-04-09 14:02 ` [PATCH v8 4/9] drm/i915/lobf: Disintegrate alpm_disable from psr_disable Animesh Manna
2025-04-09 14:02 ` [PATCH v8 5/9] drm/i915/lobf: Add fixed refresh rate check in compute_config() Animesh Manna
2025-04-09 14:02 ` [PATCH v8 6/9] drm/i915/lobf: Update lobf if any change in dependent parameters Animesh Manna
2025-04-15  5:40   ` Hogander, Jouni
2025-05-08 11:57   ` Jani Nikula
2025-04-09 14:02 ` [PATCH v8 7/9] drm/i915/lobf: Add debug interface for lobf Animesh Manna
2025-04-15  5:54   ` Hogander, Jouni
2025-04-09 14:02 ` [PATCH v8 8/9] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-04-09 14:02 ` [PATCH v8 9/9] drm/i915/lobf: Check for sink error and disable LOBF Animesh Manna
2025-04-09 16:46 ` ✗ Fi.CI.CHECKPATCH: warning for LOBF enablement fix (rev8) Patchwork
2025-04-09 17:11 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-10  1:21 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-15  5:24 ` [PATCH v8 0/9] LOBF enablement fix Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250409140258.785834-4-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jeevan.b@intel.com \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox