From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com,
animesh.manna@intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG
Date: Wed, 19 Nov 2025 19:21:50 +0530 [thread overview]
Message-ID: <20251119135152.673276-4-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20251119135152.673276-1-ankit.k.nautiyal@intel.com>
As per bspec the LOBF is allowed when running in fixed refresh rate mode
i.e. when flipline = vmin = vmax and when window1 is non zero. This
implies that we can allow LOBF only when VRR timing generator is running
in the fixed refresh rate mode.
Use the check intel_vrr_always_use_vrr_tg() to avoid LOBF with legacy
timing generator. Also use intel_vrr_is_fixed_rr() to check for fixed
refresh rate mode.
v2: Modify commit message to clarify window1 requirement for LOBF.
(Ville)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 686e4d13f864..5cfb9345776a 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -344,8 +344,8 @@ void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
if (crtc_state->has_psr)
return;
- if (crtc_state->vrr.vmin != crtc_state->vrr.vmax ||
- crtc_state->vrr.vmin != crtc_state->vrr.flipline)
+ if (!intel_vrr_always_use_vrr_tg(display) ||
+ !intel_vrr_is_fixed_rr(crtc_state))
return;
if (!(intel_alpm_aux_wake_supported(intel_dp) ||
--
2.45.2
next prev parent reply other threads:[~2025-11-19 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:51 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-19 13:51 ` [PATCH 1/5] drm/i915/alpm: Compute LOBF late after guardband is already determined Ankit Nautiyal
2025-11-20 8:51 ` Michał Grzelak
2025-11-20 12:21 ` Nautiyal, Ankit K
2025-11-24 3:49 ` Ankit Nautiyal
2025-12-17 13:11 ` Hogander, Jouni
2025-12-24 8:46 ` Nautiyal, Ankit K
2026-02-04 6:23 ` Hogander, Jouni
2025-11-19 13:51 ` [PATCH 2/5] drm/i915/alpm: Allow LOBF only if window1 > alpm check_entry lines Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-11-19 13:51 ` Ankit Nautiyal [this message]
2025-11-20 8:52 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Michał Grzelak
2025-11-19 13:51 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-12-17 13:49 ` Hogander, Jouni
2025-12-18 9:37 ` Nautiyal, Ankit K
2025-11-19 13:51 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal
2025-11-20 8:53 ` Michał Grzelak
2025-11-19 14:54 ` ✓ i915.CI.BAT: success for LOBF fixes (rev2) Patchwork
2025-11-19 17:53 ` ✗ i915.CI.Full: failure " Patchwork
2025-11-24 23:30 ` ✓ i915.CI.BAT: success for LOBF fixes (rev3) Patchwork
2025-11-25 4:22 ` ✗ i915.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-12-24 8:48 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-12-24 8:48 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Ankit Nautiyal
2025-11-14 5:27 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-14 5:27 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Ankit Nautiyal
2025-11-14 15:10 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119135152.673276-4-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox