From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com,
animesh.manna@intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN
Date: Wed, 19 Nov 2025 19:21:52 +0530 [thread overview]
Message-ID: <20251119135152.673276-6-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20251119135152.673276-1-ankit.k.nautiyal@intel.com>
When enabling LRR/seamless MN disable LOBF first and re-enable
afterwards.
- pre_plane_update: if LOBF was enabled, disable LOBF before the
update_lrr/update_m_n transition.
- post_plane_update: Re-enable LOBF after the transition.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ecbdc506a1fc..9ffccfdd0f0c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1018,7 +1018,9 @@ static bool intel_crtc_lobf_enabling(const struct intel_crtc_state *old_crtc_sta
if (!new_crtc_state->has_psr)
return false;
- return is_enabling(has_lobf, old_crtc_state, new_crtc_state);
+ return is_enabling(has_lobf, old_crtc_state, new_crtc_state) ||
+ (new_crtc_state->has_lobf &&
+ (new_crtc_state->update_lrr || new_crtc_state->update_m_n));
}
static bool intel_crtc_lobf_disabling(const struct intel_crtc_state *old_crtc_state,
@@ -1027,7 +1029,9 @@ static bool intel_crtc_lobf_disabling(const struct intel_crtc_state *old_crtc_st
if (!new_crtc_state->hw.active)
return false;
- return is_disabling(has_lobf, old_crtc_state, new_crtc_state);
+ return is_disabling(has_lobf, old_crtc_state, new_crtc_state) ||
+ (old_crtc_state->has_lobf &&
+ (new_crtc_state->update_lrr || new_crtc_state->update_m_n));
}
#undef is_disabling
--
2.45.2
next prev parent reply other threads:[~2025-11-19 14:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:51 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-19 13:51 ` [PATCH 1/5] drm/i915/alpm: Compute LOBF late after guardband is already determined Ankit Nautiyal
2025-11-20 8:51 ` Michał Grzelak
2025-11-20 12:21 ` Nautiyal, Ankit K
2025-11-24 3:49 ` Ankit Nautiyal
2025-12-17 13:11 ` Hogander, Jouni
2025-12-24 8:46 ` Nautiyal, Ankit K
2026-02-04 6:23 ` Hogander, Jouni
2025-11-19 13:51 ` [PATCH 2/5] drm/i915/alpm: Allow LOBF only if window1 > alpm check_entry lines Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-11-19 13:51 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-11-19 13:51 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-12-17 13:49 ` Hogander, Jouni
2025-12-18 9:37 ` Nautiyal, Ankit K
2025-11-19 13:51 ` Ankit Nautiyal [this message]
2025-11-20 8:53 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Michał Grzelak
2025-11-19 14:54 ` ✓ i915.CI.BAT: success for LOBF fixes (rev2) Patchwork
2025-11-19 17:53 ` ✗ i915.CI.Full: failure " Patchwork
2025-11-24 23:30 ` ✓ i915.CI.BAT: success for LOBF fixes (rev3) Patchwork
2025-11-25 4:22 ` ✗ i915.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-12-24 8:48 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-12-24 8:48 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal
2025-11-14 5:27 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-14 5:27 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119135152.673276-6-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox