Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com,
	animesh.manna@intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN
Date: Fri, 14 Nov 2025 10:57:46 +0530	[thread overview]
Message-ID: <20251114052746.158751-6-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20251114052746.158751-1-ankit.k.nautiyal@intel.com>

When enabling LRR/seamless MN disable LOBF first and re-enable
afterwards.
- pre_plane_update: if LOBF was enabled, run pre even when new==old
  whenever update_lrr || update_m_n is set (to disable LOBF before the
  transition).
- post_plane_update: run post to re-enable LOBF after the transition.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_alpm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index db2b9608f7f8..e3079cf7af9d 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -462,7 +462,9 @@ void intel_alpm_pre_plane_update(struct intel_atomic_state *state,
 		return;
 
 	if (!old_crtc_state->has_lobf ||
-	    crtc_state->has_lobf == old_crtc_state->has_lobf)
+	    (crtc_state->has_lobf == old_crtc_state->has_lobf &&
+	     !crtc_state->update_lrr &&
+	     !crtc_state->update_m_n))
 		return;
 
 	for_each_intel_encoder_mask(display->drm, encoder,
@@ -517,7 +519,9 @@ void intel_alpm_post_plane_update(struct intel_atomic_state *state,
 		return;
 
 	if (!crtc_state->has_lobf ||
-	    crtc_state->has_lobf == old_crtc_state->has_lobf)
+	    (crtc_state->has_lobf == old_crtc_state->has_lobf &&
+	     !crtc_state->update_lrr &&
+	     !crtc_state->update_m_n))
 		return;
 
 	for_each_intel_encoder_mask(display->drm, encoder,
-- 
2.45.2


  parent reply	other threads:[~2025-11-14  5:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  5:27 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-14  5:27 ` [PATCH 1/5] drm/i915/alpm: Compute LOBF late after guardband is already determined Ankit Nautiyal
2025-11-14  5:27 ` [PATCH 2/5] drm/i915/alpm: Allow LOBF only if window1 > alpm check_entry lines Ankit Nautiyal
2025-11-14 15:09   ` Ville Syrjälä
2025-11-17  7:34     ` Nautiyal, Ankit K
2025-11-14  5:27 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Ankit Nautiyal
2025-11-14 15:10   ` Ville Syrjälä
2025-11-14  5:27 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ankit Nautiyal
2025-11-14 15:15   ` Ville Syrjälä
2025-11-17  7:36     ` Nautiyal, Ankit K
2025-11-14  5:27 ` Ankit Nautiyal [this message]
2025-11-14  7:40 ` ✓ i915.CI.BAT: success for LOBF fixes Patchwork
2025-11-14 23:08 ` ✓ i915.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-11-19 13:51 [PATCH 0/5] " Ankit Nautiyal
2025-11-19 13:51 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal
2025-11-20  8:53   ` Michał Grzelak
2025-12-24  8:48 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-12-24  8:48 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251114052746.158751-6-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox