From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jouni.hogander@intel.com, ville.syrjala@linux.intel.com,
animesh.manna@intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update
Date: Fri, 14 Nov 2025 10:57:45 +0530 [thread overview]
Message-ID: <20251114052746.158751-5-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20251114052746.158751-1-ankit.k.nautiyal@intel.com>
The pre_plane_update and post_plane_update hooks used slightly different
conditions for LOBF state changes. Rewrite them to be minimal and
complementary:
- pre runs only when LOBF is being disabled (old=1 -> new=0)
- post runs only when LOBF is being enabled (old=0 -> new=1),
with an early return if PSR is active.
This will help for subsequent changes to handle LOBF during LRR and
seamless MN transitions.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_alpm.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
index 5cfb9345776a..db2b9608f7f8 100644
--- a/drivers/gpu/drm/i915/display/intel_alpm.c
+++ b/drivers/gpu/drm/i915/display/intel_alpm.c
@@ -461,7 +461,8 @@ void intel_alpm_pre_plane_update(struct intel_atomic_state *state,
if (DISPLAY_VER(display) < 20)
return;
- if (crtc_state->has_lobf || crtc_state->has_lobf == old_crtc_state->has_lobf)
+ if (!old_crtc_state->has_lobf ||
+ crtc_state->has_lobf == old_crtc_state->has_lobf)
return;
for_each_intel_encoder_mask(display->drm, encoder,
@@ -512,7 +513,10 @@ void intel_alpm_post_plane_update(struct intel_atomic_state *state,
intel_atomic_get_old_crtc_state(state, crtc);
struct intel_encoder *encoder;
- if (crtc_state->has_psr || !crtc_state->has_lobf ||
+ if (crtc_state->has_psr)
+ return;
+
+ if (!crtc_state->has_lobf ||
crtc_state->has_lobf == old_crtc_state->has_lobf)
return;
--
2.45.2
next prev parent reply other threads:[~2025-11-14 5:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 5:27 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-11-14 5:27 ` [PATCH 1/5] drm/i915/alpm: Compute LOBF late after guardband is already determined Ankit Nautiyal
2025-11-14 5:27 ` [PATCH 2/5] drm/i915/alpm: Allow LOBF only if window1 > alpm check_entry lines Ankit Nautiyal
2025-11-14 15:09 ` Ville Syrjälä
2025-11-17 7:34 ` Nautiyal, Ankit K
2025-11-14 5:27 ` [PATCH 3/5] drm/i915/alpm: Allow LOBF only for platform that have Always on VRR TG Ankit Nautiyal
2025-11-14 15:10 ` Ville Syrjälä
2025-11-14 5:27 ` Ankit Nautiyal [this message]
2025-11-14 15:15 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ville Syrjälä
2025-11-17 7:36 ` Nautiyal, Ankit K
2025-11-14 5:27 ` [PATCH 5/5] drm/i915/alpm: Disable LOBF around transitioning for LRR/seamless MN Ankit Nautiyal
2025-11-14 7:40 ` ✓ i915.CI.BAT: success for LOBF fixes Patchwork
2025-11-14 23:08 ` ✓ i915.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-11-19 13:51 [PATCH 0/5] " Ankit Nautiyal
2025-11-19 13:51 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ankit Nautiyal
2025-11-20 8:52 ` Michał Grzelak
2025-12-17 13:49 ` Hogander, Jouni
2025-12-18 9:37 ` Nautiyal, Ankit K
2025-12-24 8:48 [PATCH 0/5] LOBF fixes Ankit Nautiyal
2025-12-24 8:48 ` [PATCH 4/5] drm/i915/alpm: Simplify and align LOBF checks in pre/post plane update Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114052746.158751-5-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox