Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/mst: Call intel_pfit_compute_config() for sharpness filter
@ 2026-04-09 10:08 Ville Syrjala
  2026-04-09 10:08 ` [PATCH 2/2] drm/i915/mst: Remove redundant has_pch_encoder=false assignment Ville Syrjala
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Ville Syrjala @ 2026-04-09 10:08 UTC (permalink / raw)
  To: intel-gfx; +Cc: intel-xe, Nemesa Garg

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The sharpness filter property is on the CRTC (as opposed to the
connector) so the expectation is that it's usable on all output
types. Since the sharpness filter is now fully integrateds into
the normal pfit code intel_pfit_compute_config() must be called
from the encoder .compute_config() on all relevant output types.

Sharpness filter is supported on LNL+ so only HDMI and DP SST/MST
outputs are actually relevant. I already took care of HDMI and
DP SST, but (as usual) forgot about DP MST. Add the missing
intel_pfit_compute_config() call to make the sharpness filter
operational on DP MST as well.

Cc: Nemesa Garg <nemesa.garg@intel.com>
Fixes: d4686f34bbeb ("drm/i915/pfit: Call intel_pfit_compute_config() unconditionally on (e)DP/HDMI")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 94f2c3a7ec59..9150763ca143 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -723,6 +723,10 @@ static int mst_stream_compute_config(struct intel_encoder *encoder,
 	pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
 	pipe_config->has_pch_encoder = false;
 
+	ret = intel_pfit_compute_config(pipe_config, conn_state);
+	if (ret)
+		return ret;
+
 	for_each_joiner_candidate(connector, adjusted_mode, num_joined_pipes) {
 		if (num_joined_pipes > 1)
 			pipe_config->joiner_pipes = GENMASK(crtc->pipe + num_joined_pipes - 1,
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-04-10  0:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09 10:08 [PATCH 1/2] drm/i915/mst: Call intel_pfit_compute_config() for sharpness filter Ville Syrjala
2026-04-09 10:08 ` [PATCH 2/2] drm/i915/mst: Remove redundant has_pch_encoder=false assignment Ville Syrjala
2026-04-09 14:14   ` Garg, Nemesa
2026-04-09 11:58 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/mst: Call intel_pfit_compute_config() for sharpness filter Patchwork
2026-04-09 14:14 ` [PATCH 1/2] " Garg, Nemesa
2026-04-10  0:42 ` ✗ i915.CI.Full: failure for series starting with [1/2] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox