From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH v2 1/9] drm/i915/hdmi: Add missing intel_pfit_mode_valid() for 4:2:0 also modes
Date: Thu, 9 Apr 2026 13:15:31 +0300 [thread overview]
Message-ID: <20260409101539.22032-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260409101539.22032-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
intel_hdmi_mode_valid() is calling intel_pfit_mode_valid() only
on the first attempt (4:2:0 for "4:2:0 only" modes, 4:4:4 for
everything else). Add the call also for the "4:2:0 also" modes case
so that we actually know the pipe scaler can actually produce the
4:2:0 output.
Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 17bd2c207453..0d88eaefbe52 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2079,6 +2079,11 @@ intel_hdmi_mode_valid(struct drm_connector *_connector,
return status;
sink_format = INTEL_OUTPUT_FORMAT_YCBCR420;
+
+ status = intel_pfit_mode_valid(display, mode, sink_format, 0);
+ if (status != MODE_OK)
+ return status;
+
status = intel_hdmi_mode_clock_valid(&connector->base, clock, has_hdmi_sink,
sink_format);
if (status != MODE_OK)
--
2.52.0
next prev parent reply other threads:[~2026-04-09 10:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 10:15 [PATCH v2 0/9] drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling Ville Syrjala
2026-04-09 10:15 ` Ville Syrjala [this message]
2026-04-09 10:15 ` [PATCH v2 2/9] drm/i915/hdmi: Restructure the sink/output format selection Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 3/9] drm/i915/hdmi: Restructure 4:2:0 vs. 4:4:4 mode validation Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 4/9] drm/i915/dp: Restructure the sink/output format selection Ville Syrjala
2026-04-09 10:51 ` Nautiyal, Ankit K
2026-04-09 10:15 ` [PATCH v2 5/9] drm/i915/dp: Validate "4:2:0 also" modes twice Ville Syrjala
2026-04-09 10:58 ` Nautiyal, Ankit K
2026-04-09 10:15 ` [PATCH v2 6/9] drm/i915/dp: Require a HDMI sink for YCbCr output via PCON Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 7/9] drm/i915/dp: Validate sink format in .mode_valid() Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 8/9] drm/i915/hdmi: Make the RGB fallback for "4:2:0 only" modes the last resort Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 9/9] drm/i915/dp: " Ville Syrjala
2026-04-09 12:28 ` ✓ i915.CI.BAT: success for drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling (rev2) Patchwork
2026-04-09 15:40 ` [PATCH v2 0/9] drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling Nicolas Frattaroli
2026-04-13 18:38 ` [PATCH v2 0/9] drm/i915/{dp,hdmi}: " Ville Syrjälä
2026-04-10 1:24 ` ✗ i915.CI.Full: failure for drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409101539.22032-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=nicolas.frattaroli@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox