Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH v2 8/9] drm/i915/hdmi: Make the RGB fallback for "4:2:0 only" modes the last resort
Date: Thu,  9 Apr 2026 13:15:38 +0300	[thread overview]
Message-ID: <20260409101539.22032-9-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260409101539.22032-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Currently we take the Hail Mary RGB fallback for "4:2:0 only" modes
already during the first pass when respect_downstream_limits==true.
It seems better to try everything else first (like ignoring TMDS
clock limits) while still preferring 4:2:0, and only if everything
else has failed fall back to RGB.

Cc: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 79093d8fc2e6..874076a29da4 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2314,7 +2314,7 @@ static int intel_hdmi_compute_formats(struct intel_encoder *encoder,
 						       respect_downstream_limits,
 						       INTEL_OUTPUT_FORMAT_YCBCR420);
 
-		if (ret) {
+		if (ret && !respect_downstream_limits) {
 			drm_dbg_kms(display->drm,
 				    "YCbCr 4:2:0 mode but YCbCr 4:2:0 output not possible. Falling back to RGB.\n");
 
-- 
2.52.0


  parent reply	other threads:[~2026-04-09 10:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 10:15 [PATCH v2 0/9] drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 1/9] drm/i915/hdmi: Add missing intel_pfit_mode_valid() for 4:2:0 also modes Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 2/9] drm/i915/hdmi: Restructure the sink/output format selection Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 3/9] drm/i915/hdmi: Restructure 4:2:0 vs. 4:4:4 mode validation Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 4/9] drm/i915/dp: Restructure the sink/output format selection Ville Syrjala
2026-04-09 10:51   ` Nautiyal, Ankit K
2026-04-09 10:15 ` [PATCH v2 5/9] drm/i915/dp: Validate "4:2:0 also" modes twice Ville Syrjala
2026-04-09 10:58   ` Nautiyal, Ankit K
2026-04-09 10:15 ` [PATCH v2 6/9] drm/i915/dp: Require a HDMI sink for YCbCr output via PCON Ville Syrjala
2026-04-09 10:15 ` [PATCH v2 7/9] drm/i915/dp: Validate sink format in .mode_valid() Ville Syrjala
2026-04-09 10:15 ` Ville Syrjala [this message]
2026-04-09 10:15 ` [PATCH v2 9/9] drm/i915/dp: Make the RGB fallback for "4:2:0 only" modes the last resort Ville Syrjala
2026-04-09 12:28 ` ✓ i915.CI.BAT: success for drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling (rev2) Patchwork
2026-04-09 15:40 ` [PATCH v2 0/9] drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling Nicolas Frattaroli
2026-04-13 18:38   ` [PATCH v2 0/9] drm/i915/{dp,hdmi}: " Ville Syrjälä
2026-04-10  1:24 ` ✗ i915.CI.Full: failure for drm/i915/{dp, hdmi}: Restructure DP/HDMI sink format handling (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260409101539.22032-9-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nicolas.frattaroli@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox