* [PATCH v1] drm/i915/display: Add command line param for DC balance
@ 2026-08-28 8:50 Mitul Golani
2026-08-28 9:07 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mitul Golani @ 2026-08-28 8:50 UTC (permalink / raw)
To: intel-gfx; +Cc: intel-xe, ankit.k.nautiyal
Add a new module parameter 'enable_dc_balance' to allow enabling or
disabling the VRR DC balance feature at runtime. The DC balance
computation in intel_vrr_dc_balance_compute_config() now honours this
parameter, so the feature can be toggled without recompiling.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
drivers/gpu/drm/i915/display/intel_vrr.c | 4 +++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 2aed110c5b09..ed3aa84c5d43 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -120,6 +120,9 @@ intel_display_param_named_unsafe(enable_psr, int, 0400,
"(0=disabled, 1=enable up to PSR1, 2=enable up to PSR2) "
"Default: -1 (use per-chip default)");
+intel_display_param_named_unsafe(enable_dc_balance, int, 0400,
+ "Enable DC Balance (0=disabled, 1=enable). Default: 1 (use per-chip default)");
+
intel_display_param_named_unsafe(enable_panel_replay, int, 0400,
"Enable Panel Replay (0=disabled, 1=enabled). Default: -1 (use per-chip default)");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index b95ecf728daa..8c28c27e2c46 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -46,6 +46,7 @@ struct drm_printer;
param(bool, enable_dp_mst, true, 0600) \
param(int, enable_fbc, -1, 0600) \
param(int, enable_psr, -1, 0600) \
+ param(int, enable_dc_balance, false, 0600) \
param(int, enable_panel_replay, -1, 0600) \
param(bool, psr_safest_params, false, 0400) \
param(bool, enable_psr2_sel_fetch, true, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index e36db1174440..1698c54e258b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -439,10 +439,12 @@ static bool intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_st
static void
intel_vrr_dc_balance_compute_config(struct intel_crtc_state *crtc_state)
{
+ struct intel_display *display = to_intel_display(crtc_state);
int guardband_usec, adjustment_usec;
struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
- if (!intel_vrr_dc_balance_possible(crtc_state) || !crtc_state->vrr.enable)
+ if (!intel_vrr_dc_balance_possible(crtc_state) ||
+ !crtc_state->vrr.enable || !display->params.enable_dc_balance)
return;
crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax;
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drm/i915/display: Add command line param for DC balance
2026-08-28 8:50 [PATCH v1] drm/i915/display: Add command line param for DC balance Mitul Golani
@ 2026-08-28 9:07 ` sashiko-bot
2026-08-28 10:00 ` ✗ i915.CI.BAT: failure for " Patchwork
2026-08-28 10:15 ` [PATCH v1] " Borah, Chaitanya Kumar
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-08-28 9:07 UTC (permalink / raw)
To: Mitul Golani; +Cc: intel-gfx, intel-xe
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `enable_dc_balance` module parameter is initialized to `false` (0), unintentionally disabling the VRR DC balancing feature by default and contradicting the intended default behavior.
--
commit ce08e2bbe0ea201e24fac54e608cc7792b588403
Author: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
drm/i915/display: Add command line param for DC balance
This commit adds a new module parameter enable_dc_balance to allow enabling
or disabling the VRR DC balance feature at runtime. The DC balance
computation in intel_vrr_dc_balance_compute_config() is updated to honor
this parameter.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
> index 2aed110c5b090..ed3aa84c5d43d 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.c
> @@ -120,6 +120,9 @@ intel_display_param_named_unsafe(enable_psr, int, 0400,
[ ... ]
> +intel_display_param_named_unsafe(enable_dc_balance, int, 0400,
> + "Enable DC Balance (0=disabled, 1=enable). Default: 1 (use per-chip default)");
[Severity: Medium]
The parameter documentation in intel_display_param_named_unsafe() states
that the default value is 1, but the underlying parameter definition sets
it to false.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
> index b95ecf728daab..8c28c27e2c46c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.h
> @@ -46,6 +46,7 @@ struct drm_printer;
[ ... ]
> param(int, enable_psr, -1, 0600) \
> + param(int, enable_dc_balance, false, 0600) \
[Severity: Medium]
Does this unintentionally disable the VRR DC balance feature by default?
The macro initializes enable_dc_balance to false (0), contradicting the
intended default documented above.
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 51e4f3309b8b1..cfc0cfbff017a 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -386,10 +386,12 @@ static bool intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_st
> static void
> intel_vrr_dc_balance_compute_config(struct intel_crtc_state *crtc_state)
> {
[ ... ]
> - if (!intel_vrr_dc_balance_possible(crtc_state) || !crtc_state->vrr.enable)
> + if (!intel_vrr_dc_balance_possible(crtc_state) ||
> + !crtc_state->vrr.enable || !display->params.enable_dc_balance)
> return;
[Severity: Medium]
Because the parameter defaults to 0, !display->params.enable_dc_balance
evaluates to true here. Can this cause intel_vrr_dc_balance_compute_config()
to silently bail out early, disabling the feature by default on all
configurations?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260828085037.1430881-1-mitulkumar.ajitkumar.golani@intel.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915/display: Add command line param for DC balance
2026-08-28 8:50 [PATCH v1] drm/i915/display: Add command line param for DC balance Mitul Golani
2026-08-28 9:07 ` sashiko-bot
@ 2026-08-28 10:00 ` Patchwork
2026-08-28 10:15 ` [PATCH v1] " Borah, Chaitanya Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2026-08-28 10:00 UTC (permalink / raw)
To: Mitul Golani; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11494 bytes --]
== Series Details ==
Series: drm/i915/display: Add command line param for DC balance
URL : https://patchwork.freedesktop.org/series/172946/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_19057 -> Patchwork_172946v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_172946v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_172946v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/index.html
Participating hosts (39 -> 38)
------------------------------
Additional (2): fi-hsw-4770 bat-arls-5
Missing (3): bat-dg2-13 fi-glk-j4005 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_172946v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_gttfill@basic:
- fi-bsw-nick: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_19057/fi-bsw-nick/igt@gem_exec_gttfill@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-bsw-nick/igt@gem_exec_gttfill@basic.html
Known issues
------------
Here are the changes found in Patchwork_172946v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- bat-arls-5: NOTRUN -> [SKIP][3] ([i915#10213] / [i915#11671]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#4613]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_mmap@basic:
- bat-arls-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@gem_mmap@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-arls-5: NOTRUN -> [SKIP][6] ([i915#10197] / [i915#10211] / [i915#4079])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@gem_render_tiled_blits@basic.html
* igt@gem_softpin@allocator-basic-reserve:
- fi-hsw-4770: NOTRUN -> [SKIP][7] +15 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html
* igt@gem_tiled_blits@basic:
- bat-arls-5: NOTRUN -> [SKIP][8] ([i915#12637] / [i915#4077]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic@basic:
- bat-arls-5: NOTRUN -> [SKIP][9] ([i915#15657])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@gem_tiled_pread_basic@basic.html
* igt@i915_pm_rps@basic-api:
- bat-arls-5: NOTRUN -> [SKIP][10] ([i915#10209] / [i915#11681])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@i915_pm_rps@basic-api.html
* igt@intel_hwmon@hwmon-read:
- bat-arls-5: NOTRUN -> [SKIP][11] ([i915#7707]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@intel_hwmon@hwmon-read.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][12] ([i915#5190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
- bat-arls-5: NOTRUN -> [SKIP][13] ([i915#10200] / [i915#12203])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@clobberred-modifier:
- bat-arls-5: NOTRUN -> [SKIP][14] ([i915#10200]) +8 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_addfb_basic@clobberred-modifier.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-arls-5: NOTRUN -> [SKIP][15] ([i915#10202]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-arls-5: NOTRUN -> [SKIP][16] ([i915#16361])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-arls-5: NOTRUN -> [SKIP][17] ([i915#10207])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_force_connector_basic@force-load-detect.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][18]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_hdmi_inject@inject-audio:
- fi-tgl-1115g4: NOTRUN -> [SKIP][19] ([i915#13030])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_pm_backlight@basic-brightness:
- bat-arls-5: NOTRUN -> [SKIP][20] ([i915#9812])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_pm_backlight@basic-brightness.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][21] ([i915#12343] / [i915#9812])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-primary-page-flip:
- bat-arls-5: NOTRUN -> [SKIP][22] ([i915#9732]) +3 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_psr@psr-primary-page-flip.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][23] ([i915#9732]) +3 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_psr@psr-primary-page-flip.html
* igt@kms_psr@psr-sprite-plane-onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][24] ([i915#1072]) +3 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-hsw-4770/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-arls-5: NOTRUN -> [SKIP][25] ([i915#10208] / [i915#8809])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@kms_setmode@basic-clone-single-crtc.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][26] ([i915#3555])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-arls-5: NOTRUN -> [SKIP][27] ([i915#10212] / [i915#3708])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-arls-5: NOTRUN -> [SKIP][28] ([i915#12637] / [i915#3708] / [i915#4077]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-read:
- bat-arls-5: NOTRUN -> [SKIP][29] ([i915#10214] / [i915#3708])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-write:
- bat-arls-5: NOTRUN -> [SKIP][30] ([i915#10216] / [i915#3708])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/bat-arls-5/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a1:
- fi-tgl-1115g4: [ABORT][31] ([i915#16837] / [i915#16872] / [i915#16881]) -> [PASS][32] +1 other test pass
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_19057/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/fi-tgl-1115g4/igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a1.html
[i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
[i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
[i915#10202]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10202
[i915#10207]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10207
[i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
[i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
[i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
[i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
[i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
[i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
[i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
[i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
[i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
[i915#12343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12343
[i915#12637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12637
[i915#13030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13030
[i915#15657]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15657
[i915#16361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16361
[i915#16837]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16837
[i915#16872]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16872
[i915#16881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16881
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
Build changes
-------------
* Linux: CI_DRM_19057 -> Patchwork_172946v1
CI-20190529: 20190529
CI_DRM_19057: 5901f93eb5a007e8b7c21ca2b5bfae5958467832 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_9078: 9078
Patchwork_172946v1: 5901f93eb5a007e8b7c21ca2b5bfae5958467832 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_172946v1/index.html
[-- Attachment #2: Type: text/html, Size: 13300 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drm/i915/display: Add command line param for DC balance
2026-08-28 8:50 [PATCH v1] drm/i915/display: Add command line param for DC balance Mitul Golani
2026-08-28 9:07 ` sashiko-bot
2026-08-28 10:00 ` ✗ i915.CI.BAT: failure for " Patchwork
@ 2026-08-28 10:15 ` Borah, Chaitanya Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Borah, Chaitanya Kumar @ 2026-08-28 10:15 UTC (permalink / raw)
To: Mitul Golani, intel-gfx; +Cc: intel-xe, ankit.k.nautiyal
On 8/28/2026 2:20 PM, Mitul Golani wrote:
> Add a new module parameter 'enable_dc_balance' to allow enabling or
> disabling the VRR DC balance feature at runtime. The DC balance
> computation in intel_vrr_dc_balance_compute_config() now honours this
> parameter, so the feature can be toggled without recompiling.
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
> drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
> drivers/gpu/drm/i915/display/intel_vrr.c | 4 +++-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
> index 2aed110c5b09..ed3aa84c5d43 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.c
> @@ -120,6 +120,9 @@ intel_display_param_named_unsafe(enable_psr, int, 0400,
> "(0=disabled, 1=enable up to PSR1, 2=enable up to PSR2) "
> "Default: -1 (use per-chip default)");
>
> +intel_display_param_named_unsafe(enable_dc_balance, int, 0400,
> + "Enable DC Balance (0=disabled, 1=enable). Default: 1 (use per-chip default)");
> +
> intel_display_param_named_unsafe(enable_panel_replay, int, 0400,
> "Enable Panel Replay (0=disabled, 1=enabled). Default: -1 (use per-chip default)");
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
> index b95ecf728daa..8c28c27e2c46 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.h
> @@ -46,6 +46,7 @@ struct drm_printer;
> param(bool, enable_dp_mst, true, 0600) \
> param(int, enable_fbc, -1, 0600) \
> param(int, enable_psr, -1, 0600) \
> + param(int, enable_dc_balance, false, 0600) \
You mean true?
> param(int, enable_panel_replay, -1, 0600) \
> param(bool, psr_safest_params, false, 0400) \
> param(bool, enable_psr2_sel_fetch, true, 0400) \
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index e36db1174440..1698c54e258b 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -439,10 +439,12 @@ static bool intel_vrr_dc_balance_possible(const struct intel_crtc_state *crtc_st
> static void
> intel_vrr_dc_balance_compute_config(struct intel_crtc_state *crtc_state)
> {
> + struct intel_display *display = to_intel_display(crtc_state);
> int guardband_usec, adjustment_usec;
> struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
>
> - if (!intel_vrr_dc_balance_possible(crtc_state) || !crtc_state->vrr.enable)
> + if (!intel_vrr_dc_balance_possible(crtc_state) ||
> + !crtc_state->vrr.enable || !display->params.enable_dc_balance)
> return;
>
> crtc_state->vrr.dc_balance.vmax = crtc_state->vrr.vmax;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-28 10:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-28 8:50 [PATCH v1] drm/i915/display: Add command line param for DC balance Mitul Golani
2026-08-28 9:07 ` sashiko-bot
2026-08-28 10:00 ` ✗ i915.CI.BAT: failure for " Patchwork
2026-08-28 10:15 ` [PATCH v1] " Borah, Chaitanya Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox