Re: [v4 4/4] drm/i915/display: Gate periodic AS SDP skip frames behind a module parameter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'periodic_assdp_enable' module parameter is defined with a writable sysfs permission (0600) instead of the required read-only permission (0400), creating a broken runtime interface.
--

commit 717499623e1a0ce1f0b28267e96deb4b7a335eaf
Author: Uma Shankar <uma.shankar@intel.com>

drm/i915/display: Gate periodic AS SDP skip frames behind a module parameter

This commit introduces a new module parameter, periodic_assdp_enable, to
control periodic Adaptive-Sync SDP skip frames for Panel Replay. The
parameter defaults to false and uses the intel_display_params
infrastructure.

> diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
> index 2aed110c5b090..a845d29610cf1 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_params.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_params.c
[ ... ]
> @@ -139,6 +139,12 @@ intel_display_param_named_unsafe(enable_dmc_wl, int, 0400,
>  	"(-1=use per-chip default, 0=disabled, 1=enabled, 2=match any register, 3=always locked) "
>  	"Default: -1");
>  
> +intel_display_param_named_unsafe(periodic_assdp_enable, bool, 0600,

[Severity: Medium]
Does this parameter need to be writable (0600) at runtime?

Since global module parameters are copied to display->params during driver
initialization, changing this value via sysfs at runtime doesn't appear to
take effect on active displays.

Should this be read-only (0400) like the other intel_display_params to
prevent creating a misleading sysfs interface?

> +	"Enable periodic Adaptive-Sync SDP (AS SDP skip frames) for Panel Replay "
> +	"to drive the panel down to its minimum refresh rate "
> +	"(0=disabled, 1=enabled) "
> +	"Default: 0");
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831213421.1804635-1-uma.shankar@intel.com?part=4