Re: [PATCH v10 8/8] drm/i915/display: Compute vrr vsync params

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 5/30/2024 11:34 AM, Mitul Golani wrote:
> Compute vrr vsync params in case of FAVT as well instead of
> only to AVT mode of operation.
>
> --v2:
> - Remove redundant computation for vrr_vsync_start
> and vrr_vsync_end(Ankit).
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 17 +++++++++--------
>   1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 1e4e2d8a0927..2090a12b38aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -217,14 +217,6 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
>   	if (crtc_state->uapi.vrr_enabled) {
>   		crtc_state->vrr.enable = true;
>   		crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
> -		if (intel_dp_as_sdp_supported(intel_dp)) {
> -			crtc_state->vrr.vsync_start =
> -				(crtc_state->hw.adjusted_mode.crtc_vtotal -
> -					crtc_state->hw.adjusted_mode.vsync_start);
> -			crtc_state->vrr.vsync_end =
> -				(crtc_state->hw.adjusted_mode.crtc_vtotal -
> -					crtc_state->hw.adjusted_mode.vsync_end);
> -		}
>   	} else if (is_cmrr_frac_required(crtc_state) && is_edp) {
>   		crtc_state->vrr.enable = true;
>   		crtc_state->cmrr.enable = true;
> @@ -234,6 +226,15 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
>   		crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
>   	}
>   
> +	if (intel_dp_as_sdp_supported(intel_dp)) {

Need to add check for vrr.enable as we set this only when vrr.enable is set.

Otherwise looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


Regards,

Ankit

> +		crtc_state->vrr.vsync_start =
> +			(crtc_state->hw.adjusted_mode.crtc_vtotal -
> +			 crtc_state->hw.adjusted_mode.vsync_start);
> +		crtc_state->vrr.vsync_end =
> +			(crtc_state->hw.adjusted_mode.crtc_vtotal -
> +			 crtc_state->hw.adjusted_mode.vsync_end);
> +	}
> +
>   	/*
>   	 * For XE_LPD+, we use guardband and pipeline override
>   	 * is deprecated.