Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/uc: Introduce GSC FW
Date: Thu, 8 Dec 2022 04:09:18 +0000	[thread overview]
Message-ID: <22ea213325fc16966c55632642d73e8ed837f569.camel@intel.com> (raw)
In-Reply-To: <20221206011908.2745508-2-daniele.ceraolospurio@intel.com>

On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote:
> On MTL the GSC FW needs to be loaded on the media GT by the graphics
> driver. We're going to treat it like a new uc_fw, so add the initial
> defs and init/fini functions for it.
> 
> Similarly to the other FWs, the GSC FW path can be overriden via
> modparam. The modparam can also be used to disable the GSC FW loading by
> setting it to an empty string.
> 
> Note that the new structure has been called intel_gsc_uc to avoid
> confusion with the existing intel_gsc, which instead represents the heci
> gsc interfaces.
> 
> v2: re-order Makefile list to be properly sorted (Jani, Alan), better
>     comment (alan)
> 
Alan:[snip]

As per offline conversation, i re-reviewed the difference from Rev1 to Rev2 - i.e. just the makefile and the comment changes, all looks good, so:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

  reply	other threads:[~2022-12-08  4:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  1:19 [Intel-gfx] [PATCH v2 0/6] drm/i915: Add support for GSC FW loading Daniele Ceraolo Spurio
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/uc: Introduce GSC FW Daniele Ceraolo Spurio
2022-12-08  4:09   ` Teres Alexis, Alan Previn [this message]
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gsc: Skip the version check when fetching the " Daniele Ceraolo Spurio
2022-12-08  5:23   ` Teres Alexis, Alan Previn
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gsc: GSC firmware loading Daniele Ceraolo Spurio
2022-12-06  5:15   ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
2022-12-07 10:16     ` Teres Alexis, Alan Previn
2022-12-07 16:46       ` Ceraolo Spurio, Daniele
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded Daniele Ceraolo Spurio
2022-12-06  8:52   ` Rodrigo Vivi
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/gsc: Disable GSC engine and power well if FW is not selected Daniele Ceraolo Spurio
2022-12-06  1:19 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/mtl: MTL has one GSC CS on the media GT Daniele Ceraolo Spurio
2022-12-06  2:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add support for GSC FW loading (rev2) Patchwork
2022-12-06  5:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for GSC FW loading (rev3) Patchwork
2022-12-06  5:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-12-06  5:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-06  7:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22ea213325fc16966c55632642d73e8ed837f569.camel@intel.com \
    --to=alan.previn.teres.alexis@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox