From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW
Date: Thu, 8 Dec 2022 05:23:54 +0000 [thread overview]
Message-ID: <d9e37bed5e4098380466646c17c7fe1fdcea9ab9.camel@intel.com> (raw)
In-Reply-To: <20221206011908.2745508-3-daniele.ceraolospurio@intel.com>
On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote:
> The current exectation from the FW side is that the driver will query
> the GSC FW version after the FW is loaded, similarly to what the mei
> driver does on DG2. However, we're discussing with the FW team if there
> is a way to extract the version from the bin file before loading, so we
> can keep the code the same as for older FWs.
>
> Since the GSC FW version is not currently required for functionality and
> is only needed for debug purposes, we can skip the FW version for now at
> fetch time and add it later on when we've agreed on the approach.
>
> v2: rebased on uc_fw version struct changes.
>
Alan:[snip]
Reviewed the changes that came from the rebase (upstream merges) - so minor i missed it at first.
Functionally identical as before so:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
next prev parent reply other threads:[~2022-12-08 5:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 1:19 [Intel-gfx] [PATCH v2 0/6] drm/i915: Add support for GSC FW loading Daniele Ceraolo Spurio
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 1/6] drm/i915/uc: Introduce GSC FW Daniele Ceraolo Spurio
2022-12-08 4:09 ` Teres Alexis, Alan Previn
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 2/6] drm/i915/gsc: Skip the version check when fetching the " Daniele Ceraolo Spurio
2022-12-08 5:23 ` Teres Alexis, Alan Previn [this message]
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 3/6] drm/i915/gsc: GSC firmware loading Daniele Ceraolo Spurio
2022-12-06 5:15 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
2022-12-07 10:16 ` Teres Alexis, Alan Previn
2022-12-07 16:46 ` Ceraolo Spurio, Daniele
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 4/6] drm/i915/gsc: Do a driver-FLR on unload if GSC was loaded Daniele Ceraolo Spurio
2022-12-06 8:52 ` Rodrigo Vivi
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 5/6] drm/i915/gsc: Disable GSC engine and power well if FW is not selected Daniele Ceraolo Spurio
2022-12-06 1:19 ` [Intel-gfx] [PATCH v2 6/6] drm/i915/mtl: MTL has one GSC CS on the media GT Daniele Ceraolo Spurio
2022-12-06 2:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add support for GSC FW loading (rev2) Patchwork
2022-12-06 5:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for GSC FW loading (rev3) Patchwork
2022-12-06 5:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-12-06 5:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-12-06 7:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e37bed5e4098380466646c17c7fe1fdcea9ab9.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox