[PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!

[PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!

[Chris Wilson]

Even with 128MiB reserved for other use, a single pass of gem_exec_big
runs out of memory. Give in and halve our batch size, that has to be
enough slack! As to why it keeps on failing, is left as an exercise to
the reader -- we have to solve the mm/ mystery one day, as eventually it
will be our only remaining source of bugs!

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
---
 tests/i915/gem_exec_big.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
index 015f59e29..440136ee8 100644
--- a/tests/i915/gem_exec_big.c
+++ b/tests/i915/gem_exec_big.c
@@ -260,7 +260,7 @@ static void single(int i915)
 	uint32_t handle;
 	void *ptr;
 
-	batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
+	batch_size = (intel_get_avail_ram_mb() / 2) << 20; /* XXX CI slack? */
 	limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
 	if (!gem_uses_full_ppgtt(i915))
 		limit = 3 * limit / 4;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] i915/gem_exec_big: 128MiB not enough slack? Let out the rope!

[Tvrtko Ursulin]

On 26/03/2019 18:57, Chris Wilson wrote:
> Even with 128MiB reserved for other use, a single pass of gem_exec_big
> runs out of memory. Give in and halve our batch size, that has to be
> enough slack! As to why it keeps on failing, is left as an exercise to
> the reader -- we have to solve the mm/ mystery one day, as eventually it
> will be our only remaining source of bugs!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
>   tests/i915/gem_exec_big.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_big.c b/tests/i915/gem_exec_big.c
> index 015f59e29..440136ee8 100644
> --- a/tests/i915/gem_exec_big.c
> +++ b/tests/i915/gem_exec_big.c
> @@ -260,7 +260,7 @@ static void single(int i915)
>   	uint32_t handle;
>   	void *ptr;
>   
> -	batch_size = (intel_get_avail_ram_mb() - 128) << 20; /* CI slack */
> +	batch_size = (intel_get_avail_ram_mb() / 2) << 20; /* XXX CI slack? */
>   	limit = gem_aperture_size(i915) - (256 << 10); /* low pages reserved */
>   	if (!gem_uses_full_ppgtt(i915))
>   		limit = 3 * limit / 4;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx