public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: Re: [PATCH] drm/i915: be less verbose about inability to provide vendor backlight
Date: Thu, 25 Oct 2012 09:51:06 +0100	[thread overview]
Message-ID: <275ffc$74tp0r@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1351151859-24853-1-git-send-email-jani.nikula@intel.com>

On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> commit 28dcc2d60cb570d9f549c329b2f51400553412a1
> Author: Jani Nikula <jani.nikula@intel.com>
> Date:   Mon Sep 3 16:25:12 2012 +0300
> 
>     drm/i915: do not expose a dysfunctional backlight interface to userspace
> 
> prevents backlight interface creation if the BIOS has not set the backlight
> PWM CTL registers that contain the max PWM value. It's apparently normal on
> those machines, so demote the message about it to debug level.
> 
> Reported-by: Orion Poplawski <orion@cora.nwra.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

We may want to create an explicit bug/task to track the missing
initialisation as a reminder as well.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-10-25  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25  7:57 [PATCH] drm/i915: be less verbose about inability to provide vendor backlight Jani Nikula
2012-10-25  8:51 ` Chris Wilson [this message]
2012-10-26 15:45   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='275ffc$74tp0r@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox