* [PATCH] drm/i915: be less verbose about inability to provide vendor backlight
@ 2012-10-25 7:57 Jani Nikula
2012-10-25 8:51 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2012-10-25 7:57 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
commit 28dcc2d60cb570d9f549c329b2f51400553412a1
Author: Jani Nikula <jani.nikula@intel.com>
Date: Mon Sep 3 16:25:12 2012 +0300
drm/i915: do not expose a dysfunctional backlight interface to userspace
prevents backlight interface creation if the BIOS has not set the backlight
PWM CTL registers that contain the max PWM value. It's apparently normal on
those machines, so demote the message about it to debug level.
Reported-by: Orion Poplawski <orion@cora.nwra.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index e91a0bb..bd96eec 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -428,7 +428,7 @@ int intel_panel_setup_backlight(struct drm_connector *connector)
props.type = BACKLIGHT_RAW;
props.max_brightness = _intel_panel_get_max_backlight(dev);
if (props.max_brightness == 0) {
- DRM_ERROR("Failed to get maximum backlight value\n");
+ DRM_DEBUG_DRIVER("Failed to get maximum backlight value\n");
return -ENODEV;
}
dev_priv->backlight =
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: be less verbose about inability to provide vendor backlight
2012-10-25 7:57 [PATCH] drm/i915: be less verbose about inability to provide vendor backlight Jani Nikula
@ 2012-10-25 8:51 ` Chris Wilson
2012-10-26 15:45 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2012-10-25 8:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> commit 28dcc2d60cb570d9f549c329b2f51400553412a1
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Mon Sep 3 16:25:12 2012 +0300
>
> drm/i915: do not expose a dysfunctional backlight interface to userspace
>
> prevents backlight interface creation if the BIOS has not set the backlight
> PWM CTL registers that contain the max PWM value. It's apparently normal on
> those machines, so demote the message about it to debug level.
>
> Reported-by: Orion Poplawski <orion@cora.nwra.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
We may want to create an explicit bug/task to track the missing
initialisation as a reminder as well.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: be less verbose about inability to provide vendor backlight
2012-10-25 8:51 ` Chris Wilson
@ 2012-10-26 15:45 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-10-26 15:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: Jani Nikula, intel-gfx
On Thu, Oct 25, 2012 at 09:51:06AM +0100, Chris Wilson wrote:
> On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> > commit 28dcc2d60cb570d9f549c329b2f51400553412a1
> > Author: Jani Nikula <jani.nikula@intel.com>
> > Date: Mon Sep 3 16:25:12 2012 +0300
> >
> > drm/i915: do not expose a dysfunctional backlight interface to userspace
> >
> > prevents backlight interface creation if the BIOS has not set the backlight
> > PWM CTL registers that contain the max PWM value. It's apparently normal on
> > those machines, so demote the message about it to debug level.
> >
> > Reported-by: Orion Poplawski <orion@cora.nwra.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> We may want to create an explicit bug/task to track the missing
> initialisation as a reminder as well.
I suspect we'll get them automatically when people complain about
non-working backlights. Like they already do for non-working edp without
the bios' help. Till that happens, I'm choosing blissfull ignorance ;-)
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-26 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 7:57 [PATCH] drm/i915: be less verbose about inability to provide vendor backlight Jani Nikula
2012-10-25 8:51 ` Chris Wilson
2012-10-26 15:45 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox