Re: [PATCH 2/2] drm/bridge: prefer drm_printf_indent() over inline \t

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 4/8/2026 1:52 PM, Jani Nikula wrote:
> We have a helper drm_printf_indent() for tab indenting the prints. It
> makes the actual strings more readable, and highlights the indented
> parts better in source.

LGTM.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/drm_bridge.c | 13 ++++++-------
>   1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index d6f512b73389..bac1aae497e0 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -1613,18 +1613,17 @@ static void drm_bridge_debugfs_show_bridge(struct drm_printer *p,
>   
>   	drm_printf(p, "bridge[%u]: %ps\n", idx, bridge->funcs);
>   
> -	drm_printf(p, "\trefcount: %u%s\n", refcount,
> -		   lingering ? " [lingering]" : "");
> +	drm_printf_indent(p, 1, "refcount: %u%s\n", refcount,
> +			  lingering ? " [lingering]" : "");
>   
> -	drm_printf(p, "\ttype: [%d] %s\n",
> -		   bridge->type,
> -		   drm_get_connector_type_name(bridge->type));
> +	drm_printf_indent(p, 1, "type: [%d] %s\n", bridge->type,
> +			  drm_get_connector_type_name(bridge->type));
>   
>   	/* The OF node could be freed after drm_bridge_remove() */
>   	if (bridge->of_node && !lingering)
> -		drm_printf(p, "\tOF: %pOFfc\n", bridge->of_node);
> +		drm_printf_indent(p, 1, "OF: %pOFfc\n", bridge->of_node);
>   
> -	drm_printf(p, "\tops: [0x%x]", bridge->ops);
> +	drm_printf_indent(p, 1, "ops: [0x%x]", bridge->ops);
>   	if (bridge->ops & DRM_BRIDGE_OP_DETECT)
>   		drm_puts(p, " detect");
>   	if (bridge->ops & DRM_BRIDGE_OP_EDID)