From: Jani Nikula <jani.nikula@intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/atomic: prefer drm_printf_indent() over inline \t
Date: Thu, 30 Apr 2026 11:05:59 +0300 [thread overview]
Message-ID: <4db5cc90006a00bdab50169703a796fbd7207d10@intel.com> (raw)
In-Reply-To: <34ee3359-89e0-496d-be0f-e2baaf850091@intel.com>
On Wed, 29 Apr 2026, "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:
> On 4/8/2026 1:52 PM, Jani Nikula wrote:
>> We have a helper drm_printf_indent() for tab indenting the prints. It
>> makes the actual strings more readable, and highlights the indented
>> parts better in source.
>
> aah, you beat me to it :)
>
> On this, LGTM.
>
> Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Thanks, pushed to drm-misc-next.
> Should we make the changes in xe/i915 too? I can take it up if you
> want.
Yes, I think so.
I've already got a bunch of changes for debugfs stuff, I'll just need to
polish the commit messages and send, otherwise please go wild. ;)
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-04-30 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:22 [PATCH 1/2] drm/atomic: prefer drm_printf_indent() over inline \t Jani Nikula
2026-04-08 8:22 ` [PATCH 2/2] drm/bridge: " Jani Nikula
2026-04-29 5:53 ` Borah, Chaitanya Kumar
2026-04-08 16:38 ` ✓ i915.CI.BAT: success for series starting with [1/2] drm/atomic: " Patchwork
2026-04-08 20:04 ` ✓ i915.CI.Full: " Patchwork
2026-04-29 5:51 ` [PATCH 1/2] " Borah, Chaitanya Kumar
2026-04-30 8:05 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4db5cc90006a00bdab50169703a796fbd7207d10@intel.com \
--to=jani.nikula@intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox