From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Make i915_vma_destroy() static
Date: Fri, 16 Jun 2017 14:00:15 +0100 [thread overview]
Message-ID: <290b6cc5-261b-38d6-5733-6d950ac89e81@linux.intel.com> (raw)
In-Reply-To: <20170616123508.12673-1-chris@chris-wilson.co.uk>
On 16/06/2017 13:35, Chris Wilson wrote:
> i915_vma_destroy() is now not used outside of i915_vma.c so we can
> remove the export and make the function static.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 +-
> drivers/gpu/drm/i915/i915_vma.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index aa4f98e33951..74e48e3459b3 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -602,7 +602,7 @@ int __i915_vma_do_pin(struct i915_vma *vma,
> return ret;
> }
>
> -void i915_vma_destroy(struct i915_vma *vma)
> +static void i915_vma_destroy(struct i915_vma *vma)
> {
> GEM_BUG_ON(vma->node.allocated);
> GEM_BUG_ON(i915_vma_is_active(vma));
> diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
> index 36014894400a..d9e52f76cd07 100644
> --- a/drivers/gpu/drm/i915/i915_vma.h
> +++ b/drivers/gpu/drm/i915/i915_vma.h
> @@ -236,7 +236,6 @@ bool i915_vma_misplaced(const struct i915_vma *vma,
> void __i915_vma_set_map_and_fenceable(struct i915_vma *vma);
> int __must_check i915_vma_unbind(struct i915_vma *vma);
> void i915_vma_close(struct i915_vma *vma);
> -void i915_vma_destroy(struct i915_vma *vma);
>
> int __i915_vma_do_pin(struct i915_vma *vma,
> u64 size, u64 alignment, u64 flags);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-16 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 12:35 [PATCH] drm/i915: Make i915_vma_destroy() static Chris Wilson
2017-06-16 12:58 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-06-16 13:00 ` Tvrtko Ursulin [this message]
2017-06-16 13:33 ` [PATCH] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290b6cc5-261b-38d6-5733-6d950ac89e81@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox