* [PATCH] drm/i915: Make i915_vma_destroy() static
@ 2017-06-16 12:35 Chris Wilson
2017-06-16 12:58 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-06-16 13:00 ` [PATCH] " Tvrtko Ursulin
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2017-06-16 12:35 UTC (permalink / raw)
To: intel-gfx
i915_vma_destroy() is now not used outside of i915_vma.c so we can
remove the export and make the function static.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
---
drivers/gpu/drm/i915/i915_vma.c | 2 +-
drivers/gpu/drm/i915/i915_vma.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index aa4f98e33951..74e48e3459b3 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -602,7 +602,7 @@ int __i915_vma_do_pin(struct i915_vma *vma,
return ret;
}
-void i915_vma_destroy(struct i915_vma *vma)
+static void i915_vma_destroy(struct i915_vma *vma)
{
GEM_BUG_ON(vma->node.allocated);
GEM_BUG_ON(i915_vma_is_active(vma));
diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
index 36014894400a..d9e52f76cd07 100644
--- a/drivers/gpu/drm/i915/i915_vma.h
+++ b/drivers/gpu/drm/i915/i915_vma.h
@@ -236,7 +236,6 @@ bool i915_vma_misplaced(const struct i915_vma *vma,
void __i915_vma_set_map_and_fenceable(struct i915_vma *vma);
int __must_check i915_vma_unbind(struct i915_vma *vma);
void i915_vma_close(struct i915_vma *vma);
-void i915_vma_destroy(struct i915_vma *vma);
int __i915_vma_do_pin(struct i915_vma *vma,
u64 size, u64 alignment, u64 flags);
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.BAT: warning for drm/i915: Make i915_vma_destroy() static
2017-06-16 12:35 [PATCH] drm/i915: Make i915_vma_destroy() static Chris Wilson
@ 2017-06-16 12:58 ` Patchwork
2017-06-16 13:00 ` [PATCH] " Tvrtko Ursulin
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-06-16 12:58 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Make i915_vma_destroy() static
URL : https://patchwork.freedesktop.org/series/25905/
State : warning
== Summary ==
Series 25905v1 drm/i915: Make i915_vma_destroy() static
https://patchwork.freedesktop.org/api/1.0/series/25905/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125
Test kms_pipe_crc_basic:
Subgroup bad-nb-words-1:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup bad-nb-words-3:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup bad-pipe:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup bad-source:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup hang-read-crc-pipe-a:
fail -> DMESG-FAIL (fi-skl-6700hq) fdo#101154 +15
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101154 https://bugs.freedesktop.org/show_bug.cgi?id=101154
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:469s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:488s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:584s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:556s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:492s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:485s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:598s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:442s
fi-hsw-4770r total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:16 time:418s
fi-ilk-650 total:278 pass:227 dwarn:0 dfail:0 fail:0 skip:50 time:469s
fi-ivb-3520m total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:18 time:492s
fi-ivb-3770 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:18 time:513s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:480s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:571s
fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:578s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:485s
fi-skl-6700hq total:278 pass:224 dwarn:5 dfail:16 fail:11 skip:22 time:479s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:515s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:507s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:512s
fi-snb-2520m total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:28 time:628s
fi-snb-2600 total:278 pass:246 dwarn:0 dfail:0 fail:2 skip:29 time:408s
728e84dbddb4fc5f7a4e48dafcda215c527737ca drm-tip: 2017y-06m-16d-07h-10m-54s UTC integration manifest
731183d drm/i915: Make i915_vma_destroy() static
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4968/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Make i915_vma_destroy() static
2017-06-16 12:35 [PATCH] drm/i915: Make i915_vma_destroy() static Chris Wilson
2017-06-16 12:58 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-06-16 13:00 ` Tvrtko Ursulin
2017-06-16 13:33 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Tvrtko Ursulin @ 2017-06-16 13:00 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 16/06/2017 13:35, Chris Wilson wrote:
> i915_vma_destroy() is now not used outside of i915_vma.c so we can
> remove the export and make the function static.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 +-
> drivers/gpu/drm/i915/i915_vma.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index aa4f98e33951..74e48e3459b3 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -602,7 +602,7 @@ int __i915_vma_do_pin(struct i915_vma *vma,
> return ret;
> }
>
> -void i915_vma_destroy(struct i915_vma *vma)
> +static void i915_vma_destroy(struct i915_vma *vma)
> {
> GEM_BUG_ON(vma->node.allocated);
> GEM_BUG_ON(i915_vma_is_active(vma));
> diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
> index 36014894400a..d9e52f76cd07 100644
> --- a/drivers/gpu/drm/i915/i915_vma.h
> +++ b/drivers/gpu/drm/i915/i915_vma.h
> @@ -236,7 +236,6 @@ bool i915_vma_misplaced(const struct i915_vma *vma,
> void __i915_vma_set_map_and_fenceable(struct i915_vma *vma);
> int __must_check i915_vma_unbind(struct i915_vma *vma);
> void i915_vma_close(struct i915_vma *vma);
> -void i915_vma_destroy(struct i915_vma *vma);
>
> int __i915_vma_do_pin(struct i915_vma *vma,
> u64 size, u64 alignment, u64 flags);
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Make i915_vma_destroy() static
2017-06-16 13:00 ` [PATCH] " Tvrtko Ursulin
@ 2017-06-16 13:33 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-06-16 13:33 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Quoting Tvrtko Ursulin (2017-06-16 14:00:15)
>
> On 16/06/2017 13:35, Chris Wilson wrote:
> > i915_vma_destroy() is now not used outside of i915_vma.c so we can
> > remove the export and make the function static.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_vma.c | 2 +-
> > drivers/gpu/drm/i915/i915_vma.h | 1 -
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> > index aa4f98e33951..74e48e3459b3 100644
> > --- a/drivers/gpu/drm/i915/i915_vma.c
> > +++ b/drivers/gpu/drm/i915/i915_vma.c
> > @@ -602,7 +602,7 @@ int __i915_vma_do_pin(struct i915_vma *vma,
> > return ret;
> > }
> >
> > -void i915_vma_destroy(struct i915_vma *vma)
> > +static void i915_vma_destroy(struct i915_vma *vma)
> > {
> > GEM_BUG_ON(vma->node.allocated);
> > GEM_BUG_ON(i915_vma_is_active(vma));
> > diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
> > index 36014894400a..d9e52f76cd07 100644
> > --- a/drivers/gpu/drm/i915/i915_vma.h
> > +++ b/drivers/gpu/drm/i915/i915_vma.h
> > @@ -236,7 +236,6 @@ bool i915_vma_misplaced(const struct i915_vma *vma,
> > void __i915_vma_set_map_and_fenceable(struct i915_vma *vma);
> > int __must_check i915_vma_unbind(struct i915_vma *vma);
> > void i915_vma_close(struct i915_vma *vma);
> > -void i915_vma_destroy(struct i915_vma *vma);
> >
> > int __i915_vma_do_pin(struct i915_vma *vma,
> > u64 size, u64 alignment, u64 flags);
> >
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
I vote this for today's most trivial patch.
Thanks, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-16 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-16 12:35 [PATCH] drm/i915: Make i915_vma_destroy() static Chris Wilson
2017-06-16 12:58 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-06-16 13:00 ` [PATCH] " Tvrtko Ursulin
2017-06-16 13:33 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox