* [PATCH 0/2] Consider joiner calculation for panel fitting
@ 2024-07-26 9:53 Nemesa Garg
2024-07-26 9:53 ` [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions Nemesa Garg
` (4 more replies)
0 siblings, 5 replies; 17+ messages in thread
From: Nemesa Garg @ 2024-07-26 9:53 UTC (permalink / raw)
To: intel-gfx; +Cc: Nemesa Garg
Refactor pch_panel_fitting function to use local variables for
crtc_hdisplay and crtc_vdisplay. There is an issue when pch_pfit
and joiner gets enabled together. Moves the panel_fitting to later
stage after pipe_src width is adjusted for bigjoiner.
Nemesa Garg (2):
drm/i915/display: Refactor pch_panel_fitting to use local variables
for crtc dimensions
drm/i915/display: Call panel_fitting from pipe_config
drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 7 +---
drivers/gpu/drm/i915/display/intel_panel.c | 37 +++++++++++--------
4 files changed, 35 insertions(+), 21 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
@ 2024-07-26 9:53 ` Nemesa Garg
2024-07-29 14:43 ` Nautiyal, Ankit K
2024-07-26 9:53 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
` (3 subsequent siblings)
4 siblings, 1 reply; 17+ messages in thread
From: Nemesa Garg @ 2024-07-26 9:53 UTC (permalink / raw)
To: intel-gfx; +Cc: Nemesa Garg
Refactor pch_panel_fitting to use local variables for crtc_hdisplay
and crtc_vdisplay. This will help to adjust the hdisplay at one place
when big/ultra joiner is involved. Introduce local variables crtc_hdisplay
and crtc_vdisplay and update all references to adjusted_mode->crtc_hdisplay
and adjusted_mode->crtc_vdisplay to use the new local variables.
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_panel.c | 34 ++++++++++++----------
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 71454ddef20f..dd18136d1c61 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -392,10 +392,12 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
int pipe_src_w = drm_rect_width(&crtc_state->pipe_src);
int pipe_src_h = drm_rect_height(&crtc_state->pipe_src);
int x, y, width, height;
+ u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
+ u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
/* Native modes don't need fitting */
- if (adjusted_mode->crtc_hdisplay == pipe_src_w &&
- adjusted_mode->crtc_vdisplay == pipe_src_h &&
+ if (crtc_hdisplay == pipe_src_w &&
+ crtc_vdisplay == pipe_src_h &&
crtc_state->output_format != INTEL_OUTPUT_FORMAT_YCBCR420)
return 0;
@@ -403,45 +405,45 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
case DRM_MODE_SCALE_CENTER:
width = pipe_src_w;
height = pipe_src_h;
- x = (adjusted_mode->crtc_hdisplay - width + 1)/2;
- y = (adjusted_mode->crtc_vdisplay - height + 1)/2;
+ x = (crtc_hdisplay - width + 1) / 2;
+ y = (crtc_vdisplay - height + 1) / 2;
break;
case DRM_MODE_SCALE_ASPECT:
/* Scale but preserve the aspect ratio */
{
- u32 scaled_width = adjusted_mode->crtc_hdisplay * pipe_src_h;
- u32 scaled_height = pipe_src_w * adjusted_mode->crtc_vdisplay;
+ u32 scaled_width = crtc_hdisplay * pipe_src_h;
+ u32 scaled_height = pipe_src_w * crtc_vdisplay;
if (scaled_width > scaled_height) { /* pillar */
width = scaled_height / pipe_src_h;
if (width & 1)
width++;
- x = (adjusted_mode->crtc_hdisplay - width + 1) / 2;
+ x = (crtc_hdisplay - width + 1) / 2;
y = 0;
- height = adjusted_mode->crtc_vdisplay;
+ height = crtc_vdisplay;
} else if (scaled_width < scaled_height) { /* letter */
height = scaled_width / pipe_src_w;
if (height & 1)
height++;
- y = (adjusted_mode->crtc_vdisplay - height + 1) / 2;
+ y = (crtc_vdisplay - height + 1) / 2;
x = 0;
- width = adjusted_mode->crtc_hdisplay;
+ width = crtc_hdisplay;
} else {
x = y = 0;
- width = adjusted_mode->crtc_hdisplay;
- height = adjusted_mode->crtc_vdisplay;
+ width = crtc_hdisplay;
+ height = crtc_vdisplay;
}
}
break;
case DRM_MODE_SCALE_NONE:
- WARN_ON(adjusted_mode->crtc_hdisplay != pipe_src_w);
- WARN_ON(adjusted_mode->crtc_vdisplay != pipe_src_h);
+ WARN_ON(crtc_hdisplay != pipe_src_w);
+ WARN_ON(crtc_vdisplay != pipe_src_h);
fallthrough;
case DRM_MODE_SCALE_FULLSCREEN:
x = y = 0;
- width = adjusted_mode->crtc_hdisplay;
- height = adjusted_mode->crtc_vdisplay;
+ width = crtc_hdisplay;
+ height = crtc_vdisplay;
break;
default:
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
2024-07-26 9:53 ` [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions Nemesa Garg
@ 2024-07-26 9:53 ` Nemesa Garg
2024-07-29 15:06 ` Nautiyal, Ankit K
2024-07-30 7:56 ` Jani Nikula
2024-07-26 10:54 ` ✗ Fi.CI.BAT: failure for Consider joiner calculation for panel fitting Patchwork
` (2 subsequent siblings)
4 siblings, 2 replies; 17+ messages in thread
From: Nemesa Garg @ 2024-07-26 9:53 UTC (permalink / raw)
To: intel-gfx; +Cc: Nemesa Garg
In panel fitter/pipe scaler scenario the pch_pfit configuration
currently takes place before accounting for pipe_src width for
joiner. This causes issue when pch_pfit and joiner gets
enabled together.
Introduce a new boolean flag is_required which can be filled
during dp compute_config and later is used to compute panel_fitting in
pipe_config. Modify pch_panel_fitting to handle joiner pipes by adjusting
crtc_hdisplay accordingly.
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
4 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 8bbde03f2508..a7194a84b6b8 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
return ret;
}
+ for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
+ if (connector_state->crtc != &crtc->base)
+ continue;
+
+ if (crtc_state->pch_pfit.is_required) {
+ ret = intel_panel_fitting(crtc_state, connector_state);
+ if (ret)
+ return ret;
+ }
+ }
+
/* Dithering seems to not pass-through bits correctly when it should, so
* only enable it on 6bpc panels and when its not a compliance
* test requesting 6bpc video pattern.
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index a04d52dbf6e1..a4ab26d8fa43 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1258,6 +1258,7 @@ struct intel_crtc_state {
struct drm_rect dst;
bool enabled;
bool force_thru;
+ bool is_required;
} pch_pfit;
/* FDI configuration, only valid if has_pch_encoder is set. */
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d0d878da71ee..d892c5a429f1 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2922,11 +2922,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
pipe_config->has_pch_encoder = true;
fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
- if (intel_dp_is_edp(intel_dp) && fixed_mode) {
- ret = intel_panel_compute_config(connector, adjusted_mode);
- if (ret)
- return ret;
- }
+ if (intel_dp_is_edp(intel_dp) && fixed_mode)
+ pipe_config->pch_pfit.is_required = true;
if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
return -EINVAL;
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index dd18136d1c61..0da45c2330d3 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
+ if (crtc_state->joiner_pipes)
+ crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
+
/* Native modes don't need fitting */
if (crtc_hdisplay == pipe_src_w &&
crtc_vdisplay == pipe_src_h &&
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* ✗ Fi.CI.BAT: failure for Consider joiner calculation for panel fitting
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
2024-07-26 9:53 ` [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions Nemesa Garg
2024-07-26 9:53 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
@ 2024-07-26 10:54 ` Patchwork
2024-07-29 8:27 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-29 15:28 ` ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2024-07-26 10:54 UTC (permalink / raw)
To: Nemesa Garg; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4471 bytes --]
== Series Details ==
Series: Consider joiner calculation for panel fitting
URL : https://patchwork.freedesktop.org/series/136561/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15136 -> Patchwork_136561v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_136561v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_136561v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/index.html
Participating hosts (41 -> 40)
------------------------------
Additional (2): bat-arlh-3 fi-bsw-n3050
Missing (3): bat-dg2-11 fi-snb-2520m fi-kbl-8809g
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_136561v1:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {bat-arlh-3}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/bat-arlh-3/boot.html
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- bat-twl-2: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/bat-twl-2/igt@i915_selftest@live@hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/bat-twl-2/igt@i915_selftest@live@hangcheck.html
Known issues
------------
Here are the changes found in Patchwork_136561v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][4] +19 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- fi-kbl-7567u: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@core_auth@basic-auth.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@core_auth@basic-auth.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7567u: [DMESG-WARN][7] ([i915#10062] / [i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-7567u: [DMESG-WARN][9] ([i915#11621]) -> [PASS][10] +31 other tests pass
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][11] ([i915#10062]) -> [PASS][12] +37 other tests pass
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10062]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10062
[i915#11621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11621
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
Build changes
-------------
* Linux: CI_DRM_15136 -> Patchwork_136561v1
CI-20190529: 20190529
CI_DRM_15136: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7938: 0471a1097444389a901d78b260c24eaf4fc2d7df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_136561v1: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/index.html
[-- Attachment #2: Type: text/html, Size: 5417 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for Consider joiner calculation for panel fitting
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
` (2 preceding siblings ...)
2024-07-26 10:54 ` ✗ Fi.CI.BAT: failure for Consider joiner calculation for panel fitting Patchwork
@ 2024-07-29 8:27 ` Patchwork
2024-07-29 15:28 ` ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2024-07-29 8:27 UTC (permalink / raw)
To: Nemesa Garg; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4162 bytes --]
== Series Details ==
Series: Consider joiner calculation for panel fitting
URL : https://patchwork.freedesktop.org/series/136561/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15136 -> Patchwork_136561v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/index.html
Participating hosts (41 -> 40)
------------------------------
Additional (2): bat-arlh-3 fi-bsw-n3050
Missing (3): bat-dg2-11 fi-snb-2520m fi-kbl-8809g
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_136561v1:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {bat-arlh-3}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/bat-arlh-3/boot.html
Known issues
------------
Here are the changes found in Patchwork_136561v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][2] +19 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html
* igt@i915_selftest@live@hangcheck:
- bat-twl-2: [PASS][3] -> [INCOMPLETE][4] ([i915#11780])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/bat-twl-2/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/bat-twl-2/igt@i915_selftest@live@hangcheck.html
#### Possible fixes ####
* igt@core_auth@basic-auth:
- fi-kbl-7567u: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@core_auth@basic-auth.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@core_auth@basic-auth.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7567u: [DMESG-WARN][7] ([i915#10062] / [i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-7567u: [DMESG-WARN][9] ([i915#11621]) -> [PASS][10] +31 other tests pass
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-kbl-7567u: [DMESG-WARN][11] ([i915#10062]) -> [PASS][12] +37 other tests pass
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10062]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10062
[i915#11621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11621
[i915#11780]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11780
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
Build changes
-------------
* Linux: CI_DRM_15136 -> Patchwork_136561v1
CI-20190529: 20190529
CI_DRM_15136: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7938: 0471a1097444389a901d78b260c24eaf4fc2d7df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_136561v1: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/index.html
[-- Attachment #2: Type: text/html, Size: 5097 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions
2024-07-26 9:53 ` [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions Nemesa Garg
@ 2024-07-29 14:43 ` Nautiyal, Ankit K
0 siblings, 0 replies; 17+ messages in thread
From: Nautiyal, Ankit K @ 2024-07-29 14:43 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx
On 7/26/2024 3:23 PM, Nemesa Garg wrote:
> Refactor pch_panel_fitting to use local variables for crtc_hdisplay
> and crtc_vdisplay. This will help to adjust the hdisplay at one place
> when big/ultra joiner is involved. Introduce local variables crtc_hdisplay
> and crtc_vdisplay and update all references to adjusted_mode->crtc_hdisplay
> and adjusted_mode->crtc_vdisplay to use the new local variables.
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 34 ++++++++++++----------
> 1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index 71454ddef20f..dd18136d1c61 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -392,10 +392,12 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> int pipe_src_w = drm_rect_width(&crtc_state->pipe_src);
> int pipe_src_h = drm_rect_height(&crtc_state->pipe_src);
> int x, y, width, height;
> + u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> + u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> /* Native modes don't need fitting */
> - if (adjusted_mode->crtc_hdisplay == pipe_src_w &&
> - adjusted_mode->crtc_vdisplay == pipe_src_h &&
> + if (crtc_hdisplay == pipe_src_w &&
> + crtc_vdisplay == pipe_src_h &&
> crtc_state->output_format != INTEL_OUTPUT_FORMAT_YCBCR420)
> return 0;
>
> @@ -403,45 +405,45 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> case DRM_MODE_SCALE_CENTER:
> width = pipe_src_w;
> height = pipe_src_h;
> - x = (adjusted_mode->crtc_hdisplay - width + 1)/2;
> - y = (adjusted_mode->crtc_vdisplay - height + 1)/2;
> + x = (crtc_hdisplay - width + 1) / 2;
> + y = (crtc_vdisplay - height + 1) / 2;
> break;
>
> case DRM_MODE_SCALE_ASPECT:
> /* Scale but preserve the aspect ratio */
> {
> - u32 scaled_width = adjusted_mode->crtc_hdisplay * pipe_src_h;
> - u32 scaled_height = pipe_src_w * adjusted_mode->crtc_vdisplay;
> + u32 scaled_width = crtc_hdisplay * pipe_src_h;
> + u32 scaled_height = pipe_src_w * crtc_vdisplay;
> if (scaled_width > scaled_height) { /* pillar */
> width = scaled_height / pipe_src_h;
> if (width & 1)
> width++;
> - x = (adjusted_mode->crtc_hdisplay - width + 1) / 2;
> + x = (crtc_hdisplay - width + 1) / 2;
> y = 0;
> - height = adjusted_mode->crtc_vdisplay;
> + height = crtc_vdisplay;
> } else if (scaled_width < scaled_height) { /* letter */
> height = scaled_width / pipe_src_w;
> if (height & 1)
> height++;
> - y = (adjusted_mode->crtc_vdisplay - height + 1) / 2;
> + y = (crtc_vdisplay - height + 1) / 2;
> x = 0;
> - width = adjusted_mode->crtc_hdisplay;
> + width = crtc_hdisplay;
> } else {
> x = y = 0;
> - width = adjusted_mode->crtc_hdisplay;
> - height = adjusted_mode->crtc_vdisplay;
> + width = crtc_hdisplay;
> + height = crtc_vdisplay;
> }
> }
> break;
>
> case DRM_MODE_SCALE_NONE:
> - WARN_ON(adjusted_mode->crtc_hdisplay != pipe_src_w);
> - WARN_ON(adjusted_mode->crtc_vdisplay != pipe_src_h);
> + WARN_ON(crtc_hdisplay != pipe_src_w);
> + WARN_ON(crtc_vdisplay != pipe_src_h);
> fallthrough;
> case DRM_MODE_SCALE_FULLSCREEN:
> x = y = 0;
> - width = adjusted_mode->crtc_hdisplay;
> - height = adjusted_mode->crtc_vdisplay;
> + width = crtc_hdisplay;
> + height = crtc_vdisplay;
> break;
>
> default:
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-07-26 9:53 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
@ 2024-07-29 15:06 ` Nautiyal, Ankit K
2024-07-30 7:56 ` Jani Nikula
1 sibling, 0 replies; 17+ messages in thread
From: Nautiyal, Ankit K @ 2024-07-29 15:06 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx
On 7/26/2024 3:23 PM, Nemesa Garg wrote:
> In panel fitter/pipe scaler scenario the pch_pfit configuration
> currently takes place before accounting for pipe_src width for
> joiner. This causes issue when pch_pfit and joiner gets
typo: get
> enabled together.
>
> Introduce a new boolean flag is_required which can be filled
> during dp compute_config and later is used to compute panel_fitting in
> pipe_config. Modify pch_panel_fitting to handle joiner pipes by adjusting
> crtc_hdisplay accordingly.
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
Lets add version history from previous revision :
https://patchwork.freedesktop.org/patch/602385/?series=135791&rev=1
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
> drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> 4 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 8bbde03f2508..a7194a84b6b8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
> return ret;
> }
>
> + for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
> + if (connector_state->crtc != &crtc->base)
> + continue;
> +
> + if (crtc_state->pch_pfit.is_required) {
> + ret = intel_panel_fitting(crtc_state, connector_state);
> + if (ret)
> + return ret;
> + }
> + }
> +
> /* Dithering seems to not pass-through bits correctly when it should, so
> * only enable it on 6bpc panels and when its not a compliance
> * test requesting 6bpc video pattern.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a04d52dbf6e1..a4ab26d8fa43 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> struct drm_rect dst;
> bool enabled;
> bool force_thru;
> + bool is_required;
> } pch_pfit;
>
> /* FDI configuration, only valid if has_pch_encoder is set. */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index d0d878da71ee..d892c5a429f1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2922,11 +2922,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> pipe_config->has_pch_encoder = true;
>
> fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
> - if (intel_dp_is_edp(intel_dp) && fixed_mode) {
> - ret = intel_panel_compute_config(connector, adjusted_mode);
> - if (ret)
> - return ret;
> - }
> + if (intel_dp_is_edp(intel_dp) && fixed_mode)
> + pipe_config->pch_pfit.is_required = true;
Although joiner is currently used only for eDP/DP, if we are changing it
for DP, we need to do this for other interfaces also, where
intel_panel_compute_config is called.
Regards,
Ankit
>
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return -EINVAL;
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index dd18136d1c61..0da45c2330d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> + if (crtc_state->joiner_pipes)
> + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> +
> /* Native modes don't need fitting */
> if (crtc_hdisplay == pipe_src_w &&
> crtc_vdisplay == pipe_src_h &&
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✗ Fi.CI.IGT: failure for Consider joiner calculation for panel fitting
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
` (3 preceding siblings ...)
2024-07-29 8:27 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2024-07-29 15:28 ` Patchwork
4 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2024-07-29 15:28 UTC (permalink / raw)
To: Nemesa Garg; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 76290 bytes --]
== Series Details ==
Series: Consider joiner calculation for panel fitting
URL : https://patchwork.freedesktop.org/series/136561/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15136_full -> Patchwork_136561v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_136561v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_136561v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-snb-0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_136561v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1:
- shard-snb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb4/igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb5/igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1.html
* igt@kms_panel_fitting@atomic-fastset@pipe-b-edp-1:
- shard-mtlp: [PASS][3] -> [FAIL][4] +3 other tests fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-6/igt@kms_panel_fitting@atomic-fastset@pipe-b-edp-1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-6/igt@kms_panel_fitting@atomic-fastset@pipe-b-edp-1.html
Known issues
------------
Here are the changes found in Patchwork_136561v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@blit-reloc-keep-cache:
- shard-rkl: NOTRUN -> [SKIP][5] ([i915#8411])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@api_intel_bb@blit-reloc-keep-cache.html
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][6] ([i915#8411]) +1 other test skip
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@api_intel_bb@object-reloc-purge-cache.html
* igt@drm_fdinfo@busy-idle-check-all@vcs1:
- shard-dg1: NOTRUN -> [SKIP][7] ([i915#8414]) +9 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@drm_fdinfo@busy-idle-check-all@vcs1.html
* igt@drm_fdinfo@virtual-busy-hang:
- shard-dg2: NOTRUN -> [SKIP][8] ([i915#8414]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@drm_fdinfo@virtual-busy-hang.html
* igt@gem_ccs@block-copy-compressed:
- shard-rkl: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#9323])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_ccs@block-copy-compressed.html
* igt@gem_ccs@suspend-resume:
- shard-rkl: NOTRUN -> [SKIP][10] ([i915#9323])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@gem_ccs@suspend-resume.html
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-rkl: NOTRUN -> [SKIP][11] ([i915#6335])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_create@create-ext-cpu-access-sanity-check.html
* igt@gem_ctx_persistence@hang:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#8555]) +1 other test skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gem_ctx_persistence@hang.html
* igt@gem_ctx_persistence@heartbeat-hostile:
- shard-dg1: NOTRUN -> [SKIP][13] ([i915#8555])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_ctx_persistence@heartbeat-hostile.html
* igt@gem_ctx_persistence@process:
- shard-snb: NOTRUN -> [SKIP][14] ([i915#1099])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb7/igt@gem_ctx_persistence@process.html
* igt@gem_ctx_sseu@engines:
- shard-rkl: NOTRUN -> [SKIP][15] ([i915#280]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_ctx_sseu@engines.html
* igt@gem_ctx_sseu@invalid-args:
- shard-dg2: NOTRUN -> [SKIP][16] ([i915#280]) +1 other test skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_ctx_sseu@invalid-args.html
* igt@gem_ctx_sseu@mmap-args:
- shard-dg1: NOTRUN -> [SKIP][17] ([i915#280])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_eio@reset-stress:
- shard-dg1: NOTRUN -> [FAIL][18] ([i915#5784])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@bonded-dual:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#4771]) +1 other test skip
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_exec_balancer@bonded-dual.html
* igt@gem_exec_capture@capture-invisible@lmem0:
- shard-dg1: NOTRUN -> [SKIP][20] ([i915#6334]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_exec_capture@capture-invisible@lmem0.html
* igt@gem_exec_capture@capture@vecs0-lmem0:
- shard-dg2: NOTRUN -> [FAIL][21] ([i915#10386]) +3 other tests fail
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_exec_capture@capture@vecs0-lmem0.html
* igt@gem_exec_fair@basic-none-share:
- shard-dg1: NOTRUN -> [SKIP][22] ([i915#3539] / [i915#4852]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_exec_fair@basic-none-share.html
* igt@gem_exec_fair@basic-pace-share:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#3539] / [i915#4852]) +6 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gem_exec_fair@basic-pace-share.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][24] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_flush@basic-uc-prw-default:
- shard-dg1: NOTRUN -> [SKIP][25] ([i915#3539]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_exec_flush@basic-uc-prw-default.html
* igt@gem_exec_reloc@basic-wc-read:
- shard-dg1: NOTRUN -> [SKIP][26] ([i915#3281]) +8 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_exec_reloc@basic-wc-read.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- shard-rkl: NOTRUN -> [SKIP][27] ([i915#3281]) +9 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_exec_reloc@basic-write-read-active:
- shard-dg2: NOTRUN -> [SKIP][28] ([i915#3281]) +13 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gem_exec_schedule@preempt-queue-contexts:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#4537] / [i915#4812])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_exec_schedule@preempt-queue-contexts.html
* igt@gem_exec_schedule@reorder-wide:
- shard-dg1: NOTRUN -> [SKIP][30] ([i915#4812])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_exec_schedule@reorder-wide.html
* igt@gem_fence_thrash@bo-write-verify-y:
- shard-dg2: NOTRUN -> [SKIP][31] ([i915#4860]) +2 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gem_fence_thrash@bo-write-verify-y.html
* igt@gem_fenced_exec_thrash@2-spare-fences:
- shard-dg1: NOTRUN -> [SKIP][32] ([i915#4860])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_fenced_exec_thrash@2-spare-fences.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs@lmem0:
- shard-dg2: [PASS][33] -> [FAIL][34] ([i915#10378])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-1/igt@gem_lmem_swapping@heavy-verify-multi-ccs@lmem0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gem_lmem_swapping@heavy-verify-multi-ccs@lmem0.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-rkl: NOTRUN -> [SKIP][35] ([i915#4613]) +2 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@smem-oom:
- shard-glk: NOTRUN -> [SKIP][36] ([i915#4613]) +5 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk7/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_lmem_swapping@verify-ccs@lmem0:
- shard-dg2: NOTRUN -> [FAIL][37] ([i915#10378]) +1 other test fail
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@gem_lmem_swapping@verify-ccs@lmem0.html
* igt@gem_media_vme:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#284])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_media_vme.html
* igt@gem_mmap@pf-nonblock:
- shard-dg2: NOTRUN -> [SKIP][39] ([i915#4083]) +5 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@gem_mmap@pf-nonblock.html
* igt@gem_mmap_gtt@basic-small-bo:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#4077]) +18 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_mmap_gtt@basic-small-bo.html
* igt@gem_mmap_gtt@coherency:
- shard-dg1: NOTRUN -> [SKIP][41] ([i915#4077]) +11 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@gem_mmap_gtt@coherency.html
* igt@gem_mmap_wc@copy:
- shard-dg1: NOTRUN -> [SKIP][42] ([i915#4083]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_mmap_wc@copy.html
* igt@gem_pread@self:
- shard-dg1: NOTRUN -> [SKIP][43] ([i915#3282])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_pread@self.html
* igt@gem_pread@snoop:
- shard-dg2: NOTRUN -> [SKIP][44] ([i915#3282]) +4 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_pread@snoop.html
* igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> [WARN][45] ([i915#2658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk1/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-on:
- shard-rkl: NOTRUN -> [SKIP][46] ([i915#4270]) +6 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gem_pxp@reject-modify-context-protection-on.html
* igt@gem_pxp@verify-pxp-execution-after-suspend-resume:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#4270]) +7 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@gem_pxp@verify-pxp-execution-after-suspend-resume.html
* igt@gem_pxp@verify-pxp-stale-ctx-execution:
- shard-dg1: NOTRUN -> [SKIP][48] ([i915#4270]) +2 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_pxp@verify-pxp-stale-ctx-execution.html
* igt@gem_render_copy@y-tiled-to-vebox-yf-tiled:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#5190] / [i915#8428]) +6 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gem_render_copy@y-tiled-to-vebox-yf-tiled.html
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#4079]) +1 other test skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
* igt@gem_set_tiling_vs_pwrite:
- shard-rkl: NOTRUN -> [SKIP][51] ([i915#3282]) +1 other test skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@gem_set_tiling_vs_pwrite.html
- shard-dg1: NOTRUN -> [SKIP][52] ([i915#4079]) +2 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@gem_set_tiling_vs_pwrite.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#4885])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_userptr_blits@coherency-sync:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#3297]) +1 other test skip
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-dg1: NOTRUN -> [SKIP][55] ([i915#3297]) +2 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#3297] / [i915#4880])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@gem_userptr_blits@map-fixed-invalidate.html
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#3297]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@gem_userptr_blits@readonly-pwrite-unsync.html
* igt@gen9_exec_parse@secure-batches:
- shard-dg2: NOTRUN -> [SKIP][58] ([i915#2856]) +4 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@gen9_exec_parse@secure-batches.html
- shard-rkl: NOTRUN -> [SKIP][59] ([i915#2527]) +2 other tests skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@gen9_exec_parse@secure-batches.html
* igt@gen9_exec_parse@shadow-peek:
- shard-dg1: NOTRUN -> [SKIP][60] ([i915#2527]) +2 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_fb_tiling:
- shard-dg1: NOTRUN -> [SKIP][61] ([i915#4881])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@i915_fb_tiling.html
* igt@i915_module_load@load:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#6227])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@i915_module_load@load.html
- shard-rkl: NOTRUN -> [SKIP][63] ([i915#6227])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@i915_module_load@load.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [PASS][64] -> [ABORT][65] ([i915#9820])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-tglu-10/igt@i915_module_load@reload-with-fault-injection.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-5/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_freq_api@freq-reset-multiple:
- shard-tglu: NOTRUN -> [SKIP][66] ([i915#8399])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@i915_pm_freq_api@freq-reset-multiple.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0:
- shard-dg1: [PASS][67] -> [FAIL][68] ([i915#3591])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html
* igt@i915_pm_rps@min-max-config-idle:
- shard-dg1: NOTRUN -> [SKIP][69] ([i915#6621])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@i915_pm_rps@min-max-config-idle.html
* igt@i915_pm_rps@min-max-config-loaded:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#6621])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@i915_pm_rps@min-max-config-loaded.html
* igt@i915_pm_rps@thresholds-idle@gt0:
- shard-dg2: NOTRUN -> [SKIP][71] ([i915#8925])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@i915_pm_rps@thresholds-idle@gt0.html
* igt@i915_pm_sseu@full-enable:
- shard-dg1: NOTRUN -> [SKIP][72] ([i915#4387])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@i915_pm_sseu@full-enable.html
* igt@i915_query@hwconfig_table:
- shard-dg1: NOTRUN -> [SKIP][73] ([i915#6245])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@i915_query@hwconfig_table.html
- shard-rkl: NOTRUN -> [SKIP][74] ([i915#6245])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@i915_query@hwconfig_table.html
* igt@i915_query@query-topology-coherent-slice-mask:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#6188])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@i915_query@query-topology-coherent-slice-mask.html
* igt@i915_selftest@mock@memory_region:
- shard-glk: NOTRUN -> [DMESG-WARN][76] ([i915#9311])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk3/igt@i915_selftest@mock@memory_region.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [PASS][77] -> [FAIL][78] ([i915#10031] / [i915#11279])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-rkl-2/igt@i915_suspend@basic-s3-without-i915.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-6/igt@i915_suspend@basic-s3-without-i915.html
* igt@intel_hwmon@hwmon-read:
- shard-rkl: NOTRUN -> [SKIP][79] ([i915#7707])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@intel_hwmon@hwmon-read.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-dg2: NOTRUN -> [SKIP][80] ([i915#5190])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs:
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#8709]) +7 other tests skip
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-13/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-3-y-rc-ccs.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-mc-ccs:
- shard-dg2: NOTRUN -> [SKIP][82] ([i915#8709]) +11 other tests skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-4-mc-ccs.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-dg1: NOTRUN -> [SKIP][83] ([i915#9531])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-rkl: NOTRUN -> [SKIP][84] ([i915#1769] / [i915#3555])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
- shard-glk: NOTRUN -> [SKIP][85] ([i915#1769])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk1/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1:
- shard-snb: [PASS][86] -> [FAIL][87] ([i915#5956])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb5/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb7/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#5286]) +5 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_big_fb@4-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- shard-tglu: NOTRUN -> [SKIP][89] ([i915#5286])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_big_fb@4-tiled-8bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-dg1: NOTRUN -> [SKIP][90] ([i915#4538] / [i915#5286]) +3 other tests skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][91] ([i915#3638]) +3 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_big_fb@linear-8bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-rkl: NOTRUN -> [SKIP][92] ([i915#3638]) +3 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-dg2: NOTRUN -> [SKIP][93] ([i915#4538] / [i915#5190]) +15 other tests skip
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#4538]) +3 other tests skip
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_joiner@basic-force-joiner:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#10656])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_big_joiner@basic-force-joiner.html
* igt@kms_big_joiner@invalid-modeset:
- shard-rkl: NOTRUN -> [SKIP][96] ([i915#10656])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@bad-aux-stride-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][97] ([i915#6095]) +67 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_ccs@bad-aux-stride-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-4.html
* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][98] ([i915#10307] / [i915#10434] / [i915#6095]) +7 other tests skip
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc@pipe-d-hdmi-a-1.html
* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][99] ([i915#6095]) +61 other tests skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_ccs@bad-rotation-90-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-2.html
* igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][100] ([i915#10307] / [i915#6095]) +159 other tests skip
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-c-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][101] ([i915#6095]) +7 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-c-hdmi-a-1.html
* igt@kms_ccs@random-ccs-data-y-tiled-gen12-rc-ccs@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][102] +392 other tests skip
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk7/igt@kms_ccs@random-ccs-data-y-tiled-gen12-rc-ccs@pipe-a-hdmi-a-1.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-dg2: NOTRUN -> [SKIP][103] ([i915#11616] / [i915#7213])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][104] ([i915#7213]) +3 other tests skip
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-1/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3.html
* igt@kms_cdclk@plane-scaling:
- shard-dg1: NOTRUN -> [SKIP][105] ([i915#3742])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_cdclk@plane-scaling.html
* igt@kms_chamelium_frames@dp-crc-fast:
- shard-dg2: NOTRUN -> [SKIP][106] ([i915#7828]) +10 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-dg1: NOTRUN -> [SKIP][107] ([i915#7828]) +5 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium_hpd@hdmi-hpd-fast:
- shard-rkl: NOTRUN -> [SKIP][108] ([i915#7828]) +9 other tests skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_chamelium_hpd@hdmi-hpd-fast.html
* igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode:
- shard-tglu: NOTRUN -> [SKIP][109] ([i915#7828])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode.html
* igt@kms_content_protection@atomic-dpms:
- shard-rkl: NOTRUN -> [SKIP][110] ([i915#7118] / [i915#9424])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg2: NOTRUN -> [SKIP][111] ([i915#3299])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_content_protection@dp-mst-lic-type-0.html
* igt@kms_content_protection@lic-type-1:
- shard-rkl: NOTRUN -> [SKIP][112] ([i915#9424])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_content_protection@lic-type-1.html
- shard-dg1: NOTRUN -> [SKIP][113] ([i915#9424])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_content_protection@lic-type-1.html
* igt@kms_content_protection@mei-interface:
- shard-dg1: NOTRUN -> [SKIP][114] ([i915#9433])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_content_protection@mei-interface.html
* igt@kms_content_protection@srm:
- shard-dg2: NOTRUN -> [SKIP][115] ([i915#7118])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_content_protection@srm.html
* igt@kms_content_protection@type1:
- shard-dg2: NOTRUN -> [SKIP][116] ([i915#7118] / [i915#9424]) +3 other tests skip
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_content_protection@type1.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-rkl: NOTRUN -> [SKIP][117] ([i915#11453]) +1 other test skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_crc@cursor-offscreen-max-size:
- shard-dg1: NOTRUN -> [SKIP][118] ([i915#3555]) +6 other tests skip
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_cursor_crc@cursor-offscreen-max-size.html
* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-rkl: NOTRUN -> [SKIP][119] ([i915#3555]) +5 other tests skip
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_cursor_crc@cursor-onscreen-32x32.html
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#11453] / [i915#3359]) +2 other tests skip
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_cursor_crc@cursor-onscreen-512x512.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-dg2: NOTRUN -> [SKIP][121] ([i915#3555]) +4 other tests skip
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_cursor_crc@cursor-rapid-movement-32x32.html
* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-dg2: NOTRUN -> [SKIP][122] ([i915#11453])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_cursor_crc@cursor-sliding-512x170.html
* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-dg1: NOTRUN -> [SKIP][123] ([i915#11453])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_cursor_crc@cursor-sliding-512x512.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-rkl: NOTRUN -> [SKIP][124] +27 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-rkl: NOTRUN -> [SKIP][125] ([i915#4103])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- shard-dg1: NOTRUN -> [SKIP][126] ([i915#4103] / [i915#4213])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-dg1: NOTRUN -> [SKIP][127] ([i915#9723])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html
* igt@kms_dp_aux_dev:
- shard-dg2: NOTRUN -> [SKIP][128] ([i915#1257])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_dp_aux_dev.html
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-dg2: NOTRUN -> [SKIP][129] ([i915#3840])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_dsc@dsc-fractional-bpp-with-bpc.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-dg2: NOTRUN -> [SKIP][130] ([i915#3555] / [i915#3840]) +1 other test skip
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_dsc@dsc-with-bpc-formats.html
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#3555] / [i915#3840])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_dsc@dsc-with-formats:
- shard-dg1: NOTRUN -> [SKIP][132] ([i915#3555] / [i915#3840])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_dsc@dsc-with-formats.html
* igt@kms_dsc@dsc-with-output-formats-with-bpc:
- shard-rkl: NOTRUN -> [SKIP][133] ([i915#3840] / [i915#9053])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_dsc@dsc-with-output-formats-with-bpc.html
- shard-dg1: NOTRUN -> [SKIP][134] ([i915#3840] / [i915#9053])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_dsc@dsc-with-output-formats-with-bpc.html
* igt@kms_fbcon_fbt@psr:
- shard-dg1: NOTRUN -> [SKIP][135] ([i915#3469])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_fbcon_fbt@psr.html
* igt@kms_feature_discovery@psr2:
- shard-dg2: NOTRUN -> [SKIP][136] ([i915#658])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_feature_discovery@psr2.html
* igt@kms_flip@2x-flip-vs-fences:
- shard-dg1: NOTRUN -> [SKIP][137] ([i915#8381]) +1 other test skip
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_flip@2x-flip-vs-fences.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-dg2: NOTRUN -> [SKIP][138] +29 other tests skip
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@2x-plain-flip:
- shard-tglu: NOTRUN -> [SKIP][139] ([i915#3637])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_flip@2x-plain-flip.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-dg1: NOTRUN -> [SKIP][140] ([i915#9934]) +2 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_flip@flip-vs-fences-interruptible:
- shard-dg2: NOTRUN -> [SKIP][141] ([i915#8381]) +1 other test skip
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_flip@flip-vs-fences-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][142] ([i915#2672]) +5 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][143] ([i915#2587] / [i915#2672])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][144] ([i915#2587] / [i915#2672]) +1 other test skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][145] ([i915#2672]) +3 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_force_connector_basic@prune-stale-modes:
- shard-dg2: NOTRUN -> [SKIP][146] ([i915#5274])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-rkl: NOTRUN -> [SKIP][147] ([i915#1825]) +33 other tests skip
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-dg2: NOTRUN -> [SKIP][148] ([i915#5354]) +43 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
- shard-snb: [PASS][149] -> [SKIP][150] +1 other test skip
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-dg1: NOTRUN -> [SKIP][151] ([i915#8708]) +16 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-16/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite:
- shard-dg2: NOTRUN -> [SKIP][152] ([i915#3458]) +25 other tests skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][153] ([i915#8708]) +21 other tests skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][154] +20 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-dg2: NOTRUN -> [SKIP][155] ([i915#10055]) +1 other test skip
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
* igt@kms_frontbuffer_tracking@pipe-fbc-rte:
- shard-dg2: NOTRUN -> [SKIP][156] ([i915#9766])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_frontbuffer_tracking@pipe-fbc-rte.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][157] +9 other tests skip
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][158] +74 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][159] ([i915#3023]) +22 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][160] ([i915#3458]) +12 other tests skip
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html
* igt@kms_getfb@getfb-reject-ccs:
- shard-dg2: NOTRUN -> [SKIP][161] ([i915#6118])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_getfb@getfb-reject-ccs.html
* igt@kms_hdr@bpc-switch:
- shard-tglu: NOTRUN -> [SKIP][162] ([i915#3555] / [i915#8228])
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_hdr@bpc-switch.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-dg1: NOTRUN -> [SKIP][163] ([i915#3555] / [i915#8228])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_hdr@static-swap:
- shard-rkl: NOTRUN -> [SKIP][164] ([i915#3555] / [i915#8228])
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_hdr@static-swap.html
* igt@kms_hdr@static-toggle:
- shard-dg2: NOTRUN -> [SKIP][165] ([i915#3555] / [i915#8228]) +1 other test skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_hdr@static-toggle.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-dg1: NOTRUN -> [SKIP][166] ([i915#1839])
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-dg1: NOTRUN -> [SKIP][167] ([i915#6301])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [FAIL][168] ([i915#7862]) +1 other test fail
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk3/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][169] ([i915#8292])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][170] ([i915#8292])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][171] ([i915#9423]) +20 other tests skip
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][172] ([i915#9423]) +7 other tests skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-6/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][173] ([i915#9423]) +23 other tests skip
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-4.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][174] ([i915#9728]) +1 other test skip
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][175] ([i915#5235] / [i915#9423]) +2 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][176] ([i915#5235]) +1 other test skip
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][177] ([i915#9728]) +7 other tests skip
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-13/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3.html
* igt@kms_pm_backlight@basic-brightness:
- shard-rkl: NOTRUN -> [SKIP][178] ([i915#5354])
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_pm_lpsp@kms-lpsp:
- shard-dg2: NOTRUN -> [SKIP][179] ([i915#9340])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_pm_lpsp@kms-lpsp.html
* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-rkl: NOTRUN -> [SKIP][180] ([i915#9519])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_pm_rpm@dpms-non-lpsp.html
* igt@kms_pm_rpm@modeset-lpsp:
- shard-rkl: [PASS][181] -> [SKIP][182] ([i915#9519])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-rkl-2/igt@kms_pm_rpm@modeset-lpsp.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_pm_rpm@modeset-lpsp.html
- shard-dg1: NOTRUN -> [SKIP][183] ([i915#9519])
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_pm_rpm@modeset-lpsp.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg2: [PASS][184] -> [SKIP][185] ([i915#9519])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-11/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_prime@d3hot:
- shard-rkl: NOTRUN -> [SKIP][186] ([i915#6524])
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@kms_prime@d3hot.html
- shard-dg2: NOTRUN -> [SKIP][187] ([i915#6524] / [i915#6805])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_prime@d3hot.html
* igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-fully-sf:
- shard-dg1: NOTRUN -> [SKIP][188] ([i915#11520]) +2 other tests skip
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@fbc-primary-plane-update-sf-dmg-area:
- shard-rkl: NOTRUN -> [SKIP][189] ([i915#11520]) +2 other tests skip
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_psr2_sf@fbc-primary-plane-update-sf-dmg-area.html
- shard-dg2: NOTRUN -> [SKIP][190] ([i915#11520]) +3 other tests skip
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_psr2_sf@fbc-primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-dg2: NOTRUN -> [SKIP][191] ([i915#9683]) +1 other test skip
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-dg1: NOTRUN -> [SKIP][192] ([i915#9683])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@fbc-psr-primary-blt:
- shard-dg2: NOTRUN -> [SKIP][193] ([i915#1072] / [i915#9673] / [i915#9732]) +9 other tests skip
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@kms_psr@fbc-psr-primary-blt.html
* igt@kms_psr@pr-sprite-plane-onoff:
- shard-dg1: NOTRUN -> [SKIP][194] ([i915#1072] / [i915#9732]) +14 other tests skip
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_psr@pr-sprite-plane-onoff.html
* igt@kms_psr@pr-suspend:
- shard-tglu: NOTRUN -> [SKIP][195] ([i915#9732]) +1 other test skip
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@kms_psr@pr-suspend.html
* igt@kms_psr@psr-sprite-plane-move:
- shard-rkl: NOTRUN -> [SKIP][196] ([i915#1072] / [i915#9732]) +20 other tests skip
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@kms_psr@psr-sprite-plane-move.html
* igt@kms_psr@psr2-primary-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][197] ([i915#1072] / [i915#9732]) +20 other tests skip
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_psr@psr2-primary-mmap-gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-dg1: NOTRUN -> [SKIP][198] ([i915#9685]) +1 other test skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_rotation_crc@primary-rotation-270:
- shard-dg2: NOTRUN -> [SKIP][199] ([i915#11131])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_rotation_crc@primary-rotation-270.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-rkl: NOTRUN -> [SKIP][200] ([i915#5289]) +1 other test skip
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-dg2: NOTRUN -> [SKIP][201] ([i915#11131] / [i915#5190])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
* igt@kms_scaling_modes@scaling-mode-full@pipe-d-edp-1:
- shard-mtlp: [PASS][202] -> [SKIP][203] ([i915#5030]) +11 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-6/igt@kms_scaling_modes@scaling-mode-full@pipe-d-edp-1.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-4/igt@kms_scaling_modes@scaling-mode-full@pipe-d-edp-1.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: NOTRUN -> [FAIL][204] ([IGT#2])
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-3/igt@kms_sysfs_edid_timing.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-edp-1:
- shard-mtlp: [PASS][205] -> [FAIL][206] ([i915#9196])
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-4/igt@kms_universal_plane@cursor-fb-leak@pipe-b-edp-1.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-b-edp-1.html
* igt@kms_vrr@flip-basic-fastset:
- shard-dg2: NOTRUN -> [SKIP][207] ([i915#9906])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_vrr@flip-basic-fastset.html
* igt@kms_vrr@negative-basic:
- shard-dg2: NOTRUN -> [SKIP][208] ([i915#3555] / [i915#9906])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_vrr@negative-basic.html
* igt@kms_vrr@seamless-rr-switch-virtual:
- shard-rkl: NOTRUN -> [SKIP][209] ([i915#9906])
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@kms_vrr@seamless-rr-switch-virtual.html
* igt@kms_writeback@writeback-check-output-xrgb2101010:
- shard-glk: NOTRUN -> [SKIP][210] ([i915#2437]) +1 other test skip
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk1/igt@kms_writeback@writeback-check-output-xrgb2101010.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-dg2: NOTRUN -> [SKIP][211] ([i915#2437] / [i915#9412])
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@global-sseu-config:
- shard-dg2: NOTRUN -> [SKIP][212] ([i915#7387])
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@perf@global-sseu-config.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: NOTRUN -> [FAIL][213] ([i915#9100])
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
* igt@perf@per-context-mode-unprivileged:
- shard-rkl: NOTRUN -> [SKIP][214] ([i915#2435])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@perf@per-context-mode-unprivileged.html
* igt@perf@unprivileged-single-ctx-counters:
- shard-rkl: NOTRUN -> [SKIP][215] ([i915#2433])
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-4/igt@perf@unprivileged-single-ctx-counters.html
* igt@perf_pmu@frequency@gt0:
- shard-dg2: NOTRUN -> [FAIL][216] ([i915#6806])
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@perf_pmu@frequency@gt0.html
* igt@perf_pmu@rc6@other-idle-gt0:
- shard-dg1: NOTRUN -> [SKIP][217] ([i915#8516])
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@perf_pmu@rc6@other-idle-gt0.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: NOTRUN -> [CRASH][218] ([i915#9351])
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
* igt@prime_vgem@basic-fence-mmap:
- shard-dg2: NOTRUN -> [SKIP][219] ([i915#3708] / [i915#4077])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- shard-dg2: NOTRUN -> [SKIP][220] ([i915#3291] / [i915#3708])
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-10/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@fence-read-hang:
- shard-dg2: NOTRUN -> [SKIP][221] ([i915#3708]) +2 other tests skip
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-11/igt@prime_vgem@fence-read-hang.html
- shard-rkl: NOTRUN -> [SKIP][222] ([i915#3708])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-1/igt@prime_vgem@fence-read-hang.html
* igt@sriov_basic@enable-vfs-autoprobe-off:
- shard-dg1: NOTRUN -> [SKIP][223] ([i915#9917]) +1 other test skip
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-17/igt@sriov_basic@enable-vfs-autoprobe-off.html
* igt@sriov_basic@enable-vfs-autoprobe-on:
- shard-rkl: NOTRUN -> [SKIP][224] ([i915#9917])
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-3/igt@sriov_basic@enable-vfs-autoprobe-on.html
* igt@tools_test@sysfs_l3_parity:
- shard-dg2: NOTRUN -> [SKIP][225] ([i915#4818])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][226] ([i915#2842]) -> [PASS][227]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-tglu: [ABORT][228] ([i915#7975] / [i915#8213]) -> [PASS][229]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-7/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_lmem_swapping@heavy-verify-multi@lmem0:
- shard-dg1: [FAIL][230] ([i915#10378]) -> [PASS][231]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg1-17/igt@gem_lmem_swapping@heavy-verify-multi@lmem0.html
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg1-15/igt@gem_lmem_swapping@heavy-verify-multi@lmem0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [ABORT][232] ([i915#9820]) -> [PASS][233]
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb6/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-mtlp: [FAIL][234] ([i915#5138]) -> [PASS][235]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_cursor_legacy@torture-bo@pipe-b:
- shard-glk: [DMESG-WARN][236] ([i915#10166] / [i915#1982]) -> [PASS][237]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-glk3/igt@kms_cursor_legacy@torture-bo@pipe-b.html
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-glk1/igt@kms_cursor_legacy@torture-bo@pipe-b.html
* igt@kms_flip@wf_vblank-ts-check@a-hdmi-a1:
- shard-snb: [FAIL][238] ([i915#2122]) -> [PASS][239] +1 other test pass
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb7/igt@kms_flip@wf_vblank-ts-check@a-hdmi-a1.html
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb5/igt@kms_flip@wf_vblank-ts-check@a-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-dg2: [FAIL][240] ([i915#6880]) -> [PASS][241] +1 other test pass
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_plane_alpha_blend@constant-alpha-mid@pipe-d-edp-1:
- shard-mtlp: [FAIL][242] -> [PASS][243] +1 other test pass
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-4/igt@kms_plane_alpha_blend@constant-alpha-mid@pipe-d-edp-1.html
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-8/igt@kms_plane_alpha_blend@constant-alpha-mid@pipe-d-edp-1.html
* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: [SKIP][244] ([i915#9519]) -> [PASS][245]
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-6/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@kms_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [SKIP][246] ([i915#9519]) -> [PASS][247] +2 other tests pass
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-rkl-2/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-6/igt@kms_pm_rpm@modeset-non-lpsp-stress.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1:
- shard-mtlp: [FAIL][248] ([i915#9196]) -> [PASS][249]
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-mtlp-4/igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1.html
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-mtlp-2/igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1.html
* igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1:
- shard-snb: [FAIL][250] ([i915#9196]) -> [PASS][251]
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-snb6/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-snb4/igt@kms_universal_plane@cursor-fb-leak@pipe-b-hdmi-a-1.html
#### Warnings ####
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][252] ([i915#1982] / [i915#9559]) -> [ABORT][253] ([i915#9820])
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-6/igt@i915_module_load@reload-with-fault-injection.html
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0:
- shard-tglu: [FAIL][254] ([i915#3591]) -> [WARN][255] ([i915#2681])
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-tglu-5/igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0.html
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-tglu-9/igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0.html
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-dg2: [SKIP][256] ([i915#11453] / [i915#3359]) -> [SKIP][257] ([i915#11453])
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-11/igt@kms_cursor_crc@cursor-onscreen-512x170.html
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_cursor_crc@cursor-onscreen-512x170.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
- shard-dg2: [SKIP][258] ([i915#3458]) -> [SKIP][259] ([i915#10433] / [i915#3458]) +1 other test skip
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][260] ([i915#4816]) -> [SKIP][261] ([i915#4070] / [i915#4816])
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_psr@psr-cursor-render:
- shard-dg2: [SKIP][262] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][263] ([i915#1072] / [i915#9732]) +22 other tests skip
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-11/igt@kms_psr@psr-cursor-render.html
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_psr@psr-cursor-render.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-dg2: [SKIP][264] ([i915#11131] / [i915#4235]) -> [SKIP][265] ([i915#11131]) +1 other test skip
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-11/igt@kms_rotation_crc@bad-pixel-format.html
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-6/igt@kms_rotation_crc@bad-pixel-format.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-dg2: [SKIP][266] ([i915#11131] / [i915#4235] / [i915#5190]) -> [SKIP][267] ([i915#11131] / [i915#5190])
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15136/shard-dg2-11/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/shard-dg2-2/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[i915#10031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10031
[i915#10055]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10055
[i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10378]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10378
[i915#10386]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10386
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1099
[i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
[i915#11279]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11279
[i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#11616]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11616
[i915#1257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1257
[i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
[i915#2433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2433
[i915#2435]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
[i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
[i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4387
[i915#4537]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
[i915#4818]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4818
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4885
[i915#5030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5030
[i915#5138]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5138
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
[i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
[i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6118
[i915#6188]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6188
[i915#6227]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6227
[i915#6245]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6245
[i915#6301]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6335
[i915#6524]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
[i915#6805]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6805
[i915#6806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6806
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
[i915#7387]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7387
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
[i915#7862]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7862
[i915#7975]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
[i915#8381]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8381
[i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
[i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#8709]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8709
[i915#8925]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8925
[i915#9053]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9053
[i915#9100]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9100
[i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
[i915#9311]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9311
[i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
[i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
[i915#9351]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9351
[i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
[i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9433
[i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
[i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
[i915#9559]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9559
[i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
[i915#9683]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9683
[i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
[i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
[i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
[i915#9766]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9766
[i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
[i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
[i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
[i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934
Build changes
-------------
* Linux: CI_DRM_15136 -> Patchwork_136561v1
CI-20190529: 20190529
CI_DRM_15136: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7938: 0471a1097444389a901d78b260c24eaf4fc2d7df @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_136561v1: edd84625d093bb52bfb1c0c6feb12cff308d81b7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_136561v1/index.html
[-- Attachment #2: Type: text/html, Size: 93110 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-07-26 9:53 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
2024-07-29 15:06 ` Nautiyal, Ankit K
@ 2024-07-30 7:56 ` Jani Nikula
2024-07-30 16:20 ` Garg, Nemesa
1 sibling, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2024-07-30 7:56 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx; +Cc: Nemesa Garg
On Fri, 26 Jul 2024, Nemesa Garg <nemesa.garg@intel.com> wrote:
> In panel fitter/pipe scaler scenario the pch_pfit configuration
> currently takes place before accounting for pipe_src width for
> joiner. This causes issue when pch_pfit and joiner gets
> enabled together.
>
> Introduce a new boolean flag is_required which can be filled
> during dp compute_config and later is used to compute panel_fitting in
> pipe_config. Modify pch_panel_fitting to handle joiner pipes by adjusting
> crtc_hdisplay accordingly.
Superficially looks simple enough, but this actually adds a bunch of
complexity. It's not obvious why encoders handle panel fitting in
completely different places, or what "pch_pfit.is_required" really
means.
BR,
Jani.
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
> drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> 4 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 8bbde03f2508..a7194a84b6b8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
> return ret;
> }
>
> + for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
> + if (connector_state->crtc != &crtc->base)
> + continue;
> +
> + if (crtc_state->pch_pfit.is_required) {
> + ret = intel_panel_fitting(crtc_state, connector_state);
> + if (ret)
> + return ret;
> + }
> + }
> +
> /* Dithering seems to not pass-through bits correctly when it should, so
> * only enable it on 6bpc panels and when its not a compliance
> * test requesting 6bpc video pattern.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a04d52dbf6e1..a4ab26d8fa43 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> struct drm_rect dst;
> bool enabled;
> bool force_thru;
> + bool is_required;
> } pch_pfit;
>
> /* FDI configuration, only valid if has_pch_encoder is set. */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index d0d878da71ee..d892c5a429f1 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2922,11 +2922,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> pipe_config->has_pch_encoder = true;
>
> fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
> - if (intel_dp_is_edp(intel_dp) && fixed_mode) {
> - ret = intel_panel_compute_config(connector, adjusted_mode);
> - if (ret)
> - return ret;
> - }
> + if (intel_dp_is_edp(intel_dp) && fixed_mode)
> + pipe_config->pch_pfit.is_required = true;
>
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return -EINVAL;
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index dd18136d1c61..0da45c2330d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> + if (crtc_state->joiner_pipes)
> + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> +
> /* Native modes don't need fitting */
> if (crtc_hdisplay == pipe_src_w &&
> crtc_vdisplay == pipe_src_h &&
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-07-30 7:56 ` Jani Nikula
@ 2024-07-30 16:20 ` Garg, Nemesa
0 siblings, 0 replies; 17+ messages in thread
From: Garg, Nemesa @ 2024-07-30 16:20 UTC (permalink / raw)
To: Jani Nikula, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, July 30, 2024 1:27 PM
> To: Garg, Nemesa <nemesa.garg@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Garg, Nemesa <nemesa.garg@intel.com>
> Subject: Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
>
> On Fri, 26 Jul 2024, Nemesa Garg <nemesa.garg@intel.com> wrote:
> > In panel fitter/pipe scaler scenario the pch_pfit configuration
> > currently takes place before accounting for pipe_src width for joiner.
> > This causes issue when pch_pfit and joiner gets enabled together.
> >
> > Introduce a new boolean flag is_required which can be filled during dp
> > compute_config and later is used to compute panel_fitting in
> > pipe_config. Modify pch_panel_fitting to handle joiner pipes by
> > adjusting crtc_hdisplay accordingly.
>
> Superficially looks simple enough, but this actually adds a bunch of complexity.
> It's not obvious why encoders handle panel fitting in completely different places,
> or what "pch_pfit.is_required" really means.
>
> BR,
> Jani.
>
Hi Jani,
In joiner cases we need to do panel fitting calculations after the calculated pipe src width.
So one solution I thought of is as mentioned below:
For each encoder first panel_compute_config is called and then intel_panel_fitting.
So to simplify this I am replacing the intel_panel_fitting with the flag and then calling it at one place in pipe_config.
As done in trybot patch https://patchwork.freedesktop.org/series/136483/.
Other solution can be let the flow for panel_fitting is same for non-joiner case for edp/dp and if joiner
is enabled call panel_fitting again in later stage ie after pipe_config.
Please suggest what can be the better solution.
Thanks and Regards,
Nemesa
> >
> > Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> > drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> > drivers/gpu/drm/i915/display/intel_dp.c | 7 ++-----
> > drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> > 4 files changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 8bbde03f2508..a7194a84b6b8 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct
> intel_atomic_state *state,
> > return ret;
> > }
> >
> > + for_each_new_connector_in_state(&state->base, connector,
> connector_state, i) {
> > + if (connector_state->crtc != &crtc->base)
> > + continue;
> > +
> > + if (crtc_state->pch_pfit.is_required) {
> > + ret = intel_panel_fitting(crtc_state, connector_state);
> > + if (ret)
> > + return ret;
> > + }
> > + }
> > +
> > /* Dithering seems to not pass-through bits correctly when it should, so
> > * only enable it on 6bpc panels and when its not a compliance
> > * test requesting 6bpc video pattern.
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index a04d52dbf6e1..a4ab26d8fa43 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> > struct drm_rect dst;
> > bool enabled;
> > bool force_thru;
> > + bool is_required;
> > } pch_pfit;
> >
> > /* FDI configuration, only valid if has_pch_encoder is set. */ diff
> > --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index d0d878da71ee..d892c5a429f1 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -2922,11 +2922,8 @@ intel_dp_compute_config(struct intel_encoder
> *encoder,
> > pipe_config->has_pch_encoder = true;
> >
> > fixed_mode = intel_panel_fixed_mode(connector, adjusted_mode);
> > - if (intel_dp_is_edp(intel_dp) && fixed_mode) {
> > - ret = intel_panel_compute_config(connector, adjusted_mode);
> > - if (ret)
> > - return ret;
> > - }
> > + if (intel_dp_is_edp(intel_dp) && fixed_mode)
> > + pipe_config->pch_pfit.is_required = true;
> >
> > if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> > return -EINVAL;
> > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
> > b/drivers/gpu/drm/i915/display/intel_panel.c
> > index dd18136d1c61..0da45c2330d3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_panel.c
> > +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> > @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state
> *crtc_state,
> > u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> > u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
> >
> > + if (crtc_state->joiner_pipes)
> > + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> > +
> > /* Native modes don't need fitting */
> > if (crtc_hdisplay == pipe_src_w &&
> > crtc_vdisplay == pipe_src_h &&
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-05 6:25 [PATCH 0/2] " Nemesa Garg
@ 2024-08-05 6:25 ` Nemesa Garg
2024-08-06 3:35 ` Nautiyal, Ankit K
2024-08-08 4:54 ` Nemesa Garg
0 siblings, 2 replies; 17+ messages in thread
From: Nemesa Garg @ 2024-08-05 6:25 UTC (permalink / raw)
To: intel-gfx; +Cc: Nemesa Garg
In panel fitter/pipe scaler scenario the pch_pfit configuration
currently takes place before accounting for pipe_src width for
joiner. This causes issue when pch_pfit and joiner get enabled
together.
Introduce a new boolean flag is_required which can be filled
during dp compute_config and later is used to compute panel_fitting in
pipe_config. Modify pch_panel_fitting to handle joiner pipes by adjusting
crtc_hdisplay accordingly.
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
4 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 8bbde03f2508..a7194a84b6b8 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
return ret;
}
+ for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
+ if (connector_state->crtc != &crtc->base)
+ continue;
+
+ if (crtc_state->pch_pfit.is_required) {
+ ret = intel_panel_fitting(crtc_state, connector_state);
+ if (ret)
+ return ret;
+ }
+ }
+
/* Dithering seems to not pass-through bits correctly when it should, so
* only enable it on 6bpc panels and when its not a compliance
* test requesting 6bpc video pattern.
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index a04d52dbf6e1..a4ab26d8fa43 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1258,6 +1258,7 @@ struct intel_crtc_state {
struct drm_rect dst;
bool enabled;
bool force_thru;
+ bool is_required;
} pch_pfit;
/* FDI configuration, only valid if has_pch_encoder is set. */
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65182bf69b62..4b707d029206 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder *encoder,
if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
- ret = intel_panel_fitting(pipe_config, conn_state);
- if (ret)
- return ret;
+ if (!pipe_config->joiner_pipes) {
+ ret = intel_panel_fitting(pipe_config, conn_state);
+ if (ret)
+ return ret;
+ } else {
+ /* Incase of bigjoiner panel_fitting is handled during pipe_config */
+ pipe_config->pch_pfit.is_required = true;
+ }
}
pipe_config->limited_color_range =
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index dd18136d1c61..0da45c2330d3 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
+ if (crtc_state->joiner_pipes)
+ crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
+
/* Native modes don't need fitting */
if (crtc_hdisplay == pipe_src_w &&
crtc_vdisplay == pipe_src_h &&
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-05 6:25 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
@ 2024-08-06 3:35 ` Nautiyal, Ankit K
2024-08-08 4:54 ` Nemesa Garg
1 sibling, 0 replies; 17+ messages in thread
From: Nautiyal, Ankit K @ 2024-08-06 3:35 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx
On 8/5/2024 11:55 AM, Nemesa Garg wrote:
> In panel fitter/pipe scaler scenario the pch_pfit configuration
> currently takes place before accounting for pipe_src width for
> joiner. This causes issue when pch_pfit and joiner get enabled
> together.
>
> Introduce a new boolean flag is_required which can be filled
> during dp compute_config and later is used to compute panel_fitting in
> pipe_config.
This is now only being done when joiner is required. For no-joiner case,
the flow remains same.
> Modify pch_panel_fitting to handle joiner pipes by adjusting
> crtc_hdisplay accordingly.
Lets maintain version history of the patch.
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
> drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> 4 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 8bbde03f2508..a7194a84b6b8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
> return ret;
> }
>
> + for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
> + if (connector_state->crtc != &crtc->base)
> + continue;
> +
> + if (crtc_state->pch_pfit.is_required) {
> + ret = intel_panel_fitting(crtc_state, connector_state);
> + if (ret)
> + return ret;
> + }
> + }
> +
> /* Dithering seems to not pass-through bits correctly when it should, so
> * only enable it on 6bpc panels and when its not a compliance
> * test requesting 6bpc video pattern.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a04d52dbf6e1..a4ab26d8fa43 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> struct drm_rect dst;
> bool enabled;
> bool force_thru;
> + bool is_required;
I think this flag is now very specific to joiner case so need to have a
better name to reflect the same.
> } pch_pfit;
>
> /* FDI configuration, only valid if has_pch_encoder is set. */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65182bf69b62..4b707d029206 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>
> if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
> pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
> - ret = intel_panel_fitting(pipe_config, conn_state);
> - if (ret)
> - return ret;
> + if (!pipe_config->joiner_pipes) {
> + ret = intel_panel_fitting(pipe_config, conn_state);
> + if (ret)
> + return ret;
> + } else {
> + /* Incase of bigjoiner panel_fitting is handled during pipe_config */
This can be just joiner.
Regards,
Ankit
> + pipe_config->pch_pfit.is_required = true;
> + }
> }
>
> pipe_config->limited_color_range =
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index dd18136d1c61..0da45c2330d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> + if (crtc_state->joiner_pipes)
> + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> +
> /* Native modes don't need fitting */
> if (crtc_hdisplay == pipe_src_w &&
> crtc_vdisplay == pipe_src_h &&
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-05 6:25 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
2024-08-06 3:35 ` Nautiyal, Ankit K
@ 2024-08-08 4:54 ` Nemesa Garg
2024-08-13 5:18 ` Nautiyal, Ankit K
2024-08-13 7:52 ` Jani Nikula
1 sibling, 2 replies; 17+ messages in thread
From: Nemesa Garg @ 2024-08-08 4:54 UTC (permalink / raw)
To: intel-gfx; +Cc: Nemesa Garg
In panel fitter/pipe scaler scenario the pch_pfit configuration
currently takes place before accounting for pipe_src width for
joiner. This causes issue when pch_pfit and joiner get enabled
together.
Introduce a new boolean flag need_joiner which is set during dp
compute_config in joiner case and later is used to compute
panel_fitting in pipe_config. Modify pch_panel_fitting to handle
joiner pipes by adjusting crtc_hdisplay accordingly.
v2: Address comments (Ankit)
v3: Change flag name (Ankit)
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
4 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 8bbde03f2508..82b67c0a90e0 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
return ret;
}
+ for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
+ if (connector_state->crtc != &crtc->base)
+ continue;
+
+ if (crtc_state->pch_pfit.need_joiner) {
+ ret = intel_panel_fitting(crtc_state, connector_state);
+ if (ret)
+ return ret;
+ }
+ }
+
/* Dithering seems to not pass-through bits correctly when it should, so
* only enable it on 6bpc panels and when its not a compliance
* test requesting 6bpc video pattern.
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index a04d52dbf6e1..eb9713b088c6 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1258,6 +1258,7 @@ struct intel_crtc_state {
struct drm_rect dst;
bool enabled;
bool force_thru;
+ bool need_joiner;
} pch_pfit;
/* FDI configuration, only valid if has_pch_encoder is set. */
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65182bf69b62..d5d9d4f21fc7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder *encoder,
if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
- ret = intel_panel_fitting(pipe_config, conn_state);
- if (ret)
- return ret;
+ if (!pipe_config->joiner_pipes) {
+ ret = intel_panel_fitting(pipe_config, conn_state);
+ if (ret)
+ return ret;
+ } else {
+ /* Incase of joiner panel_fitting is handled during pipe_config */
+ pipe_config->pch_pfit.need_joiner = true;
+ }
}
pipe_config->limited_color_range =
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index dd18136d1c61..0da45c2330d3 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
+ if (crtc_state->joiner_pipes)
+ crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
+
/* Native modes don't need fitting */
if (crtc_hdisplay == pipe_src_w &&
crtc_vdisplay == pipe_src_h &&
--
2.25.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-08 4:54 ` Nemesa Garg
@ 2024-08-13 5:18 ` Nautiyal, Ankit K
2024-08-13 7:52 ` Jani Nikula
1 sibling, 0 replies; 17+ messages in thread
From: Nautiyal, Ankit K @ 2024-08-13 5:18 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx
On 8/8/2024 10:24 AM, Nemesa Garg wrote:
> In panel fitter/pipe scaler scenario the pch_pfit configuration
> currently takes place before accounting for pipe_src width for
> joiner. This causes issue when pch_pfit and joiner get enabled
> together.
>
> Introduce a new boolean flag need_joiner which is set during dp
> compute_config in joiner case and later is used to compute
> panel_fitting in pipe_config. Modify pch_panel_fitting to handle
> joiner pipes by adjusting crtc_hdisplay accordingly.
>
> v2: Address comments (Ankit)
In general, it would be good to document the changes patch went through.
> v3: Change flag name (Ankit)
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
> drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> 4 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 8bbde03f2508..82b67c0a90e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
> return ret;
> }
>
> + for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
> + if (connector_state->crtc != &crtc->base)
> + continue;
> +
> + if (crtc_state->pch_pfit.need_joiner) {
> + ret = intel_panel_fitting(crtc_state, connector_state);
> + if (ret)
> + return ret;
> + }
> + }
> +
> /* Dithering seems to not pass-through bits correctly when it should, so
> * only enable it on 6bpc panels and when its not a compliance
> * test requesting 6bpc video pattern.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a04d52dbf6e1..eb9713b088c6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> struct drm_rect dst;
> bool enabled;
> bool force_thru;
> + bool need_joiner;
> } pch_pfit;
>
> /* FDI configuration, only valid if has_pch_encoder is set. */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65182bf69b62..d5d9d4f21fc7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>
> if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
> pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
> - ret = intel_panel_fitting(pipe_config, conn_state);
> - if (ret)
> - return ret;
> + if (!pipe_config->joiner_pipes) {
> + ret = intel_panel_fitting(pipe_config, conn_state);
> + if (ret)
> + return ret;
> + } else {
> + /* Incase of joiner panel_fitting is handled during pipe_config */
'pipe_config' seems confusing, as we already have a variable pipe_config.
Also, perhaps we can explain a bit more about the rationale behind
handling this at later point.
Apart from the minor things above, the patch looks good to me.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> + pipe_config->pch_pfit.need_joiner = true;
> + }
> }
>
> pipe_config->limited_color_range =
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index dd18136d1c61..0da45c2330d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> + if (crtc_state->joiner_pipes)
> + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> +
> /* Native modes don't need fitting */
> if (crtc_hdisplay == pipe_src_w &&
> crtc_vdisplay == pipe_src_h &&
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-08 4:54 ` Nemesa Garg
2024-08-13 5:18 ` Nautiyal, Ankit K
@ 2024-08-13 7:52 ` Jani Nikula
2024-09-09 6:21 ` Garg, Nemesa
1 sibling, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2024-08-13 7:52 UTC (permalink / raw)
To: Nemesa Garg, intel-gfx, Ville Syrjala; +Cc: Nemesa Garg
On Thu, 08 Aug 2024, Nemesa Garg <nemesa.garg@intel.com> wrote:
> In panel fitter/pipe scaler scenario the pch_pfit configuration
> currently takes place before accounting for pipe_src width for
> joiner. This causes issue when pch_pfit and joiner get enabled
> together.
>
> Introduce a new boolean flag need_joiner which is set during dp
> compute_config in joiner case and later is used to compute
> panel_fitting in pipe_config. Modify pch_panel_fitting to handle
> joiner pipes by adjusting crtc_hdisplay accordingly.
So I still don't like the fact that intel_panel_fitting() is called in
different ways for different connectors, controlled by a flag in crtc
state.
That said, I couldn't come up with a better idea either, apart from
moving *all* panel fitting intel_modeset_pipe_config().
Cc: Ville, in case he has some ideas for this. Please hold off on
merging until we get some input from him.
Thanks,
Jani.
>
> v2: Address comments (Ankit)
> v3: Change flag name (Ankit)
>
> Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
> drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> 4 files changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 8bbde03f2508..82b67c0a90e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct intel_atomic_state *state,
> return ret;
> }
>
> + for_each_new_connector_in_state(&state->base, connector, connector_state, i) {
> + if (connector_state->crtc != &crtc->base)
> + continue;
> +
> + if (crtc_state->pch_pfit.need_joiner) {
> + ret = intel_panel_fitting(crtc_state, connector_state);
> + if (ret)
> + return ret;
> + }
> + }
> +
> /* Dithering seems to not pass-through bits correctly when it should, so
> * only enable it on 6bpc panels and when its not a compliance
> * test requesting 6bpc video pattern.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a04d52dbf6e1..eb9713b088c6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> struct drm_rect dst;
> bool enabled;
> bool force_thru;
> + bool need_joiner;
> } pch_pfit;
>
> /* FDI configuration, only valid if has_pch_encoder is set. */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65182bf69b62..d5d9d4f21fc7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>
> if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
> pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
> - ret = intel_panel_fitting(pipe_config, conn_state);
> - if (ret)
> - return ret;
> + if (!pipe_config->joiner_pipes) {
> + ret = intel_panel_fitting(pipe_config, conn_state);
> + if (ret)
> + return ret;
> + } else {
> + /* Incase of joiner panel_fitting is handled during pipe_config */
> + pipe_config->pch_pfit.need_joiner = true;
> + }
> }
>
> pipe_config->limited_color_range =
> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
> index dd18136d1c61..0da45c2330d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_panel.c
> +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state *crtc_state,
> u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
>
> + if (crtc_state->joiner_pipes)
> + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> +
> /* Native modes don't need fitting */
> if (crtc_hdisplay == pipe_src_w &&
> crtc_vdisplay == pipe_src_h &&
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-08-13 7:52 ` Jani Nikula
@ 2024-09-09 6:21 ` Garg, Nemesa
2024-09-09 14:08 ` Ville Syrjälä
0 siblings, 1 reply; 17+ messages in thread
From: Garg, Nemesa @ 2024-09-09 6:21 UTC (permalink / raw)
To: Jani Nikula, intel-gfx@lists.freedesktop.org, Ville Syrjala
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Tuesday, August 13, 2024 1:22 PM
> To: Garg, Nemesa <nemesa.garg@intel.com>; intel-gfx@lists.freedesktop.org;
> Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Garg, Nemesa <nemesa.garg@intel.com>
> Subject: Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
>
> On Thu, 08 Aug 2024, Nemesa Garg <nemesa.garg@intel.com> wrote:
> > In panel fitter/pipe scaler scenario the pch_pfit configuration
> > currently takes place before accounting for pipe_src width for joiner.
> > This causes issue when pch_pfit and joiner get enabled together.
> >
> > Introduce a new boolean flag need_joiner which is set during dp
> > compute_config in joiner case and later is used to compute
> > panel_fitting in pipe_config. Modify pch_panel_fitting to handle
> > joiner pipes by adjusting crtc_hdisplay accordingly.
>
> So I still don't like the fact that intel_panel_fitting() is called in different ways for
> different connectors, controlled by a flag in crtc state.
>
> That said, I couldn't come up with a better idea either, apart from moving *all*
> panel fitting intel_modeset_pipe_config().
>
> Cc: Ville, in case he has some ideas for this. Please hold off on merging until we
> get some input from him.
>
> Hi Ville,
Can you please suggest how should I proceed further on this patch.
Thanks and Regards,
Nemesa
> Thanks,
> Jani.
>
>
> >
> > v2: Address comments (Ankit)
> > v3: Change flag name (Ankit)
> >
> > Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 11 +++++++++++
> > drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
> > drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++---
> > drivers/gpu/drm/i915/display/intel_panel.c | 3 +++
> > 4 files changed, 23 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index 8bbde03f2508..82b67c0a90e0 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -4796,6 +4796,17 @@ intel_modeset_pipe_config(struct
> intel_atomic_state *state,
> > return ret;
> > }
> >
> > + for_each_new_connector_in_state(&state->base, connector,
> connector_state, i) {
> > + if (connector_state->crtc != &crtc->base)
> > + continue;
> > +
> > + if (crtc_state->pch_pfit.need_joiner) {
> > + ret = intel_panel_fitting(crtc_state, connector_state);
> > + if (ret)
> > + return ret;
> > + }
> > + }
> > +
> > /* Dithering seems to not pass-through bits correctly when it should, so
> > * only enable it on 6bpc panels and when its not a compliance
> > * test requesting 6bpc video pattern.
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index a04d52dbf6e1..eb9713b088c6 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1258,6 +1258,7 @@ struct intel_crtc_state {
> > struct drm_rect dst;
> > bool enabled;
> > bool force_thru;
> > + bool need_joiner;
> > } pch_pfit;
> >
> > /* FDI configuration, only valid if has_pch_encoder is set. */ diff
> > --git a/drivers/gpu/drm/i915/display/intel_dp.c
> > b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 65182bf69b62..d5d9d4f21fc7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -2953,9 +2953,14 @@ intel_dp_compute_config(struct intel_encoder
> > *encoder,
> >
> > if ((intel_dp_is_edp(intel_dp) && fixed_mode) ||
> > pipe_config->output_format == INTEL_OUTPUT_FORMAT_YCBCR420)
> {
> > - ret = intel_panel_fitting(pipe_config, conn_state);
> > - if (ret)
> > - return ret;
> > + if (!pipe_config->joiner_pipes) {
> > + ret = intel_panel_fitting(pipe_config, conn_state);
> > + if (ret)
> > + return ret;
> > + } else {
> > + /* Incase of joiner panel_fitting is handled during
> pipe_config */
> > + pipe_config->pch_pfit.need_joiner = true;
> > + }
> > }
> >
> > pipe_config->limited_color_range =
> > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c
> > b/drivers/gpu/drm/i915/display/intel_panel.c
> > index dd18136d1c61..0da45c2330d3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_panel.c
> > +++ b/drivers/gpu/drm/i915/display/intel_panel.c
> > @@ -395,6 +395,9 @@ static int pch_panel_fitting(struct intel_crtc_state
> *crtc_state,
> > u16 crtc_hdisplay = adjusted_mode->crtc_hdisplay;
> > u16 crtc_vdisplay = adjusted_mode->crtc_vdisplay;
> >
> > + if (crtc_state->joiner_pipes)
> > + crtc_hdisplay = adjusted_mode->crtc_hdisplay / 2;
> > +
> > /* Native modes don't need fitting */
> > if (crtc_hdisplay == pipe_src_w &&
> > crtc_vdisplay == pipe_src_h &&
>
> --
> Jani Nikula, Intel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
2024-09-09 6:21 ` Garg, Nemesa
@ 2024-09-09 14:08 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2024-09-09 14:08 UTC (permalink / raw)
To: Garg, Nemesa; +Cc: Jani Nikula, intel-gfx@lists.freedesktop.org
On Mon, Sep 09, 2024 at 06:21:49AM +0000, Garg, Nemesa wrote:
>
>
> > -----Original Message-----
> > From: Jani Nikula <jani.nikula@linux.intel.com>
> > Sent: Tuesday, August 13, 2024 1:22 PM
> > To: Garg, Nemesa <nemesa.garg@intel.com>; intel-gfx@lists.freedesktop.org;
> > Ville Syrjala <ville.syrjala@linux.intel.com>
> > Cc: Garg, Nemesa <nemesa.garg@intel.com>
> > Subject: Re: [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config
> >
> > On Thu, 08 Aug 2024, Nemesa Garg <nemesa.garg@intel.com> wrote:
> > > In panel fitter/pipe scaler scenario the pch_pfit configuration
> > > currently takes place before accounting for pipe_src width for joiner.
> > > This causes issue when pch_pfit and joiner get enabled together.
> > >
> > > Introduce a new boolean flag need_joiner which is set during dp
> > > compute_config in joiner case and later is used to compute
> > > panel_fitting in pipe_config. Modify pch_panel_fitting to handle
> > > joiner pipes by adjusting crtc_hdisplay accordingly.
> >
> > So I still don't like the fact that intel_panel_fitting() is called in different ways for
> > different connectors, controlled by a flag in crtc state.
> >
> > That said, I couldn't come up with a better idea either, apart from moving *all*
> > panel fitting intel_modeset_pipe_config().
> >
> > Cc: Ville, in case he has some ideas for this. Please hold off on merging until we
> > get some input from him.
> >
> > Hi Ville,
> Can you please suggest how should I proceed further on this patch.
I think we want to move the whole thing to happen after we've computed
final pipe_src and pipe_mode (which can then be used intead of
adjusted_mode in the pfit calculaitons).
The one annoying part of this is that we probably can only do it for the
ilk+ pfit ("pch"), but the old gmch pfit probably has to stay where it
is now because it may have to adjust the actual transcoder timings for
the purposes of adding borders.
Also I don't think we should really need any extra flags in the crtc
state. The pfit code should be able to figure it all out on its own.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2024-09-09 14:09 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-26 9:53 [PATCH 0/2] Consider joiner calculation for panel fitting Nemesa Garg
2024-07-26 9:53 ` [PATCH 1/2] drm/i915/display: Refactor pch_panel_fitting to use local variables for crtc dimensions Nemesa Garg
2024-07-29 14:43 ` Nautiyal, Ankit K
2024-07-26 9:53 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
2024-07-29 15:06 ` Nautiyal, Ankit K
2024-07-30 7:56 ` Jani Nikula
2024-07-30 16:20 ` Garg, Nemesa
2024-07-26 10:54 ` ✗ Fi.CI.BAT: failure for Consider joiner calculation for panel fitting Patchwork
2024-07-29 8:27 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-29 15:28 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-08-05 6:25 [PATCH 0/2] " Nemesa Garg
2024-08-05 6:25 ` [PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config Nemesa Garg
2024-08-06 3:35 ` Nautiyal, Ankit K
2024-08-08 4:54 ` Nemesa Garg
2024-08-13 5:18 ` Nautiyal, Ankit K
2024-08-13 7:52 ` Jani Nikula
2024-09-09 6:21 ` Garg, Nemesa
2024-09-09 14:08 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox