From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v10 09/10] drm/i915/display: Add HAS_PSR_TRANS_PUSH_FRAME_CHANGE macro
Date: Tue, 27 Jan 2026 13:18:06 +0530 [thread overview]
Message-ID: <2af649aa-4b90-4f92-926b-2447686d8340@intel.com> (raw)
In-Reply-To: <20260126075959.925413-10-jouni.hogander@intel.com>
On 1/26/2026 1:29 PM, Jouni Högander wrote:
> Add macro telling platform supports triggering Frame Change event using
> Trans Push mechanism.
Perhaps :
Add a macro indicating that the platform supports triggering a Frame
Change event for the PSR HW using the TRANS PUSH mechanism.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 6c74d6b0cc48..13558bc648ab 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -196,6 +196,7 @@ struct intel_display_platforms {
> #define HAS_PSR(__display) (DISPLAY_INFO(__display)->has_psr)
> #define HAS_PSR_HW_TRACKING(__display) (DISPLAY_INFO(__display)->has_psr_hw_tracking)
> #define HAS_PSR2_SEL_FETCH(__display) (DISPLAY_VER(__display) >= 12)
> +#define HAS_PSR_TRANS_PUSH_FRAME_CHANGE(__display) (DISPLAY_VER(__display) >= 20)
The HAS_PSR_HW_TRACKING should be below HAS_PSR2_SEL_FETCH, but can be a
separate patch, as not related to the series.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> #define HAS_SAGV(__display) (DISPLAY_VER(__display) >= 9 && \
> !(__display)->platform.broxton && !(__display)->platform.geminilake)
> #define HAS_TRANSCODER(__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \
next prev parent reply other threads:[~2026-01-27 7:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 7:59 [PATCH v10 00/10] Use trans push mechanism to generate frame change event Jouni Högander
2026-01-26 7:59 ` [PATCH v10 01/10] drm/i915/psr: Add TRANS_PUSH register bit definition for PSR Jouni Högander
2026-01-26 7:59 ` [PATCH v10 02/10] drm/i915/psr: Add intel_psr_use_trans_push to query if TRANS_PUSH is used Jouni Högander
2026-01-27 5:20 ` Nautiyal, Ankit K
2026-01-26 7:59 ` [PATCH v10 03/10] drm/i915/vrr: Add helper for parsing value to be written into TRANS_PUSH Jouni Högander
2026-01-27 5:25 ` Nautiyal, Ankit K
2026-01-26 7:59 ` [PATCH v10 04/10] drm/i915/vrr: Prepare to Use TRANS_PUSH mechanism for PSR frame change Jouni Högander
2026-01-27 5:18 ` Nautiyal, Ankit K
2026-01-26 7:59 ` [PATCH v10 05/10] drm/i915/dsb: Set DSB_SKIP_WAITS_EN chicken bit for LunarLake and onwards Jouni Högander
2026-01-27 5:32 ` Nautiyal, Ankit K
2026-01-26 7:59 ` [PATCH v10 06/10] drm/i915/display: Wait for vblank in case of PSR is using trans push Jouni Högander
2026-01-27 5:41 ` Nautiyal, Ankit K
2026-01-26 7:59 ` [PATCH v10 07/10] drm/i915/psr: Wait for idle only after possible send push Jouni Högander
2026-01-26 7:59 ` [PATCH v10 08/10] drm/i915/psr: Do PSR exit on frontbuffer flush on LunarLake and onwards Jouni Högander
2026-01-26 7:59 ` [PATCH v10 09/10] drm/i915/display: Add HAS_PSR_TRANS_PUSH_FRAME_CHANGE macro Jouni Högander
2026-01-27 7:48 ` Nautiyal, Ankit K [this message]
2026-01-26 7:59 ` [PATCH v10 10/10] drm/i915/psr: Use TRANS_PUSH to trigger frame change event Jouni Högander
2026-01-27 8:35 ` Nautiyal, Ankit K
2026-01-26 8:44 ` ✓ i915.CI.BAT: success for Use trans push mechanism to generate " Patchwork
2026-01-26 10:32 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af649aa-4b90-4f92-926b-2447686d8340@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox