* [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
@ 2019-03-07 18:44 Sujaritha Sundaresan
2019-03-07 19:37 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sujaritha Sundaresan @ 2019-03-07 18:44 UTC (permalink / raw)
To: intel-gfx; +Cc: Sujaritha Sundaresan
Adding the call to prepare for guc reset along with engine
reset. intel_uc_reset_prepare() calls to disable guc communication
and to sanitize.
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
drivers/gpu/drm/i915/i915_reset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
index 3fbaa72a9eac..dcaa33b72636 100644
--- a/drivers/gpu/drm/i915/i915_reset.c
+++ b/drivers/gpu/drm/i915/i915_reset.c
@@ -820,6 +820,8 @@ static void __i915_gem_set_wedged(struct drm_i915_private *i915)
for_each_engine(engine, i915, id)
reset_prepare_engine(engine);
+ intel_uc_reset_prepare(i915);
+
/* Even if the GPU reset fails, it should still stop the engines */
if (!INTEL_INFO(i915)->gpu_reset_clobbers_display)
intel_gpu_reset(i915, ALL_ENGINES);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
2019-03-07 18:44 [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset Sujaritha Sundaresan
@ 2019-03-07 19:37 ` Patchwork
2019-03-07 22:54 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-12 20:57 ` [PATCH 1/1] " Daniele Ceraolo Spurio
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-03-07 19:37 UTC (permalink / raw)
To: Sujaritha Sundaresan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
URL : https://patchwork.freedesktop.org/series/57704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5715 -> Patchwork_12407
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/57704/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12407 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_5715 -> Patchwork_12407
CI_DRM_5715: 1e2e0ac7a83ecea351d368ae2c9ee67be54d6d97 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12407: 98113480d4d43920fed42f258bdbd829fba2f76b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
98113480d4d4 drm/i915/guc: Preparing for GuC reset along with engine reset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12407/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
2019-03-07 18:44 [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset Sujaritha Sundaresan
2019-03-07 19:37 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
@ 2019-03-07 22:54 ` Patchwork
2019-03-12 20:57 ` [PATCH 1/1] " Daniele Ceraolo Spurio
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-03-07 22:54 UTC (permalink / raw)
To: Sujaritha Sundaresan; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
URL : https://patchwork.freedesktop.org/series/57704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5715_full -> Patchwork_12407_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12407_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-self-bsd2:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +42
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107807]
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +9
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_chamelium@hdmi-crc-bgr565:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +3
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +1
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-skl: PASS -> FAIL [fdo#103184] +1
* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
- shard-glk: PASS -> FAIL [fdo#103060] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: PASS -> FAIL [fdo#103167] +1
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-skl: NOTRUN -> FAIL [fdo#108145] +1
* igt@kms_rotation_crc@multiplane-rotation:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +3
* igt@perf_pmu@busy-accuracy-98-vcs1:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +76
#### Possible fixes ####
* igt@gem_exec_big:
- shard-hsw: TIMEOUT [fdo#107937] -> PASS
* igt@gem_exec_schedule@preempt-queue-contexts-vebox:
- {shard-iclb}: FAIL -> PASS +1
* igt@gem_wait@basic-wait-write-all:
- {shard-iclb}: INCOMPLETE -> PASS
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP [fdo#109271] -> PASS +1
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_chv_cursor_fail@pipe-c-128x128-right-edge:
- shard-skl: FAIL [fdo#104671] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-skl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-skl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_fbcon_fbt@fbc:
- {shard-iclb}: DMESG-WARN [fdo#109593] -> PASS
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: FAIL [fdo#105363] -> PASS
* igt@kms_flip_tiling@flip-to-y-tiled:
- shard-skl: FAIL [fdo#107931] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- {shard-iclb}: FAIL [fdo#103167] -> PASS +5
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@plane-panning-bottom-right-pipe-b-planes:
- shard-skl: FAIL [fdo#103166] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: FAIL [fdo#104894] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106887]: https://bugs.freedesktop.org/show_bug.cgi?id=106887
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#107937]: https://bugs.freedesktop.org/show_bug.cgi?id=107937
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109287]: https://bugs.freedesktop.org/show_bug.cgi?id=109287
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109301]: https://bugs.freedesktop.org/show_bug.cgi?id=109301
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#109766]: https://bugs.freedesktop.org/show_bug.cgi?id=109766
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5715 -> Patchwork_12407
CI_DRM_5715: 1e2e0ac7a83ecea351d368ae2c9ee67be54d6d97 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4876: 51b8d4cfde8d5b0176180b9683accea91474c7ff @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12407: 98113480d4d43920fed42f258bdbd829fba2f76b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12407/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
2019-03-07 18:44 [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset Sujaritha Sundaresan
2019-03-07 19:37 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2019-03-07 22:54 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-03-12 20:57 ` Daniele Ceraolo Spurio
2019-03-14 8:34 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-03-12 20:57 UTC (permalink / raw)
To: Sujaritha Sundaresan, intel-gfx
On 3/7/19 10:44 AM, Sujaritha Sundaresan wrote:
> Adding the call to prepare for guc reset along with engine
> reset. intel_uc_reset_prepare() calls to disable guc communication
> and to sanitize.
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reset.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
> index 3fbaa72a9eac..dcaa33b72636 100644
> --- a/drivers/gpu/drm/i915/i915_reset.c
> +++ b/drivers/gpu/drm/i915/i915_reset.c
> @@ -820,6 +820,8 @@ static void __i915_gem_set_wedged(struct drm_i915_private *i915)
> for_each_engine(engine, i915, id)
> reset_prepare_engine(engine);
>
> + intel_uc_reset_prepare(i915);
> +
> /* Even if the GPU reset fails, it should still stop the engines */
> if (!INTEL_INFO(i915)->gpu_reset_clobbers_display)
> intel_gpu_reset(i915, ALL_ENGINES);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset
2019-03-12 20:57 ` [PATCH 1/1] " Daniele Ceraolo Spurio
@ 2019-03-14 8:34 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2019-03-14 8:34 UTC (permalink / raw)
To: Daniele Ceraolo Spurio, Sujaritha Sundaresan, intel-gfx
Quoting Daniele Ceraolo Spurio (2019-03-12 20:57:42)
>
>
> On 3/7/19 10:44 AM, Sujaritha Sundaresan wrote:
> > Adding the call to prepare for guc reset along with engine
> > reset. intel_uc_reset_prepare() calls to disable guc communication
> > and to sanitize.
> >
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
And pushed, thanks for the patch and review.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-14 8:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 18:44 [PATCH 1/1] drm/i915/guc: Preparing for GuC reset along with engine reset Sujaritha Sundaresan
2019-03-07 19:37 ` ✓ Fi.CI.BAT: success for series starting with [1/1] " Patchwork
2019-03-07 22:54 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-12 20:57 ` [PATCH 1/1] " Daniele Ceraolo Spurio
2019-03-14 8:34 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox