* [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE
@ 2020-02-24 15:56 Chris Wilson
2020-02-24 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2020-02-24 15:56 UTC (permalink / raw)
To: intel-gfx
Tidy up after a call to eb_parse() if a later bind fails.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index 87fa5f42c39a..4f9c1f5a4ded 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2713,7 +2713,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
vma = i915_gem_object_ggtt_pin(eb.batch->obj, NULL, 0, 0, 0);
if (IS_ERR(vma)) {
err = PTR_ERR(vma);
- goto err_vma;
+ goto err_parse;
}
eb.batch = vma;
@@ -2792,6 +2792,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
err_batch_unpin:
if (eb.batch_flags & I915_DISPATCH_SECURE)
i915_vma_unpin(eb.batch);
+err_parse:
if (eb.batch->private)
intel_engine_pool_put(eb.batch->private);
err_vma:
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE 2020-02-24 15:56 [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE Chris Wilson @ 2020-02-24 20:07 ` Patchwork 2020-02-26 10:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-26 13:12 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-02-24 20:07 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE URL : https://patchwork.freedesktop.org/series/73857/ State : success == Summary == CI Bug Log - changes from CI_DRM_7999 -> Patchwork_16692 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/index.html Known issues ------------ Here are the changes found in Patchwork_16692 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-hsw-peppy: [PASS][1] -> [INCOMPLETE][2] ([i915#694] / [i915#816]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-hsw-peppy/igt@gem_close_race@basic-threads.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-hsw-peppy/igt@gem_close_race@basic-threads.html * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [PASS][3] -> [FAIL][4] ([CI#94]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@i915_selftest@live_hangcheck: - fi-skl-guc: [PASS][5] -> [INCOMPLETE][6] ([fdo#108744]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-skl-guc/igt@i915_selftest@live_hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-skl-guc/igt@i915_selftest@live_hangcheck.html * igt@kms_addfb_basic@addfb25-y-tiled: - fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([CI#94] / [i915#402]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-tgl-y/igt@kms_addfb_basic@addfb25-y-tiled.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-tgl-y/igt@kms_addfb_basic@addfb25-y-tiled.html * igt@kms_chamelium@dp-edid-read: - fi-cml-u2: [PASS][9] -> [FAIL][10] ([i915#217] / [i915#976]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][11] -> [FAIL][12] ([fdo#111407]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Possible fixes #### * igt@gem_close_race@basic-threads: - fi-byt-n2820: [INCOMPLETE][13] ([i915#45]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-byt-n2820/igt@gem_close_race@basic-threads.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-byt-n2820/igt@gem_close_race@basic-threads.html * igt@kms_addfb_basic@addfb25-yf-tiled: - fi-tgl-y: [DMESG-WARN][15] ([CI#94] / [i915#402]) -> [PASS][16] +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-tgl-y/igt@kms_addfb_basic@addfb25-yf-tiled.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-tgl-y/igt@kms_addfb_basic@addfb25-yf-tiled.html #### Warnings #### * igt@gem_close_race@basic-threads: - fi-byt-j1900: [INCOMPLETE][17] ([i915#45]) -> [TIMEOUT][18] ([fdo#112271] / [i915#1084] / [i915#816]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/fi-byt-j1900/igt@gem_close_race@basic-threads.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/fi-byt-j1900/igt@gem_close_race@basic-threads.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816 [i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976 Participating hosts (52 -> 45) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7999 -> Patchwork_16692 CI-20190529: 20190529 CI_DRM_7999: e853e3d470d1bb4ac87042094b99adbdbaa87944 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5463: d519c80219ebe558cd2fa378f26f9d73f9e35310 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16692: afccf9a3632c60cfee91fdf498010dbcb75b08d3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == afccf9a3632c drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE 2020-02-24 15:56 [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE Chris Wilson 2020-02-24 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-02-26 10:35 ` Patchwork 2020-02-26 13:12 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2020-02-26 10:35 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE URL : https://patchwork.freedesktop.org/series/73857/ State : success == Summary == CI Bug Log - changes from CI_DRM_7999_full -> Patchwork_16692_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16692_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +14 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb4/igt@gem_busy@busy-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb7/igt@gem_busy@busy-vcs1.html * igt@gem_exec_schedule@independent-bsd2: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276]) +12 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb3/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +7 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_softpin@noreloc-s3: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-apl3/igt@gem_softpin@noreloc-s3.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-apl4/igt@gem_softpin@noreloc-s3.html * igt@gem_workarounds@suspend-resume: - shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#69]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl7/igt@gem_workarounds@suspend-resume.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl8/igt@gem_workarounds@suspend-resume.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#79]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend: - shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#221]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl2/igt@kms_flip@flip-vs-suspend.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl1/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#49]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#899]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-y.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb2/igt@kms_psr@psr2_suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb5/igt@kms_psr@psr2_suspend.html * igt@kms_setmode@basic: - shard-kbl: [PASS][29] -> [FAIL][30] ([i915#31]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-kbl7/igt@kms_setmode@basic.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-kbl3/igt@kms_setmode@basic.html * igt@sw_sync@sync_multi_producer_single_consumer: - shard-iclb: [PASS][31] -> [TIMEOUT][32] ([fdo#112271]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb7/igt@sw_sync@sync_multi_producer_single_consumer.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb6/igt@sw_sync@sync_multi_producer_single_consumer.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs1-s3: - shard-kbl: [DMESG-WARN][33] ([i915#56]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-kbl7/igt@gem_ctx_isolation@vcs1-s3.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-kbl6/igt@gem_ctx_isolation@vcs1-s3.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][35] ([fdo#110854]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb6/igt@gem_exec_balancer@smoke.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb4/igt@gem_exec_balancer@smoke.html * {igt@gem_exec_schedule@implicit-both-bsd2}: - shard-iclb: [SKIP][37] ([fdo#109276] / [i915#677]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb6/igt@gem_exec_schedule@implicit-both-bsd2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd2.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [SKIP][39] ([fdo#112146]) -> [PASS][40] +5 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb5/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@pi-userfault-bsd: - shard-iclb: [SKIP][41] ([i915#677]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb4/igt@gem_exec_schedule@pi-userfault-bsd.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb3/igt@gem_exec_schedule@pi-userfault-bsd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [FAIL][43] ([i915#644]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][45] ([i915#716]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk9/igt@gen9_exec_parse@allowed-all.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk7/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [INCOMPLETE][47] ([i915#151] / [i915#69]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +3 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html * {igt@kms_hdr@bpc-switch-suspend}: - shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][53] ([fdo#109642] / [fdo#111068]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb8/igt@kms_psr2_su@page_flip.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +1 similar issue [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@kms_setmode@basic: - shard-apl: [FAIL][57] ([i915#31]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-apl6/igt@kms_setmode@basic.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-apl4/igt@kms_setmode@basic.html * igt@perf_pmu@init-busy-vcs1: - shard-iclb: [SKIP][59] ([fdo#112080]) -> [PASS][60] +9 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb8/igt@perf_pmu@init-busy-vcs1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@perf_pmu@init-busy-vcs1.html * igt@prime_busy@after-bsd2: - shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +20 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb8/igt@prime_busy@after-bsd2.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@prime_busy@after-bsd2.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [SKIP][63] ([fdo#112080]) -> [FAIL][64] ([IGT#28]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_fence_thrash@bo-write-verify-threaded-x: - shard-iclb: [TIMEOUT][65] ([fdo#112271]) -> [TIMEOUT][66] ([fdo#112271] / [i915#1321]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb6/igt@gem_fence_thrash@bo-write-verify-threaded-x.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb1/igt@gem_fence_thrash@bo-write-verify-threaded-x.html * igt@gem_fence_thrash@bo-write-verify-threaded-y: - shard-skl: [TIMEOUT][67] ([fdo#112271]) -> [TIMEOUT][68] ([fdo#112271] / [i915#1321]) +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-skl2/igt@gem_fence_thrash@bo-write-verify-threaded-y.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-skl2/igt@gem_fence_thrash@bo-write-verify-threaded-y.html * igt@gem_linear_blits@interruptible: - shard-apl: [TIMEOUT][69] ([fdo#112271]) -> [TIMEOUT][70] ([fdo#112271] / [i915#1322]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-apl7/igt@gem_linear_blits@interruptible.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-apl1/igt@gem_linear_blits@interruptible.html * igt@i915_pm_rpm@legacy-planes-dpms: - shard-snb: [INCOMPLETE][71] ([i915#82]) -> [SKIP][72] ([fdo#109271]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-snb5/igt@i915_pm_rpm@legacy-planes-dpms.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-snb2/igt@i915_pm_rpm@legacy-planes-dpms.html * igt@kms_atomic_transition@plane-all-modeset-transition-fencing: - shard-glk: [TIMEOUT][73] ([fdo#112271]) -> [TIMEOUT][74] ([fdo#112271] / [i915#1320]) +1 similar issue [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk2/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk1/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html * igt@kms_content_protection@atomic: - shard-kbl: [TIMEOUT][75] ([fdo#112271]) -> [TIMEOUT][76] ([fdo#112271] / [i915#1319]) +4 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-kbl6/igt@kms_content_protection@atomic.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-kbl2/igt@kms_content_protection@atomic.html * igt@kms_content_protection@lic: - shard-apl: [TIMEOUT][77] ([fdo#112271]) -> [TIMEOUT][78] ([fdo#112271] / [i915#1319]) +4 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-apl6/igt@kms_content_protection@lic.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-apl4/igt@kms_content_protection@lic.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][79] ([i915#1226]) -> [SKIP][80] ([fdo#109349]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_flip@flip-vs-modeset-vs-hang-interruptible: - shard-glk: [TIMEOUT][81] ([fdo#112271]) -> [TIMEOUT][82] ([fdo#112271] / [i915#1284]) +2 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7999/shard-glk5/igt@kms_flip@flip-vs-modeset-vs-hang-interruptible.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/shard-glk9/igt@kms_flip@flip-vs-modeset-vs-hang-interruptible.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1284]: https://gitlab.freedesktop.org/drm/intel/issues/1284 [i915#1291]: https://gitlab.freedesktop.org/drm/intel/issues/1291 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1320]: https://gitlab.freedesktop.org/drm/intel/issues/1320 [i915#1321]: https://gitlab.freedesktop.org/drm/intel/issues/1321 [i915#1322]: https://gitlab.freedesktop.org/drm/intel/issues/1322 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7999 -> Patchwork_16692 CI-20190529: 20190529 CI_DRM_7999: e853e3d470d1bb4ac87042094b99adbdbaa87944 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5463: d519c80219ebe558cd2fa378f26f9d73f9e35310 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16692: afccf9a3632c60cfee91fdf498010dbcb75b08d3 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16692/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE 2020-02-24 15:56 [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE Chris Wilson 2020-02-24 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-26 10:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-02-26 13:12 ` Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Tvrtko Ursulin @ 2020-02-26 13:12 UTC (permalink / raw) To: Chris Wilson, intel-gfx On 24/02/2020 15:56, Chris Wilson wrote: > Tidy up after a call to eb_parse() if a later bind fails. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 87fa5f42c39a..4f9c1f5a4ded 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -2713,7 +2713,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, > vma = i915_gem_object_ggtt_pin(eb.batch->obj, NULL, 0, 0, 0); > if (IS_ERR(vma)) { > err = PTR_ERR(vma); > - goto err_vma; > + goto err_parse; > } > > eb.batch = vma; > @@ -2792,6 +2792,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, > err_batch_unpin: > if (eb.batch_flags & I915_DISPATCH_SECURE) > i915_vma_unpin(eb.batch); > +err_parse: > if (eb.batch->private) > intel_engine_pool_put(eb.batch->private); > err_vma: > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-26 13:12 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-24 15:56 [Intel-gfx] [PATCH] drm/i915/gem: Cleanup shadow batch after I915_EXEC_SECURE Chris Wilson 2020-02-24 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-02-26 10:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-26 13:12 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox