Re: [PATCH] drm/i915: Reinstate error level message for non-simulated gpu hangs

From: Kenneth Graunke <kenneth@whitecape.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH] drm/i915: Reinstate error level message for non-simulated gpu hangs
Date: Wed, 01 Oct 2014 01:52:20 -0700	[thread overview]
Message-ID: <3131970.hs5t3utFuN@vakarian> (raw)
In-Reply-To: <20141001082907.GL12343@phenom.ffwll.local>

[-- Attachment #1.1: Type: text/plain, Size: 2057 bytes --]

On Wednesday, October 01, 2014 10:29:07 AM Daniel Vetter wrote:
> On Wed, Oct 01, 2014 at 09:19:50AM +0100, Chris Wilson wrote:
> > On Wed, Oct 01, 2014 at 10:13:00AM +0200, Daniel Vetter wrote:
> > > On Wed, Oct 01, 2014 at 07:28:39AM +0100, Chris Wilson wrote:
> > > > On Wed, Oct 01, 2014 at 01:04:19AM +0200, Daniel Vetter wrote:
> > > > > This seems to have been accidentally lost in
> > > > > 
> > > > > commit be62acb4cce1389a28296852737e3917d9cc5b25
> > > > > Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > > > > Date:   Fri Aug 30 16:19:28 2013 +0300
> > > > > 
> > > > >     drm/i915: ban badly behaving contexts
> > > > > 
> > > > > Without this real gpu hangs only log output at info level, which gets
> > > > > filtered away by piglit's testrunner.
> > > > 
> > > > A successful GPU hang is not an error. Might be a warn or a notice, but
> > > > it certainly isn't a driver error.
> > > 
> > > Well not of the kernel driver, but might very well be a bug in the
> > > userspace driver. With this piglit marks tests that hung the gpu as
> > > dmesg-fail, without this they might even pass. Ken raised this on irc and
> > > I agree that it's a must-have feature for developers that their testsuite
> > > can tell them when stuff broke. Provding this some other way is a lot more
> > > work and imo should be done in a separate patch, this here is just the
> > > minimal fix for this regression.
> > 
> > I strongly disagree that we should be working around self-imposed
> > limitations of the test suite by making users believe their kernel is
> > broken.
> 
> So what else should piglit do then?
> -Daniel

Your GPU hanging is clearly more severe than "info" - it may impact your system stability, and likely represents a bug somewhere in the graphics drivers (whether kernel or userspace).  I think we all agree on that.

Piglit runs "dmesg --level emerg,alert,crit,err,warn,notice", which covers everything except "info" and "debug".  So anything other than info/debug would be just fine.

--Ken

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx