Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-gfx@lists.freedesktop.org, "CQ Tang" <cq.tang@intel.com>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 3/4] tests/gem_lmem_swapping: limit lmem to 4G
Date: Fri, 25 Mar 2022 10:20:16 +0000	[thread overview]
Message-ID: <31737669-8504-648c-90d5-8a76d6d1abef@intel.com> (raw)
In-Reply-To: <Yj2XCNwAQ4Y98r8L@platvala-desk.ger.corp.intel.com>

On 25/03/2022 10:18, Petri Latvala wrote:
> On Thu, Mar 24, 2022 at 02:26:20PM +0000, Matthew Auld wrote:
>> From: CQ Tang <cq.tang@intel.com>
>>
>> On some systems lmem can be as large as 16G, which seems to trigger
>> various CI timeouts, and in the best case just takes a long time. For
>> the purposes of the test we should be able to limit to 4G, without any
>> big loss in coverage.
>>
>> Signed-off-by: CQ Tang <cq.tang@intel.com>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
>> ---
>>   tests/i915/gem_lmem_swapping.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
>> index 995a663f..ad1c989c 100644
>> --- a/tests/i915/gem_lmem_swapping.c
>> +++ b/tests/i915/gem_lmem_swapping.c
>> @@ -526,7 +526,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>>   	igt_fixture {
>>   		struct intel_execution_engine2 *e;
>>   
>> -		i915 = drm_open_driver(DRIVER_INTEL);
>> +		igt_i915_driver_unload();
>> +		if (igt_i915_driver_load("lmem_size=4096")) {
>> +			igt_debug("i915 missing lmem_size modparam support\n");
>> +			igt_assert_eq(igt_i915_driver_load(NULL), 0);
>> +		}
> 
> Does the driver load truly fail with an unknown param?

Yeah, I have since removed that. From the CI logs it just loads anyway...

> 
> 

  reply	other threads:[~2022-03-25 10:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 14:26 [Intel-gfx] [PATCH i-g-t 0/4] Some gem_lmem_swapping tweaks Matthew Auld
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 1/4] test/gem_lmem_swapping: account for object rounding Matthew Auld
2022-03-24 17:25   ` Dixit, Ashutosh
2022-03-25  8:05   ` Thomas Hellström
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 2/4] test/gem_lmem_swapping: fix physical engine usage Matthew Auld
2022-03-24 14:46   ` Tvrtko Ursulin
2022-03-24 17:39   ` [Intel-gfx] [igt-dev] " Dixit, Ashutosh
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 3/4] tests/gem_lmem_swapping: limit lmem to 4G Matthew Auld
2022-03-24 14:33   ` Thomas Hellström
2022-03-24 17:47   ` [Intel-gfx] [igt-dev] " Dixit, Ashutosh
2022-03-25  8:40     ` Matthew Auld
2022-03-25 10:02       ` Petri Latvala
2022-03-25 10:13   ` [Intel-gfx] " Das, Nirmoy
2022-03-25 10:18   ` [Intel-gfx] [igt-dev] " Petri Latvala
2022-03-25 10:20     ` Matthew Auld [this message]
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 4/4] tests/gem_lmem_swapping: reduce the timeout Matthew Auld
2022-03-25  7:21   ` Thomas Hellström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31737669-8504-648c-90d5-8a76d6d1abef@intel.com \
    --to=matthew.auld@intel.com \
    --cc=cq.tang@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox