From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: igt-dev@lists.freedesktop.org,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] test/gem_lmem_swapping: fix physical engine usage
Date: Thu, 24 Mar 2022 10:39:48 -0700 [thread overview]
Message-ID: <87h77ndzbv.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220324142621.347452-3-matthew.auld@intel.com>
On Thu, 24 Mar 2022 07:26:19 -0700, Matthew Auld wrote:
>
> @@ -353,14 +356,17 @@ static void test_evict(int i915,
> if (flags & TEST_PARALLEL) {
> int fd = gem_reopen_driver(i915);
>
> + ctx = intel_ctx_create_all_physical(fd);
> + __gem_context_set_persistence(i915, ctx->id, false);
> +
> igt_fork(child, nproc)
> - __do_evict(fd, ®ion->region, ¶ms,
> + __do_evict(fd, ctx, ®ion->region, ¶ms,
> params.seed + child + 1);
>
> igt_waitchildren();
> close(fd);
We might introduce some memory leak tests some time so it would be good to
destroy any contexts we create with intel_ctx_destroy().
> @@ -528,17 +536,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> for_each_physical_engine(i915, e)
> __num_engines__++;
> igt_require(__num_engines__);
> + ctx = intel_ctx_create_all_physical(i915);
> + __gem_context_set_persistence(i915, ctx->id, false);
> +
> }
>
> for (test = tests; test->name; test++) {
> igt_describe("Exercise local memory swapping to system memory");
> dynamic_lmem_subtest(region, regions, test->name)
> - test_evict(i915, region, test->flags);
> + test_evict(i915, ctx, region, test->flags);
> }
>
> igt_describe("Exercise local memory swapping during exhausting system memory");
> dynamic_lmem_subtest(region, regions, "smem-oom")
> - test_smem_oom(i915, region);
> + test_smem_oom(i915, ctx, region);
>
> igt_fixture {
> free(regions);
Here too.
next prev parent reply other threads:[~2022-03-24 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:26 [Intel-gfx] [PATCH i-g-t 0/4] Some gem_lmem_swapping tweaks Matthew Auld
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 1/4] test/gem_lmem_swapping: account for object rounding Matthew Auld
2022-03-24 17:25 ` Dixit, Ashutosh
2022-03-25 8:05 ` Thomas Hellström
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 2/4] test/gem_lmem_swapping: fix physical engine usage Matthew Auld
2022-03-24 14:46 ` Tvrtko Ursulin
2022-03-24 17:39 ` Dixit, Ashutosh [this message]
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 3/4] tests/gem_lmem_swapping: limit lmem to 4G Matthew Auld
2022-03-24 14:33 ` Thomas Hellström
2022-03-24 17:47 ` [Intel-gfx] [igt-dev] " Dixit, Ashutosh
2022-03-25 8:40 ` Matthew Auld
2022-03-25 10:02 ` Petri Latvala
2022-03-25 10:13 ` [Intel-gfx] " Das, Nirmoy
2022-03-25 10:18 ` [Intel-gfx] [igt-dev] " Petri Latvala
2022-03-25 10:20 ` Matthew Auld
2022-03-24 14:26 ` [Intel-gfx] [PATCH i-g-t 4/4] tests/gem_lmem_swapping: reduce the timeout Matthew Auld
2022-03-25 7:21 ` Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h77ndzbv.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox