Re: [PATCH 04/12] drm/i915/dp: Remove HAS_DSC macro for intel_dp_dsc_max_src_input_bpc

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 11/27/2024 11:15 AM, Kandpal, Suraj wrote:
>
>> -----Original Message-----
>> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
>> Sent: Wednesday, November 20, 2024 4:08 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: intel-xe@lists.freedesktop.org; Kandpal, Suraj <suraj.kandpal@intel.com>;
>> jani.nikula@linux.intel.com; Deak, Imre <imre.deak@intel.com>
>> Subject: [PATCH 04/12] drm/i915/dp: Remove HAS_DSC macro for
>> intel_dp_dsc_max_src_input_bpc
>>
>> DSC support is already checked before the helper
>> intel_dp_dsc_max_src_input_bpc is called.
>> Remove the check from the helper.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>> b/drivers/gpu/drm/i915/display/intel_dp.c
>> index d82e25d0dc5a..dd60ca532ae3 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -2195,7 +2195,7 @@ static
>>   u8 intel_dp_dsc_min_src_input_bpc(struct drm_i915_private *i915)  {
>>   	/* Min DSC Input BPC for ICL+ is 8 */
>> -	return HAS_DSC(i915) ? 8 : 0;
>> +	return 8;
> With this change we don't really need to pass drm_i915_private to this function how about we make it a void function
> This also helps us move away from intel_display

Yeah I agree we dont need to pass drm_i915_private. Will fix this.

Regards,

Ankit

>
> Regards,
> Suraj Kandpal
>
>>   }
>>
>>   static
>> --
>> 2.45.2