Re: [PATCH] drm/i915/panic: fix panic structure allocation memory leak

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 02 Oct 2025, Michał Grzelak <michal.grzelak@intel.com> wrote:
> On Thu, 2 Oct 2025, Jani Nikula wrote:
>> Separating the panic allocation from framebuffer allocation in commit
>> 729c5f7ffa83 ("drm/{i915,xe}/panic: move framebuffer allocation where it
>> belongs") failed to deallocate the panic structure anywhere.
>>
>> The fix is two-fold. First, free the panic structure in
>> intel_user_framebuffer_destroy() in the general case. Second, move the
>> panic allocation later to intel_framebuffer_init() to not leak the panic
>> structure in error paths (if any, now or later) between
>> intel_framebuffer_alloc() and intel_framebuffer_init().
>>
>> Fixes: 729c5f7ffa83 ("drm/{i915,xe}/panic: move framebuffer allocation where it belongs")
>> Cc: Jocelyn Falempe <jfalempe@redhat.com>
>> Cc: Maarten Lankhorst <dev@lankhorst.se>
>> Reported-by: Michał Grzelak <michal.grzelak@intel.com>
>> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Have run a bunch of tests on affected platform, which previously caused
> the issue to surface. With the patch applied no memleaks are reported.
>
> Tested-by: Michał Grzelak <michal.grzelak@intel.com>

Thanks for confirming!

Looks like we'll need to merge [1] first, or the stable backport of that
is going to be a nightmare.

BR,
Jani.


[1] https://lore.kernel.org/r/20251002115434.6486-2-ville.syrjala@linux.intel.com



-- 
Jani Nikula, Intel