* [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
@ 2023-07-10 7:36 Janusz Krzysztofik
2023-07-10 8:05 ` Borislav Petkov
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Janusz Krzysztofik @ 2023-07-10 7:36 UTC (permalink / raw)
To: x86
Cc: Juergen Gross, intel-gfx, Dave Hansen,
Marek Marczykowski-Górecki, linux-kernel, Ingo Molnar,
Borislav Petkov, Thomas Gleixner, Edgecombe, Rick P
Visible glitches have been observed when running graphics applications on
Linux under Xen hypervisor. Those observations have been confirmed with
failures from kms_pwrite_crc Intel GPU test that verifies data coherency
of DRM frame buffer objects using hardware CRC checksums calculated by
display controllers, exposed to userspace via debugfs. Affected
processing paths have then been identified with new IGT test variants that
mmap the objects using different methods and caching modes [1].
When running as a Xen PV guest, Linux uses Xen provided PAT configuration
which is different from its native one. In particular, Xen specific PTE
encoding of write-combining caching, likely used by graphics applications,
differs from the Linux default one found among statically defined minimal
set of supported modes. Since Xen defines PTE encoding of the WC mode as
_PAGE_PAT, it no longer belongs to the minimal set, depends on correct
handling of _PAGE_PAT bit, and can be mismatched with write-back caching.
When a user calls mmap() for a DRM buffer object, DRM device specific
.mmap file operation, called from mmap_region(), takes care of setting PTE
encoding bits in a vm_page_prot field of an associated virtual memory area
structure. Unfortunately, _PAGE_PAT bit is not preserved when the vma's
.vm_flags are then applied to .vm_page_prot via vm_set_page_prot(). Bits
to be preserved are determined with _PAGE_CHG_MASK symbol that doesn't
cover _PAGE_PAT. As a consequence, WB caching is requested instead of WC
when running under Xen (also, WP is silently changed to WT, and UC
downgraded to UC_MINUS). When running on bare metal, WC is not affected,
but WP and WT extra modes are unintentionally replaced with WC and UC,
respectively.
WP and WT modes, encoded with _PAGE_PAT bit set, were introduced by commit
281d4078bec3 ("x86: Make page cache mode a real type"). Care was taken
to extend _PAGE_CACHE_MASK symbol with that additional bit, but that
symbol has never been used for identification of bits preserved when
applying page protection flags. Support for all cache modes under Xen,
including the problematic WC mode, was then introduced by commit
47591df50512 ("xen: Support Xen pv-domains using PAT").
The issue needs to be fixed by including _PAGE_PAT bit into a bitmask used
by pgprot_modify() for selecting bits to be preserved. We can do that
either internally to pgprot_modify() (as initially proposed), or by making
_PAGE_PAT a part of _PAGE_CHG_MASK. If we go for the latter then, since
_PAGE_PAT is the same as _PAGE_PSE, we need to note that _HPAGE_CHG_MASK
-- a huge pmds' counterpart of _PAGE_CHG_MASK, introduced by commit
c489f1257b8c ("thp: add pmd_modify"), defined as (_PAGE_CHG_MASK |
_PAGE_PSE) -- will no longer differ from _PAGE_CHG_MASK. If such
modification of _PAGE_CHG_MASK was irrelevant to its users then one might
wonder why that new _HPAGE_CHG_MASK symbol was introduced instead of
reusing the existing one with that otherwise irrelevant bit (_PAGE_PSE in
that case) added.
Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
and its users, and go for it. Also, add _PAGE_PAT_LARGE to
_HPAGE_CHG_MASK for symmetry. For better clarity, split out common bits
from both symbols to another one and use it together with specific bits
when defining the masks.
v3: Separate out common bits of _PAGE_CHG_MASK and _HPAGE_CHG_MASK into
_COMMON_PAGE_CHG_MASK (Rick),
- fix hard to parse wording of 'what' part of commit description (on
Dave's request).
v2: Keep pgprot_modify() untouched, make _PAGE_PAT part of _PAGE_CHG_MASK
instead (Borislav),
- also add _PAGE_PAT_LARGE to _HPAGE_CHG_MASK (Juergen).
[1] https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/0f0754413f14
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7648
Fixes: 281d4078bec3 ("x86: Make page cache mode a real type")
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: stable@vger.kernel.org # v3.19+
---
arch/x86/include/asm/pgtable_types.h | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index 447d4bee25c48..97533e6b1c61b 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -125,11 +125,12 @@
* instance, and is *not* included in this mask since
* pte_modify() does modify it.
*/
-#define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \
- _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \
- _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC | \
- _PAGE_UFFD_WP)
-#define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
+#define _COMMON_PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \
+ _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY |\
+ _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC | \
+ _PAGE_UFFD_WP)
+#define _PAGE_CHG_MASK (_COMMON_PAGE_CHG_MASK | _PAGE_PAT)
+#define _HPAGE_CHG_MASK (_COMMON_PAGE_CHG_MASK | _PAGE_PSE | _PAGE_PAT_LARGE)
/*
* The cache modes defined here are used to translate between pure SW usage
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
@ 2023-07-10 8:05 ` Borislav Petkov
2023-07-17 9:42 ` Janusz Krzysztofik
2023-07-10 11:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for x86/mm: Fix PAT bit missing from page protection modify mask (rev4) Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Borislav Petkov @ 2023-07-10 8:05 UTC (permalink / raw)
To: Dave Hansen
Cc: Juergen Gross, intel-gfx, x86, Marek Marczykowski-Górecki,
linux-kernel, Ingo Molnar, Thomas Gleixner, Edgecombe, Rick P
On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote:
> Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
> and its users, and go for it. Also, add _PAGE_PAT_LARGE to
That's my only worry.
I'd suggest we queue this but not send it to Linus now. Instead, let it
cook in linux-next for the whole 6.5 release cycle so that it can get at
least *some* testing.
Because if we send it now and something else obscure breaks in a weird
way in his tree, then we'll have to scramble to fix that too and it'll
be one helluva mess.
Dave?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
2023-07-10 8:05 ` Borislav Petkov
@ 2023-07-10 11:58 ` Patchwork
2023-07-10 12:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-07-10 11:58 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
== Series Details ==
Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
URL : https://patchwork.freedesktop.org/series/116883/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
2023-07-10 8:05 ` Borislav Petkov
2023-07-10 11:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for x86/mm: Fix PAT bit missing from page protection modify mask (rev4) Patchwork
@ 2023-07-10 12:12 ` Patchwork
2023-07-10 14:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-10 17:58 ` [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Edgecombe, Rick P
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-07-10 12:12 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9387 bytes --]
== Series Details ==
Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
URL : https://patchwork.freedesktop.org/series/116883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13363 -> Patchwork_116883v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/index.html
Participating hosts (41 -> 40)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_116883v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-1: [PASS][1] -> [ABORT][2] ([i915#5122])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-jsl-1/igt@gem_exec_suspend@basic-s0@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-jsl-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-mtlp-8: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [PASS][4] -> [FAIL][5] ([i915#7940])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
- fi-kbl-x1275: [PASS][6] -> [FAIL][7] ([i915#8843])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: NOTRUN -> [DMESG-FAIL][9] ([i915#7059])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
- bat-mtlp-6: [PASS][10] -> [DMESG-FAIL][11] ([i915#7059])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: NOTRUN -> [DMESG-FAIL][12] ([i915#8497])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-8: NOTRUN -> [DMESG-WARN][13] ([i915#6367])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][14] ([i915#6645])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
- bat-jsl-1: [PASS][15] -> [FAIL][16] ([fdo#103375])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-jsl-1/igt@i915_suspend@basic-s3-without-i915.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-jsl-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#7828])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-mtlp-8: NOTRUN -> [SKIP][18] ([i915#7828])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][19] ([i915#1845] / [i915#5354]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][20] ([i915#1845])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][21] ([i915#3708]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html
* igt@prime_vgem@basic-gtt:
- bat-mtlp-8: NOTRUN -> [SKIP][22] ([i915#3708] / [i915#4077]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@prime_vgem@basic-gtt.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-1115g4: [FAIL][23] ([i915#7940]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-tgl-1115g4/igt@i915_pm_rpm@basic-pci-d3-state.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-tgl-1115g4/igt@i915_pm_rpm@basic-pci-d3-state.html
- fi-skl-guc: [FAIL][25] -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
- bat-mtlp-8: [ABORT][27] ([i915#7077] / [i915#7977] / [i915#8668]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-skl-guc: [FAIL][29] ([i915#7940]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][31] ([i915#4983] / [i915#7913]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-rpls-2/igt@i915_selftest@live@requests.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/bat-rpls-2/igt@i915_selftest@live@requests.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-8809g: [FAIL][33] ([i915#7364]) -> [FAIL][34] ([i915#7940])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
- fi-kbl-guc: [FAIL][35] ([i915#7364]) -> [FAIL][36] ([i915#8843])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843
Build changes
-------------
* Linux: CI_DRM_13363 -> Patchwork_116883v4
CI-20190529: 20190529
CI_DRM_13363: 9342b6645b02230f19f5abb923f3e01fca9e8bbd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7377: d1574543ba4bb322597345530053475c07be0eb9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116883v4: 9342b6645b02230f19f5abb923f3e01fca9e8bbd @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
365d7d431879 x86/mm: Fix PAT bit missing from page protection modify mask
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/index.html
[-- Attachment #2: Type: text/html, Size: 11146 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
` (2 preceding siblings ...)
2023-07-10 12:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-07-10 14:32 ` Patchwork
2023-07-10 17:58 ` [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Edgecombe, Rick P
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-07-10 14:32 UTC (permalink / raw)
To: Janusz Krzysztofik; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 42416 bytes --]
== Series Details ==
Series: x86/mm: Fix PAT bit missing from page protection modify mask (rev4)
URL : https://patchwork.freedesktop.org/series/116883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13363_full -> Patchwork_116883v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_116883v4_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_116883v4_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_116883v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-snb: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-snb2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb7/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-glk: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-glk7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-glk7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
New tests
---------
New tests have been introduced between CI_DRM_13363_full and Patchwork_116883v4_full:
### New Piglit tests (1) ###
* igt@i915_pm_rpm@basic-rte:
- Statuses : 1 fail(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_116883v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@virtual-busy-all:
- shard-mtlp: NOTRUN -> [SKIP][5] ([i915#8414])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@drm_fdinfo@virtual-busy-all.html
* igt@feature_discovery@psr2:
- shard-tglu: NOTRUN -> [SKIP][6] ([i915#658])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@feature_discovery@psr2.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-tglu: [PASS][7] -> [ABORT][8] ([i915#8211] / [i915#8234])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-7/igt@gem_barrier_race@remote-request@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_persistence@hang:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb6/igt@gem_ctx_persistence@hang.html
* igt@gem_eio@hibernate:
- shard-dg2: [PASS][10] -> [ABORT][11] ([i915#7975] / [i915#8213])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-11/igt@gem_eio@hibernate.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-7/igt@gem_eio@hibernate.html
* igt@gem_exec_balancer@full-pulse:
- shard-dg2: [PASS][12] -> [FAIL][13] ([i915#6032])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-2/igt@gem_exec_balancer@full-pulse.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-7/igt@gem_exec_balancer@full-pulse.html
* igt@gem_exec_fair@basic-deadline:
- shard-rkl: [PASS][14] -> [FAIL][15] ([i915#2846])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-rkl: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_params@secure-non-root:
- shard-tglu: NOTRUN -> [SKIP][18] ([fdo#112283])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@gem_exec_params@secure-non-root.html
* igt@gem_exec_reloc@basic-range:
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#3281])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@gem_exec_reloc@basic-range.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-mtlp: [PASS][20] -> [FAIL][21] ([i915#6363])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-1/igt@gem_exec_whisper@basic-forked-all.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-3/igt@gem_exec_whisper@basic-forked-all.html
* igt@gem_lmem_evict@dontneed-evict-race:
- shard-tglu: NOTRUN -> [SKIP][22] ([i915#4613] / [i915#7582])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@gem_lmem_evict@dontneed-evict-race.html
* igt@gem_lmem_swapping@verify-random:
- shard-tglu: NOTRUN -> [SKIP][23] ([i915#4613])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap_gtt@fault-concurrent:
- shard-mtlp: NOTRUN -> [SKIP][24] ([i915#4077]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@gem_mmap_gtt@fault-concurrent.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [PASS][25] -> [ABORT][26] ([i915#5161])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-x.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb1/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-snb: [PASS][27] -> [FAIL][28] ([i915#4998] / [i915#8295])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-snb2/igt@gem_ppgtt@blt-vs-render-ctx0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html
* igt@gen3_mixed_blits:
- shard-tglu: NOTRUN -> [SKIP][29] ([fdo#109289])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@gen3_mixed_blits.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-snb: NOTRUN -> [SKIP][30] ([fdo#109271]) +62 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb6/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][31] -> [ABORT][32] ([i915#5566])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-glk9/igt@gen9_exec_parse@allowed-single.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-glk6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_module_load@resize-bar:
- shard-tglu: NOTRUN -> [SKIP][33] ([i915#6412])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@i915_module_load@resize-bar.html
* igt@i915_pm_backlight@fade-with-suspend:
- shard-mtlp: NOTRUN -> [INCOMPLETE][34] ([fdo#103375])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-2/igt@i915_pm_backlight@fade-with-suspend.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu: [PASS][35] -> [FAIL][36] ([i915#3989] / [i915#454])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-9/igt@i915_pm_dc@dc6-dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-5/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#1937])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-11/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-rkl: [PASS][38] -> [SKIP][39] ([i915#1937])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@cursor:
- shard-tglu: NOTRUN -> [FAIL][40] ([i915#7940])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@i915_pm_rpm@cursor.html
* igt@i915_pm_rpm@cursor-dpms:
- shard-tglu: [PASS][41] -> [FAIL][42] ([i915#7940]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-4/igt@i915_pm_rpm@cursor-dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-6/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-mtlp: [PASS][43] -> [FAIL][44] ([fdo#103375] / [i915#6121])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-6/igt@i915_pm_rpm@system-suspend-execbuf.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-2/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_selftest@live@sanitycheck:
- shard-snb: NOTRUN -> [ABORT][45] ([i915#4528])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb6/igt@i915_selftest@live@sanitycheck.html
* igt@i915_selftest@live@workarounds:
- shard-mtlp: [PASS][46] -> [DMESG-FAIL][47] ([i915#6763])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-1/igt@i915_selftest@live@workarounds.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-3/igt@i915_selftest@live@workarounds.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-mtlp: [PASS][48] -> [FAIL][49] ([i915#2521])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-3/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-1/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [PASS][50] -> [FAIL][51] ([i915#5138])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-1/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-tglu: NOTRUN -> [SKIP][52] ([fdo#111615] / [i915#5286])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-mtlp: NOTRUN -> [SKIP][53] ([fdo#111615])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][54] ([fdo#111614]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglu: NOTRUN -> [SKIP][55] ([fdo#111615]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#3886])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl7/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][57] ([i915#6095]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][58] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_ccs@pipe-b-bad-pixel-format-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_mtl_rc_ccs_cc:
- shard-tglu: NOTRUN -> [SKIP][59] ([i915#5354] / [i915#6095]) +7 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_mtl_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][60] ([i915#3689] / [i915#5354] / [i915#6095]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_cdclk@plane-scaling@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#4087]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-11/igt@kms_cdclk@plane-scaling@pipe-b-dp-4.html
* igt@kms_content_protection@lic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [TIMEOUT][62] ([i915#7173])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl7/igt@kms_content_protection@lic@pipe-a-dp-1.html
* igt@kms_content_protection@srm@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][63] ([i915#7173]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-11/igt@kms_content_protection@srm@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-tglu: NOTRUN -> [SKIP][64] ([i915#3555])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_cursor_crc@cursor-onscreen-32x10.html
* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#8814])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_cursor_crc@cursor-onscreen-32x32.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1:
- shard-snb: NOTRUN -> [DMESG-WARN][66] ([i915#8841]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb4/igt@kms_cursor_crc@cursor-suspend@pipe-b-vga-1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1:
- shard-apl: [PASS][67] -> [ABORT][68] ([i915#180])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-apl4/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-tglu: NOTRUN -> [SKIP][69] ([fdo#109274])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][70] -> [FAIL][71] ([i915#2346])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- shard-dg2: NOTRUN -> [SKIP][72] ([i915#3555])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-tglu: NOTRUN -> [SKIP][73] ([fdo#109274] / [i915#3637])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@2x-plain-flip-ts-check@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#2122])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check@ac-hdmi-a1-hdmi-a2.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-glk4/igt@kms_flip@2x-plain-flip-ts-check@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][76] ([i915#2672])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][77] ([i915#2587] / [i915#2672])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-dg2: [PASS][78] -> [FAIL][79] ([i915#6880]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
- shard-tglu: NOTRUN -> [SKIP][80] ([fdo#109280]) +6 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#1825]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
- shard-tglu: NOTRUN -> [SKIP][82] ([fdo#110189]) +7 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-dg2: NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8228])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-6/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_cursor@viewport@pipe-b-edp-1-size-256:
- shard-mtlp: [PASS][84] -> [DMESG-WARN][85] ([i915#1982])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-8/igt@kms_plane_cursor@viewport@pipe-b-edp-1-size-256.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-6/igt@kms_plane_cursor@viewport@pipe-b-edp-1-size-256.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][86] ([i915#5176]) +5 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][87] ([i915#5176]) +7 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-11/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-dp-4.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][88] ([i915#5176]) +3 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][89] ([i915#5235]) +11 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-8/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-d-hdmi-a-3.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][90] ([i915#5235]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#5235]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglu: NOTRUN -> [SKIP][92] ([fdo#111068] / [i915#658])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_su@page_flip-p010:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl7/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [FAIL][94] ([i915#5465]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb1/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-dg2: [PASS][95] -> [FAIL][96] ([fdo#103375] / [i915#6121])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglu: NOTRUN -> [SKIP][97] ([i915#2437])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@kms_writeback@writeback-fb-id.html
* igt@perf_pmu@busy-double-start@ccs0:
- shard-mtlp: [PASS][98] -> [FAIL][99] ([i915#4349])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-7/igt@perf_pmu@busy-double-start@ccs0.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@perf_pmu@busy-double-start@ccs0.html
* igt@v3d/v3d_get_param@base-params:
- shard-tglu: NOTRUN -> [SKIP][100] ([fdo#109315] / [i915#2575]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@v3d/v3d_get_param@base-params.html
* igt@v3d/v3d_submit_csd@bad-perfmon:
- shard-mtlp: NOTRUN -> [SKIP][101] ([i915#2575])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@v3d/v3d_submit_csd@bad-perfmon.html
* igt@v3d/v3d_submit_csd@multi-and-single-sync:
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271]) +54 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl7/igt@v3d/v3d_submit_csd@multi-and-single-sync.html
* igt@vc4/vc4_tiling@get-bad-modifier:
- shard-tglu: NOTRUN -> [SKIP][103] ([i915#2575])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@vc4/vc4_tiling@get-bad-modifier.html
#### Possible fixes ####
* igt@gem_create@hog-create@smem0:
- shard-dg2: [FAIL][104] ([i915#5892] / [i915#8758]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-10/igt@gem_create@hog-create@smem0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-8/igt@gem_create@hog-create@smem0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [FAIL][106] ([i915#6268]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@hibernate:
- shard-tglu: [ABORT][108] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-10/igt@gem_eio@hibernate.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-2/igt@gem_eio@hibernate.html
* igt@gem_eio@reset-stress:
- shard-dg2: [FAIL][110] ([i915#5784]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-5/igt@gem_eio@reset-stress.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-5/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][112] ([i915#2842]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [FAIL][114] ([i915#2842]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-1/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][116] ([i915#5493]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-8/igt@gem_lmem_swapping@smem-oom@lmem0.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-dg2: [DMESG-WARN][118] ([i915#7061]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-5/igt@i915_module_load@reload-with-fault-injection.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-5/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][120] ([i915#3591]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg1-13/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-tglu: [FAIL][122] ([i915#7940]) -> [PASS][123] +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-8/igt@i915_pm_rpm@basic-pci-d3-state.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-7/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][124] ([i915#1397]) -> [PASS][125] +4 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- {shard-dg1}: [FAIL][126] ([i915#7940]) -> [PASS][127] +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg1-15/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg1-19/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][128] ([i915#1397]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg1-17/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [FAIL][130] ([i915#5138]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-mtlp: [FAIL][132] ([i915#3743]) -> [PASS][133] +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-rkl: [FAIL][134] ([i915#3743]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [ABORT][136] ([i915#180]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank@d-edp1:
- shard-mtlp: [FAIL][138] ([i915#79]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-4/igt@kms_flip@flip-vs-expired-vblank@d-edp1.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-2/igt@kms_flip@flip-vs-expired-vblank@d-edp1.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-dg2: [FAIL][140] ([fdo#103375] / [i915#6121]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-5/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-6/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-mtlp: [ABORT][142] ([i915#8131]) -> [TIMEOUT][143] ([i915#8628])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-7/igt@gem_exec_whisper@basic-contexts-forked-all.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-4/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-tglu: [WARN][144] ([i915#2681]) -> [FAIL][145] ([i915#2681] / [i915#3591])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-tglu-7/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-tglu-4/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@kms_content_protection@content_type_change:
- shard-dg2: [SKIP][146] ([i915#7118]) -> [SKIP][147] ([i915#7118] / [i915#7162])
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-dg2-2/igt@kms_content_protection@content_type_change.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-dg2-12/igt@kms_content_protection@content_type_change.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][148] ([i915#3955]) -> [SKIP][149] ([fdo#110189] / [i915#3955]) +1 similar issue
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-7/igt@kms_fbcon_fbt@psr-suspend.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-vga1:
- shard-snb: [INCOMPLETE][150] ([i915#4839]) -> [DMESG-WARN][151] ([i915#8841])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-snb7/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-snb6/igt@kms_flip@flip-vs-suspend-interruptible@b-vga1.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][152] ([fdo#109285]) -> [SKIP][153] ([fdo#109285] / [i915#4098])
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][154] ([i915#4070] / [i915#4816]) -> [SKIP][155] ([i915#4816])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@sysfs_preempt_timeout@timeout@vecs0:
- shard-mtlp: [TIMEOUT][156] ([i915#7947]) -> [ABORT][157] ([i915#8521])
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/shard-mtlp-6/igt@sysfs_preempt_timeout@timeout@vecs0.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/shard-mtlp-3/igt@sysfs_preempt_timeout@timeout@vecs0.html
### Piglit changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte (NEW):
- pig-kbl-iris: NOTRUN -> [FAIL][158] ([i915#5603])
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/pig-kbl-iris/igt@i915_pm_rpm@basic-rte.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5603]: https://gitlab.freedesktop.org/drm/intel/issues/5603
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7061]: https://gitlab.freedesktop.org/drm/intel/issues/7061
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7947]: https://gitlab.freedesktop.org/drm/intel/issues/7947
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8295]: https://gitlab.freedesktop.org/drm/intel/issues/8295
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8521]: https://gitlab.freedesktop.org/drm/intel/issues/8521
[i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13363 -> Patchwork_116883v4
CI-20190529: 20190529
CI_DRM_13363: 9342b6645b02230f19f5abb923f3e01fca9e8bbd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7377: d1574543ba4bb322597345530053475c07be0eb9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_116883v4: 9342b6645b02230f19f5abb923f3e01fca9e8bbd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_116883v4/index.html
[-- Attachment #2: Type: text/html, Size: 48576 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
` (3 preceding siblings ...)
2023-07-10 14:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2023-07-10 17:58 ` Edgecombe, Rick P
2023-07-17 9:45 ` Janusz Krzysztofik
4 siblings, 1 reply; 9+ messages in thread
From: Edgecombe, Rick P @ 2023-07-10 17:58 UTC (permalink / raw)
To: janusz.krzysztofik@linux.intel.com, x86@kernel.org
Cc: Gross, Jurgen, intel-gfx@lists.freedesktop.org,
dave.hansen@linux.intel.com, Marczykowski, Marek,
linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
tglx@linutronix.de
On Mon, 2023-07-10 at 09:36 +0200, Janusz Krzysztofik wrote:
> The issue needs to be fixed by including _PAGE_PAT bit into a bitmask
> used
> by pgprot_modify() for selecting bits to be preserved. We can do
> that
> either internally to pgprot_modify() (as initially proposed), or by
> making
> _PAGE_PAT a part of _PAGE_CHG_MASK. If we go for the latter then,
> since
> _PAGE_PAT is the same as _PAGE_PSE, we need to note that
> _HPAGE_CHG_MASK
> -- a huge pmds' counterpart of _PAGE_CHG_MASK, introduced by commit
> c489f1257b8c ("thp: add pmd_modify"), defined as (_PAGE_CHG_MASK |
> _PAGE_PSE) -- will no longer differ from _PAGE_CHG_MASK. If such
> modification of _PAGE_CHG_MASK was irrelevant to its users then one
> might
> wonder why that new _HPAGE_CHG_MASK symbol was introduced instead of
> reusing the existing one with that otherwise irrelevant bit
> (_PAGE_PSE in
> that case) added.
>
> Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break
> pte_modify()
> and its users, and go for it. Also, add _PAGE_PAT_LARGE to
> _HPAGE_CHG_MASK for symmetry. For better clarity, split out common
> bits
> from both symbols to another one and use it together with specific
> bits
> when defining the masks.
I think this whole entanglement is a bit confusing, but not
functionally broken.
The problem is kind of that the existing code assumes that all vma-
>vm_page_prot relevant prot bit positions are identical between PTE and
PMDs. The bug is that _PAGE_PAT is not treated as relevant, but it
actually is. So fixing it breaks the assumption.
Not trying to suggest we shouldn't do the simple fix here, but I wonder
if it is worth clearing it up further?
I think at least we should include a comment around _PAGE_CHG_MASK or
_PAGE_PAT as to why it is assumed that this will not cause problems.
This way, someone in the future can see the error in the reasoning if
something changes. Would something like this be useful and correct
reasoning?
/*
* Bit 7 has different meanings for PTEs and PMDs. On PTEs it is the
* PAT bit, and on PMDs it is the PSE bit. This creates some confusing
* entanglement in code that operates page table bits that end up in
* both PTEs and PMDs.
*
* vma->vm_page_prot is used for constructing both PTE's and huge
* page PMDs. This member is set via vm_pgprot_modify() which, despite
* vma->vm_page_prot being used to set huge pages as well, only filters
* bits with _PAGE_CHG_MASK (actually in pgprot_modify()). This means
* by having _PAGE_PAT in _PAGE_CHG_MASK, _PAGE_PSE will also be
* preserved.
*
* This should be harmless because vma->vm_page_prot is only applied to
* leaf page table entries. In the case of _PAGE_PAT in
* vma->vm_page_prot being inadvertently applied to a huge page, this
* is fine because _PAGE_PSE will already be being set on a huge page.
* It is expected that code should not try to add _PAGE_PSE to
* vma->vm_page_prot, so there shouldn't be the case of inadvertently
* setting _PAGE_PAT in a PTE. So the saving grace is that PSE is
* *always* set on PMDs that add bits derived from vma->vm_page_prot.
*/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
2023-07-10 8:05 ` Borislav Petkov
@ 2023-07-17 9:42 ` Janusz Krzysztofik
0 siblings, 0 replies; 9+ messages in thread
From: Janusz Krzysztofik @ 2023-07-17 9:42 UTC (permalink / raw)
To: Dave Hansen, Borislav Petkov
Cc: Juergen Gross, intel-gfx, x86, Marek Marczykowski-Górecki,
linux-kernel, Ingo Molnar, Thomas Gleixner, Edgecombe, Rick P
Hi Borislav,
On Monday, 10 July 2023 10:05:19 CEST Borislav Petkov wrote:
> On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote:
> > Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
> > and its users, and go for it. Also, add _PAGE_PAT_LARGE to
>
> That's my only worry.
Let me remind you that v1 was free of concerns on potential breakage of
pte_modify(). I can update its commit description as Dave requested and
resubmit if you confirm that it will be reconsidered as a potential solution.
Thanks,
Janusz
>
> I'd suggest we queue this but not send it to Linus now. Instead, let it
> cook in linux-next for the whole 6.5 release cycle so that it can get at
> least *some* testing.
>
> Because if we send it now and something else obscure breaks in a weird
> way in his tree, then we'll have to scramble to fix that too and it'll
> be one helluva mess.
>
> Dave?
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
2023-07-10 17:58 ` [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Edgecombe, Rick P
@ 2023-07-17 9:45 ` Janusz Krzysztofik
2023-07-17 21:25 ` Edgecombe, Rick P
0 siblings, 1 reply; 9+ messages in thread
From: Janusz Krzysztofik @ 2023-07-17 9:45 UTC (permalink / raw)
To: x86@kernel.org, Edgecombe, Rick P
Cc: Gross, Jurgen, intel-gfx@lists.freedesktop.org,
dave.hansen@linux.intel.com, Marczykowski, Marek,
linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
tglx@linutronix.de
Hi Rick,
On Monday, 10 July 2023 19:58:07 CEST Edgecombe, Rick P wrote:
> On Mon, 2023-07-10 at 09:36 +0200, Janusz Krzysztofik wrote:
> > The issue needs to be fixed by including _PAGE_PAT bit into a bitmask
> > used
> > by pgprot_modify() for selecting bits to be preserved. We can do
> > that
> > either internally to pgprot_modify() (as initially proposed), or by
> > making
> > _PAGE_PAT a part of _PAGE_CHG_MASK. If we go for the latter then,
> > since
> > _PAGE_PAT is the same as _PAGE_PSE, we need to note that
> > _HPAGE_CHG_MASK
> > -- a huge pmds' counterpart of _PAGE_CHG_MASK, introduced by commit
> > c489f1257b8c ("thp: add pmd_modify"), defined as (_PAGE_CHG_MASK |
> > _PAGE_PSE) -- will no longer differ from _PAGE_CHG_MASK. If such
> > modification of _PAGE_CHG_MASK was irrelevant to its users then one
> > might
> > wonder why that new _HPAGE_CHG_MASK symbol was introduced instead of
> > reusing the existing one with that otherwise irrelevant bit
> > (_PAGE_PSE in
> > that case) added.
> >
> > Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break
> > pte_modify()
> > and its users, and go for it. Also, add _PAGE_PAT_LARGE to
> > _HPAGE_CHG_MASK for symmetry. For better clarity, split out common
> > bits
> > from both symbols to another one and use it together with specific
> > bits
> > when defining the masks.
>
> I think this whole entanglement is a bit confusing, but not
> functionally broken.
>
> The problem is kind of that the existing code assumes that all vma-
> >vm_page_prot relevant prot bit positions are identical between PTE and
> PMDs. The bug is that _PAGE_PAT is not treated as relevant, but it
> actually is. So fixing it breaks the assumption.
>
> Not trying to suggest we shouldn't do the simple fix here, but I wonder
> if it is worth clearing it up further?
>
> I think at least we should include a comment around _PAGE_CHG_MASK or
> _PAGE_PAT as to why it is assumed that this will not cause problems.
> This way, someone in the future can see the error in the reasoning if
> something changes. Would something like this be useful and correct
> reasoning?
>
> /*
> * Bit 7 has different meanings for PTEs and PMDs. On PTEs it is the
> * PAT bit, and on PMDs it is the PSE bit. This creates some confusing
> * entanglement in code that operates page table bits that end up in
> * both PTEs and PMDs.
> *
> * vma->vm_page_prot is used for constructing both PTE's and huge
> * page PMDs. This member is set via vm_pgprot_modify() which, despite
> * vma->vm_page_prot being used to set huge pages as well, only filters
> * bits with _PAGE_CHG_MASK (actually in pgprot_modify()). This means
> * by having _PAGE_PAT in _PAGE_CHG_MASK, _PAGE_PSE will also be
> * preserved.
AFAICU, your concern is different than mine was. I was wondering if by adding
_PAGE_PAT to _PAGE_CHG_MASK we didn't break PTEs in pte_modify(), while you
seem to be rather thinking of potential breakage of PMDs in pgprot_modify().
> *
> * This should be harmless because vma->vm_page_prot is only applied to
> * leaf page table entries. In the case of _PAGE_PAT in
> * vma->vm_page_prot being inadvertently applied to a huge page, this
> * is fine because _PAGE_PSE will already be being set on a huge page.
> * It is expected that code should not try to add _PAGE_PSE to
> * vma->vm_page_prot, so there shouldn't be the case of inadvertently
> * setting _PAGE_PAT in a PTE. So the saving grace is that PSE is
> * *always* set on PMDs that add bits derived from vma->vm_page_prot.
> */
>
I could add your comment and resubmit, but my experience from communication
with audience of this patch tells me that silence means rather no acceptance.
Thanks,
Janusz
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask
2023-07-17 9:45 ` Janusz Krzysztofik
@ 2023-07-17 21:25 ` Edgecombe, Rick P
0 siblings, 0 replies; 9+ messages in thread
From: Edgecombe, Rick P @ 2023-07-17 21:25 UTC (permalink / raw)
To: janusz.krzysztofik@linux.intel.com, x86@kernel.org
Cc: Gross, Jurgen, intel-gfx@lists.freedesktop.org,
dave.hansen@linux.intel.com, Marczykowski, Marek,
linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de,
tglx@linutronix.de
On Mon, 2023-07-17 at 11:45 +0200, Janusz Krzysztofik wrote:
> I could add your comment and resubmit, but my experience from
> communication
> with audience of this patch tells me that silence means rather no
> acceptance.
I don't think adding a comment to explain tricky hidden details would
typically be controversial. I'd say to comment both if there are more.
But I'll leave you to it.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-07-17 21:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 7:36 [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Janusz Krzysztofik
2023-07-10 8:05 ` Borislav Petkov
2023-07-17 9:42 ` Janusz Krzysztofik
2023-07-10 11:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for x86/mm: Fix PAT bit missing from page protection modify mask (rev4) Patchwork
2023-07-10 12:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-10 14:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-07-10 17:58 ` [Intel-gfx] [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask Edgecombe, Rick P
2023-07-17 9:45 ` Janusz Krzysztofik
2023-07-17 21:25 ` Edgecombe, Rick P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox