From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Free the fence after a fence-chain lookup failure
Date: Thu, 6 Aug 2020 20:29:14 +0300 [thread overview]
Message-ID: <3814b8d6-6b4e-7d8a-7087-df934d9ab005@intel.com> (raw)
In-Reply-To: <20200806161056.17593-1-chris@chris-wilson.co.uk>
On 06/08/2020 19:10, Chris Wilson wrote:
> If dma_fence_chain_find_seqno() reports an error, it does so in its
> preamable before it disposes of the input fence. On handling the
> error, we need to drop the reference to the fence.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2292
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Oops...
Fixes: dc61199c09b1 ("drm/i915: add syncobj timeline support")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 9ce114d67288..24a1486d2dc5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -2289,6 +2289,7 @@ add_timeline_fence_array(struct i915_execbuffer *eb,
>
> if (err && !(user_fence.flags & I915_EXEC_FENCE_SIGNAL)) {
> DRM_DEBUG("Syncobj handle missing requested point %llu\n", point);
> + dma_fence_put(fence);
> drm_syncobj_put(syncobj);
> return err;
> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-06 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 16:10 [Intel-gfx] [PATCH] drm/i915/gem: Free the fence after a fence-chain lookup failure Chris Wilson
2020-08-06 17:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-06 17:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-06 17:29 ` Lionel Landwerlin [this message]
2020-08-07 1:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3814b8d6-6b4e-7d8a-7087-df934d9ab005@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox