Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities
@ 2020-10-09  8:57 Aaron Ma
  2020-10-09  8:57 ` [Intel-gfx] [PATCH 2/2] drm/i915: Force DPCD backlight mode for BOE 2270 panel Aaron Ma
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Aaron Ma @ 2020-10-09  8:57 UTC (permalink / raw)
  To: linux-kernel, dri-devel, intel-gfx, aaron.ma, mapengyu, daniel,
	airlied, tzimmermann, mripard, maarten.lankhorst, rodrigo.vivi,
	joonas.lahtinen, jani.nikula, lyude, ville.syrjala

BOE panel with ID 2270 claims both PWM_PIN_CAP and AUX_SET_CAP backlight
control bits, but default chip backlight failed to control brightness.

Check AUX_SET_CAP and proceed to check quirks or VBT backlight type.
DPCD can control the brightness of this pannel.

Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index acbd7eb66cbe..308b14159b7c 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -334,8 +334,7 @@ intel_dp_aux_display_control_capable(struct intel_connector *connector)
 	 * the panel can support backlight control over the aux channel
 	 */
 	if (intel_dp->edp_dpcd[1] & DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP &&
-	    (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP) &&
-	    !(intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP)) {
+	    (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP)) {
 		drm_dbg_kms(&i915->drm, "AUX Backlight Control Supported!\n");
 		return true;
 	}
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-12 23:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-09  8:57 [Intel-gfx] [PATCH 1/2] drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities Aaron Ma
2020-10-09  8:57 ` [Intel-gfx] [PATCH 2/2] drm/i915: Force DPCD backlight mode for BOE 2270 panel Aaron Ma
2020-10-09 10:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities Patchwork
2020-10-09 12:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-10-09 17:26 ` [Intel-gfx] (Cc: drm-misc/intel maintainers) Re: [PATCH 1/2] " Lyude Paul
2020-10-12 23:39 ` [Intel-gfx] " Lyude Paul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox