Re: [PATCH 1/2] drm/i915/selftests: Fix engine reset count storage for multi-tile

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 07/12/2023 11:26, Andi Shyti wrote:
> Hi Tvrtko,
> 
>> Engine->id namespace is per-tile so struct igt_live_test->reset_engine[]
>> needs to be two-dimensional so engine reset counts from all tiles can be
>> stored with no aliasing. With aliasing, if we had a real multi-tile
>> platform, the reset counts would be incorrect for same engine instance on
>> different tiles.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Fixes: 0c29efa23f5c ("drm/i915/selftests: Consider multi-gt instead of to_gt()")
>> Reported-by: Alan Previn Teres Alexis <alan.previn.teres.alexis@intel.com>
>> Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> 
> sorry for being late here... the patch makes sense to me and the
> CI failures don't look related.
> 
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks pushed!

There is more work to be done with the fact i915_reset_engine_count has 
it's own aliasing when used like this, but I opted to leave that for 
some other time.

Regards,

Tvrtko