* [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
@ 2023-05-22 12:42 Nirmoy Das
2023-05-22 14:47 ` Rodrigo Vivi
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Nirmoy Das @ 2023-05-22 12:42 UTC (permalink / raw)
To: intel-gfx; +Cc: andi.shyti, chris.p.wilson, andrzej.hajda, Nirmoy Das
i915_active_fini() finalizes the debug object, which can occur before
the active retires and deactivates the debug object. Wait for one
final time before calling i915_active_fini();
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/i915_vma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 20a44788999e..bad698bece27 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt,
if (vm_ddestroy)
i915_vm_resv_put(vma->vm);
+ /* Wait for async active retire */
+ i915_active_wait(&vma->active);
i915_active_fini(&vma->active);
GEM_WARN_ON(vma->resource);
i915_vma_free(vma);
--
2.39.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
@ 2023-05-22 14:47 ` Rodrigo Vivi
2023-05-22 14:56 ` Andi Shyti
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Rodrigo Vivi @ 2023-05-22 14:47 UTC (permalink / raw)
To: Nirmoy Das; +Cc: chris.p.wilson, intel-gfx, andi.shyti, andrzej.hajda
On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote:
> i915_active_fini() finalizes the debug object, which can occur before
> the active retires and deactivates the debug object. Wait for one
> final time before calling i915_active_fini();
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index 20a44788999e..bad698bece27 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt,
> if (vm_ddestroy)
> i915_vm_resv_put(vma->vm);
>
> + /* Wait for async active retire */
> + i915_active_wait(&vma->active);
> i915_active_fini(&vma->active);
> GEM_WARN_ON(vma->resource);
> i915_vma_free(vma);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
2023-05-22 14:47 ` Rodrigo Vivi
@ 2023-05-22 14:56 ` Andi Shyti
2023-05-22 17:35 ` Das, Nirmoy
2023-05-22 15:23 ` Andrzej Hajda
` (4 subsequent siblings)
6 siblings, 1 reply; 9+ messages in thread
From: Andi Shyti @ 2023-05-22 14:56 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx, chris.p.wilson, andrzej.hajda
Hi Nirmoy,
On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote:
> i915_active_fini() finalizes the debug object, which can occur before
> the active retires and deactivates the debug object. Wait for one
> final time before calling i915_active_fini();
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
does this need the Fixes: tag?
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
2023-05-22 14:47 ` Rodrigo Vivi
2023-05-22 14:56 ` Andi Shyti
@ 2023-05-22 15:23 ` Andrzej Hajda
2023-05-22 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Andrzej Hajda @ 2023-05-22 15:23 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx; +Cc: andi.shyti, chris.p.wilson
On 22.05.2023 14:42, Nirmoy Das wrote:
> i915_active_fini() finalizes the debug object, which can occur before
> the active retires and deactivates the debug object. Wait for one
> final time before calling i915_active_fini();
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index 20a44788999e..bad698bece27 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt,
> if (vm_ddestroy)
> i915_vm_resv_put(vma->vm);
>
> + /* Wait for async active retire */
> + i915_active_wait(&vma->active);
> i915_active_fini(&vma->active);
> GEM_WARN_ON(vma->resource);
> i915_vma_free(vma);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 14:56 ` Andi Shyti
@ 2023-05-22 17:35 ` Das, Nirmoy
0 siblings, 0 replies; 9+ messages in thread
From: Das, Nirmoy @ 2023-05-22 17:35 UTC (permalink / raw)
To: Andi Shyti, Nirmoy Das; +Cc: intel-gfx, chris.p.wilson, andrzej.hajda
Hi Andi,
On 5/22/2023 4:56 PM, Andi Shyti wrote:
> Hi Nirmoy,
>
> On Mon, May 22, 2023 at 02:42:05PM +0200, Nirmoy Das wrote:
>> i915_active_fini() finalizes the debug object, which can occur before
>> the active retires and deactivates the debug object. Wait for one
>> final time before calling i915_active_fini();
>>
>> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
>> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> does this need the Fixes: tag?
I can't pinpoint anything with a git blame also this is masked by
https://gitlab.freedesktop.org/drm/intel/-/issues/6733.
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Nirmoy
>
> Andi
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
` (2 preceding siblings ...)
2023-05-22 15:23 ` Andrzej Hajda
@ 2023-05-22 19:27 ` Patchwork
2023-05-22 19:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-22 19:27 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Wait for active retire before i915_active_fini()
URL : https://patchwork.freedesktop.org/series/118122/
State : warning
== Summary ==
Error: dim checkpatch failed
13e1b7dd999c drm/i915: Wait for active retire before i915_active_fini()
-:10: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'References:', use 'Link:' or 'Closes:' instead
#10:
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
` (3 preceding siblings ...)
2023-05-22 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-05-22 19:41 ` Patchwork
2023-05-23 3:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-23 17:49 ` [Intel-gfx] [PATCH] " Das, Nirmoy
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-22 19:41 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6262 bytes --]
== Series Details ==
Series: drm/i915: Wait for active retire before i915_active_fini()
URL : https://patchwork.freedesktop.org/series/118122/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13174 -> Patchwork_118122v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/index.html
Participating hosts (39 -> 39)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_118122v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][6] -> [ABORT][7] ([i915#4983] / [i915#7913])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-rpls-2/igt@i915_selftest@live@requests.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][8] -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-rpls-1/igt@i915_selftest@live@reset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271]) +14 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@slpc:
- {bat-mtlp-6}: [DMESG-WARN][14] ([i915#6367]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
- {bat-mtlp-8}: [DMESG-WARN][16] ([i915#6367]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-mtlp-8/igt@i915_selftest@live@slpc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-mtlp-8/igt@i915_selftest@live@slpc.html
#### Warnings ####
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][18] ([i915#1072]) -> [ABORT][19] ([i915#8442])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13174 -> Patchwork_118122v1
CI-20190529: 20190529
CI_DRM_13174: 00e64f04fac388222f3a8407848e185b3ade4256 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7299: 3effd4be7f6c867d942532b3fe18d6c54fffbd7a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118122v1: 00e64f04fac388222f3a8407848e185b3ade4256 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
080950e01b64 drm/i915: Wait for active retire before i915_active_fini()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/index.html
[-- Attachment #2: Type: text/html, Size: 7547 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
` (4 preceding siblings ...)
2023-05-22 19:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-05-23 3:51 ` Patchwork
2023-05-23 17:49 ` [Intel-gfx] [PATCH] " Das, Nirmoy
6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-23 3:51 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 12562 bytes --]
== Series Details ==
Series: drm/i915: Wait for active retire before i915_active_fini()
URL : https://patchwork.freedesktop.org/series/118122/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13174_full -> Patchwork_118122v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_118122v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#7461] / [i915#8211])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-glk1/igt@gem_barrier_race@remote-request@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-glk4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_persistence@engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb6/igt@gem_ctx_persistence@engines-hostile-preempt.html
* igt@i915_module_load@load:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#6227])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb6/igt@i915_module_load@load.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#79])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271]) +67 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb6/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4579]) +17 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb5/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][9] ([i915#5465]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb6/igt@kms_setmode@basic@pipe-a-vga-1.html
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- {shard-dg1}: [FAIL][10] ([i915#5784]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-dg1-12/igt@gem_eio@reset-stress.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-dg1-18/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-none@bcs0:
- {shard-rkl}: [FAIL][12] ([i915#2842]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-rkl-7/igt@gem_exec_fair@basic-none@bcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-rkl-3/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- {shard-dg1}: [ABORT][16] ([i915#7975] / [i915#8213]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-dg1-15/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][18] ([i915#5493]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-dg1-13/igt@gem_lmem_swapping@smem-oom@lmem0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-dg1-12/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: [ABORT][20] ([i915#5161]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-snb2/igt@gem_mmap_gtt@fault-concurrent-x.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-x.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-rkl}: [SKIP][22] ([i915#1397]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp-stress.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- {shard-rkl}: [FAIL][24] ([i915#3743]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][26] ([i915#2346]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][28] ([i915#8011]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-rkl-7/igt@kms_cursor_legacy@forked-move@pipe-b.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-rkl-3/igt@kms_cursor_legacy@forked-move@pipe-b.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][30] ([i915#2122]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-glk4/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ac-hdmi-a1-hdmi-a2.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-glk8/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][32] ([i915#4349]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13174/shard-rkl-4/igt@perf_pmu@idle@rcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/shard-rkl-2/igt@perf_pmu@idle@rcs0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* Linux: CI_DRM_13174 -> Patchwork_118122v1
CI-20190529: 20190529
CI_DRM_13174: 00e64f04fac388222f3a8407848e185b3ade4256 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7299: 3effd4be7f6c867d942532b3fe18d6c54fffbd7a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118122v1: 00e64f04fac388222f3a8407848e185b3ade4256 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118122v1/index.html
[-- Attachment #2: Type: text/html, Size: 10701 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini()
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
` (5 preceding siblings ...)
2023-05-23 3:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-05-23 17:49 ` Das, Nirmoy
6 siblings, 0 replies; 9+ messages in thread
From: Das, Nirmoy @ 2023-05-23 17:49 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx
Cc: chris.p.wilson, andi.shyti, andrzej.hajda, Rodrigo Vivi
pushed to drm-intel-next with a minor fix (s/References:/Closes:)
On 5/22/2023 2:42 PM, Nirmoy Das wrote:
> i915_active_fini() finalizes the debug object, which can occur before
> the active retires and deactivates the debug object. Wait for one
> final time before calling i915_active_fini();
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/8311
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index 20a44788999e..bad698bece27 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -1710,6 +1710,8 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt,
> if (vm_ddestroy)
> i915_vm_resv_put(vma->vm);
>
> + /* Wait for async active retire */
> + i915_active_wait(&vma->active);
> i915_active_fini(&vma->active);
> GEM_WARN_ON(vma->resource);
> i915_vma_free(vma);
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-23 17:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-22 12:42 [Intel-gfx] [PATCH] drm/i915: Wait for active retire before i915_active_fini() Nirmoy Das
2023-05-22 14:47 ` Rodrigo Vivi
2023-05-22 14:56 ` Andi Shyti
2023-05-22 17:35 ` Das, Nirmoy
2023-05-22 15:23 ` Andrzej Hajda
2023-05-22 19:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-05-22 19:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-23 3:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-23 17:49 ` [Intel-gfx] [PATCH] " Das, Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox