Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients
Date: Mon, 1 Feb 2021 09:12:34 +0000	[thread overview]
Message-ID: <41a68d1b-3074-a33f-2c43-1f4329310d5f@linux.intel.com> (raw)
In-Reply-To: <20210201085358.3408367-1-chris@chris-wilson.co.uk>


On 01/02/2021 08:53, Chris Wilson wrote:
> Hide inactive clients by pressing 'i' (toggle in interactive mode).
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
>   tools/intel_gpu_top.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 60ff62d28..edf0dedac 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h)
>   }
>   
>   static bool class_view;
> +static bool filter_idle;
>   
>   static int
>   print_engines_header(struct engines *engines, double t,
> @@ -1689,6 +1690,9 @@ print_engines_footer(struct engines *engines, double t,
>   	pops->close_struct();
>   
>   	if (output_mode == INTERACTIVE) {
> +		if (filter_idle && !c->total_runtime)
> +			return;
> +
>   		if (lines++ < con_h)
>   			printf("\n");
>   	}
> @@ -2115,6 +2119,9 @@ static void process_stdin(unsigned int timeout_us)
>   		case 'q':
>   			stop_top = true;
>   			break;
> +		case 'i':
> +			filter_idle ^= true;
> +			break;
>   		case '1':
>   			class_view ^= true;
>   			break;
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-01  9:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31  3:11 [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients Chris Wilson
2021-02-01  8:14 ` Tvrtko Ursulin
2021-02-01  8:21   ` Chris Wilson
2021-02-01  8:36     ` Tvrtko Ursulin
2021-02-01  8:49       ` Chris Wilson
2021-02-01  8:53 ` Chris Wilson
2021-02-01  9:12   ` Tvrtko Ursulin [this message]
2021-02-01  9:31   ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
2021-02-01  9:53     ` Tvrtko Ursulin
2021-02-01  9:57       ` [Intel-gfx] [igt-dev] " Chris Wilson
2021-02-01 10:05         ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41a68d1b-3074-a33f-2c43-1f4329310d5f@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox