Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients
Date: Mon, 1 Feb 2021 08:14:45 +0000	[thread overview]
Message-ID: <577e01ed-a463-301f-8fc8-c553c0b46ba7@linux.intel.com> (raw)
In-Reply-To: <20210131031153.3399123-1-chris@chris-wilson.co.uk>


On 31/01/2021 03:11, Chris Wilson wrote:
> Keep new clients hidden until they utilise the GPU.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> ---
>   tools/intel_gpu_top.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 60ff62d28..66a8effa6 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name)
>   		c->last[i] = val[i];
>   	}
>   
> -	c->samples++;
> +	if (!c->total_runtime)
> +		return;
> +
>   	c->status = ALIVE;
> +	c->samples++;
>   }
>   
>   static void
> 

Not sure we need to do it at this level and not instead at presentation 
time. Plus, in default sort mode they would be at the end of the list, 
so behind the more active clients. Or you go into sort by id and they 
annoy you there?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-02-01  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-31  3:11 [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients Chris Wilson
2021-02-01  8:14 ` Tvrtko Ursulin [this message]
2021-02-01  8:21   ` Chris Wilson
2021-02-01  8:36     ` Tvrtko Ursulin
2021-02-01  8:49       ` Chris Wilson
2021-02-01  8:53 ` Chris Wilson
2021-02-01  9:12   ` Tvrtko Ursulin
2021-02-01  9:31   ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson
2021-02-01  9:53     ` Tvrtko Ursulin
2021-02-01  9:57       ` [Intel-gfx] [igt-dev] " Chris Wilson
2021-02-01 10:05         ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577e01ed-a463-301f-8fc8-c553c0b46ba7@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox