Re: [PATCH v4 5/5] drm/i915/dp: Compute as_sdp based on if vrr possible

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 11/20/2024 2:19 PM, Mitul Golani wrote:
> Adaptive sync sdp param computation, we can configure during
> full modeset as well when sink is having vrr support, where
> it doesn't need dependency on vrr.enable status and can also
> match vrr enable/disable fastset requirement.
>
> --v2:
>   - Separate the change from as_sdp.vtotal. [Ankit]
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index e39ae59370c0..bff9d2ec08e3 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2807,7 +2807,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
>   	const struct drm_display_mode *adjusted_mode =
>   		&crtc_state->hw.adjusted_mode;
>   
> -	if (!crtc_state->vrr.enable || !intel_dp->as_sdp_supported)
> +	if (!intel_vrr_possible(crtc_state) || !intel_dp->as_sdp_supported)

I agree with the change, but along with this we need to avoid comparing 
for as_sdp parameters for fastset case as done in rev1: 
https://patchwork.freedesktop.org/patch/607526/?series=137035&rev=1

Without this, seamless switch between VRR to CMRR (and fixed refresh 
rate case, which is currently work in progress) will not happen.

Regards,

Ankit


>   		return;
>   
>   	crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);