From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
<intel-gfx@lists.freedesktop.org>
Cc: <ville.syrjala@linux.intel.com>, <jani.nikula@intel.com>
Subject: Re: [PATCH v4 4/5] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings
Date: Thu, 28 Nov 2024 10:04:27 +0530 [thread overview]
Message-ID: <c6c50b98-81d8-47a5-beb5-d50a14d6a502@intel.com> (raw)
In-Reply-To: <20241120084948.1834306-5-mitulkumar.ajitkumar.golani@intel.com>
On 11/20/2024 2:19 PM, Mitul Golani wrote:
> Compute as_sdp.vtotal based on minimum vtotal calculated
> during vrr computation.
>
> --v2:
> - make a separate patch and update to vmin only [Ankit].
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 306c00cab57e..e39ae59370c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2823,7 +2823,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
> as_sdp->target_rr_divider = true;
> } else {
> as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
> - as_sdp->vtotal = adjusted_mode->vtotal;
> + as_sdp->vtotal = crtc_state->vrr.vmin;
This should be changed for CMRR case also.
Regards,
Ankit
> as_sdp->target_rr = 0;
> }
> }
next prev parent reply other threads:[~2024-11-28 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 8:49 [PATCH v4 0/5] Add AS_SDP to fastset Mitul Golani
2024-11-20 8:49 ` [PATCH v4 1/5] drm/i915/vrr: Add crtc_state dump for vrr.vsync params Mitul Golani
2024-11-20 12:50 ` Jani Nikula
2024-11-21 4:38 ` Golani, Mitulkumar Ajitkumar
2024-11-20 8:49 ` [PATCH v4 2/5] drm/i915/vrr: Update vrr.vsync_{start, end} computation Mitul Golani
2024-11-20 12:55 ` Nautiyal, Ankit K
2024-11-21 4:41 ` Golani, Mitulkumar Ajitkumar
2024-11-20 8:49 ` [PATCH v4 3/5] drm/i915/dp: fix the Adaptive sync Operation mode for SDP Mitul Golani
2024-11-20 8:49 ` [PATCH v4 4/5] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings Mitul Golani
2024-11-28 4:34 ` Nautiyal, Ankit K [this message]
2024-11-20 8:49 ` [PATCH v4 5/5] drm/i915/dp: Compute as_sdp based on if vrr possible Mitul Golani
2024-11-28 4:39 ` Nautiyal, Ankit K
2024-11-20 9:34 ` ✗ Fi.CI.SPARSE: warning for Add AS_SDP to fastset (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c50b98-81d8-47a5-beb5-d50a14d6a502@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox