Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Cc: kevin.ma@intel.com, xiaogang.li@intel.com
Subject: Re: [PATCH] drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1
Date: Mon, 15 Apr 2019 13:25:08 +0100	[thread overview]
Message-ID: <4444f5b7-5d51-ce8c-db89-075113a80620@linux.intel.com> (raw)
In-Reply-To: <155532874649.5734.9832544924815910468@skylake-alporthouse-com>


On 15/04/2019 12:45, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-15 12:43:07)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> WaEnableStateCacheRedirectToCS context workaround configures the L3 cache
>> to benefit 3d workloads but media has different requirements.
>>
>> Whitelist the register to allow media re-configuring it to their liking.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: kevin.ma@intel.com
>> Cc: xiaogang.li@intel.com
>> ---
>>   drivers/gpu/drm/i915/intel_workarounds.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
>> index ccaf63679435..6458d161204f 100644
>> --- a/drivers/gpu/drm/i915/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
>> @@ -1050,6 +1050,9 @@ static void icl_whitelist_build(struct i915_wa_list *w)
>>   
>>          /* WaAllowUMDToModifySamplerMode:icl */
>>          whitelist_reg(w, GEN10_SAMPLER_MODE);
>> +
>> +       /* WaEnableStateCacheRedirectToCS:icl */
>> +       whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
> 
> Have we checked this is context saved?

It is listed as such. But I haven't checked on actual hardware.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-04-15 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 11:43 [PATCH] drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1 Tvrtko Ursulin
2019-04-15 11:45 ` Chris Wilson
2019-04-15 12:25   ` Tvrtko Ursulin [this message]
2019-04-15 16:17     ` Chris Wilson
2019-04-15 12:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-15 14:24 ` ✓ Fi.CI.IGT: " Patchwork
2019-04-18 10:06 ` [PATCH v2] " Tvrtko Ursulin
2019-04-26  8:13   ` Lionel Landwerlin
2019-04-26  8:31     ` Joonas Lahtinen
2019-04-26 16:58       ` Anuj Phogat
2019-04-29  5:57         ` Tvrtko Ursulin
2019-04-29 17:16           ` Anuj Phogat
2019-04-30  1:25             ` Li, Xiaogang
2019-04-26 17:01   ` Anuj Phogat
2019-04-30  6:53   ` Joonas Lahtinen
2019-04-30  6:57     ` Tvrtko Ursulin
2019-04-18 11:28 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Whitelist GEN9_SLICE_COMMON_ECO_CHICKEN1 (rev2) Patchwork
2019-04-18 13:12 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4444f5b7-5d51-ce8c-db89-075113a80620@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=kevin.ma@intel.com \
    --cc=xiaogang.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox