From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org, daniel@ffwll.ch
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures
Date: Mon, 12 Nov 2012 16:52:06 +0000 [thread overview]
Message-ID: <453bf0$6egvnu@azsmga001.ch.intel.com> (raw)
In-Reply-To: <648e4ccc5905fd977c69a8dbab0074b05bd56596.1352737835.git.jani.nikula@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Mon, 12 Nov 2012 18:31:35 +0200, Jani Nikula <jani.nikula@intel.com> wrote:
> Any failures in intel_sdvo_init() after the intel_sdvo_setup_output() call
> left behind ghost connectors, attached (with a dangling pointer) to the
> sdvo that has been cleaned up and freed. Properly destroy any connectors
> attached to the encoder.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46381
> CC: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> This is *completely* untested, and I don't really know if the connector
> loop is okay or naïve in some way... Please review and test carefully. CC
> Chris in case this addresses his SDVO EDID failures too.
Sadly not. The issue in question, for readers at home, is that after
commit 9cd300e038d492af4990b04e127e0bd2df64b1ca
Author: Jani Nikula <jani.nikula@intel.com>
Date: Fri Oct 19 14:51:52 2012 +0300
drm/i915: Move cached EDID to intel_connector
Move the cached EDID from intel_dp and intel_lvds_connector to
intel_connector. Unify cached EDID handling for LVDS and eDP, in
preparation for adding more generic EDID caching later.
I lose the EDID on a SDVO-LVDS device (an ilk dual LVDS and SDVO-LVDS
Libretto W105).
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-11-12 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 16:31 [PATCH 1/2] drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures Jani Nikula
2012-11-12 16:31 ` [PATCH 2/2] drm/i915/sdvo: kfree the intel_sdvo_connector, not drm_connector, on destroy Jani Nikula
2012-11-12 16:48 ` Ville Syrjälä
2012-11-22 13:10 ` Daniel Vetter
2012-11-12 16:52 ` Chris Wilson [this message]
2012-11-12 19:09 ` [PATCH 1/2] drm/i915/sdvo: clean up connectors on intel_sdvo_init() failures Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='453bf0$6egvnu@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox