Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion
@ 2024-02-19 13:14 Tvrtko Ursulin
  2024-02-19 19:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Tvrtko Ursulin @ 2024-02-19 13:14 UTC (permalink / raw)
  To: Intel-gfx, dri-devel
  Cc: Tvrtko Ursulin, Dan Carpenter, Jani Nikula, Luca Coelho,
	Maxime Ripard, Jani Nikula

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Request can be NULL if no guilty request was identified so simply use
engine->i915 instead.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: d50892a9554c ("drm/i915: switch from drm_debug_printer() to device specific drm_dbg_printer()")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
index 5f8d86e25993..8d4bb95f8424 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
@@ -96,8 +96,8 @@ static void heartbeat_commit(struct i915_request *rq,
 static void show_heartbeat(const struct i915_request *rq,
 			   struct intel_engine_cs *engine)
 {
-	struct drm_printer p = drm_dbg_printer(&rq->i915->drm, DRM_UT_DRIVER,
-					       "heartbeat");
+	struct drm_printer p =
+		drm_dbg_printer(&engine->i915->drm, DRM_UT_DRIVER, "heartbeat");
 
 	if (!rq) {
 		intel_engine_dump(engine, &p,
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-02-22 17:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-19 13:14 [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion Tvrtko Ursulin
2024-02-19 19:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-02-19 20:00 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-19 20:02 ` [PATCH] " Rodrigo Vivi
2024-02-20  9:16   ` Tvrtko Ursulin
2024-02-20 10:36     ` Maxime Ripard
2024-02-20 13:45       ` Tvrtko Ursulin
2024-02-20  3:54 ` ✓ Fi.CI.IGT: success for " Patchwork
2024-02-22 17:51 ` [PATCH] " Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox