From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v5 10/13] drm/i915: try to simplify make_{un}shrinkable
Date: Wed, 29 Sep 2021 15:00:04 +0200 [thread overview]
Message-ID: <47008b56656bcc908e010570962836c7defa2250.camel@linux.intel.com> (raw)
In-Reply-To: <20210927114114.152310-10-matthew.auld@intel.com>
On Mon, 2021-09-27 at 12:41 +0100, Matthew Auld wrote:
> Drop the atomic shrink_pin stuff, and just have make_{un}shrinkable
> update the shrinker visible lists immediately. This at least
> simplifies
> the next patch, and does make the behaviour more obvious. The
> potential
> downside is that make_unshrinkable now grabs a global lock even when
> the
> object itself is no longer shrinkable(transitioning from purgeable <-
> >
> shrinkable doesn't seem to be a thing), for example in the ppGTT
> insertion paths we should now be careful not to needlessly call
> make_unshrinkable multiple times. Outside of that there is some
> fallout
> in intel_context which relies on nesting calls to shrink_pin.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Hmm. One thing that worries me a bit here: Let's say we have, for
example an LMEM context state, and TTM has it made unshrinkable. Then
the context becomes active and calls _make_unshrinkable again. And when
it retires it callse _make_shrinkable. Doesn't it end up on the
shrinker list at that point, even if still in LMEM?
/Thomas
next prev parent reply other threads:[~2021-09-29 13:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 11:41 [Intel-gfx] [PATCH v5 01/13] drm/ttm: stop calling tt_swapin in vm_access Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 02/13] drm/ttm: stop setting page->index for the ttm_tt Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 03/13] drm/ttm: move ttm_tt_{add, clear}_mapping into amdgpu Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 04/13] drm/ttm: remove TTM_PAGE_FLAG_NO_RETRY Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 05/13] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/ Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 06/13] drm/ttm: add some kernel-doc for TTM_TT_FLAG_* Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 07/13] drm/ttm: add TTM_TT_FLAG_EXTERNAL_MAPPABLE Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 08/13] drm/i915/gem: Break out some shmem backend utils Matthew Auld
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 09/13] drm/i915/ttm: add tt shmem backend Matthew Auld
2021-09-29 11:07 ` Thomas Hellström
2021-10-05 2:05 ` Zeng, Oak
2021-10-05 13:48 ` Thomas Hellström
2021-10-05 14:23 ` Zeng, Oak
2021-10-05 17:07 ` Matthew Auld
2021-10-05 18:33 ` Zeng, Oak
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 10/13] drm/i915: try to simplify make_{un}shrinkable Matthew Auld
2021-09-29 13:00 ` Thomas Hellström [this message]
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 11/13] drm/i915/ttm: make evicted shmem pages visible to the shrinker Matthew Auld
2021-09-29 11:47 ` Thomas Hellström
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 12/13] drm/i915/ttm: use cached system pages when evicting lmem Matthew Auld
2021-09-29 11:54 ` Thomas Hellström
2021-09-30 10:04 ` Michel Dänzer
2021-09-30 12:27 ` Matthew Auld
2021-09-30 12:55 ` Michel Dänzer
2021-09-27 11:41 ` [Intel-gfx] [PATCH v5 13/13] drm/i915/ttm: enable shmem tt backend Matthew Auld
2021-09-29 12:00 ` Thomas Hellström
2021-09-27 11:47 ` [Intel-gfx] [PATCH v5 01/13] drm/ttm: stop calling tt_swapin in vm_access Christian König
2021-09-27 16:14 ` Matthew Auld
2021-09-29 12:01 ` Christian König
2021-09-29 13:45 ` Matthew Auld
2021-09-27 17:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,01/13] " Patchwork
2021-09-27 17:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-09-27 18:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-27 21:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-05 2:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v5,01/13] drm/ttm: stop calling tt_swapin in vm_access (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47008b56656bcc908e010570962836c7defa2250.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox