Re: [PATCH v10 2/2] drm/i915: Adding YUV444 packed format support for skl+

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Op 24-10-18 om 19:17 schreef Matt Roper:
> On Tue, Oct 23, 2018 at 01:39:10PM +0200, Maarten Lankhorst wrote:
>>
>> Op 02-10-18 om 13:15 schreef Stanislav Lisovskiy:
>>> PLANE_CTL_FORMAT_AYUV is already supported, according to hardware
>>> specification.
>>>
>>> v2: Edited commit message, removed redundant whitespaces.
>>>
>>> v3: Fixed fallthrough logic for the format switch cases.
>>>
>>> v4: Yet again fixed fallthrough logic, to reuse code from other case
>>>     labels.
>>>
>>> v5: Started to use XYUV instead of AYUV, as we don't use alpha.
>>>
>>> v6: Removed unneeded initializer for new XYUV format.
>>>
>>> v7: Added scaling support for DRM_FORMAT_XYUV
>>>
>>> v8: Edited commit message to be more clear about skl+, renamed
>>>     PLANE_CTL_FORMAT_AYUV to PLANE_CTL_FORMAT_XYUV as this format
>>>     doesn't support per-pixel alpha. Fixed minor code issues.
>>>
>>> v9: Moved DRM format check to proper place in intel_framebuffer_init.
>>>
>>> v10: Added missing XYUV format to sprite planes for skl+.
>>>
>>> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>>> ---
>>>  drivers/gpu/drm/i915/i915_reg.h      |  2 +-
>>>  drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
>>>  drivers/gpu/drm/i915/intel_sprite.c  |  3 +++
>>>  3 files changed, 19 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>>> index 09bc8e730ee1..ac24ac4b1d51 100644
>>> --- a/drivers/gpu/drm/i915/i915_reg.h
>>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>>> @@ -6501,7 +6501,7 @@ enum {
>>>  #define   PLANE_CTL_FORMAT_XRGB_2101010		(2 << 24)
>>>  #define   PLANE_CTL_FORMAT_XRGB_8888		(4 << 24)
>>>  #define   PLANE_CTL_FORMAT_XRGB_16161616F	(6 << 24)
>>> -#define   PLANE_CTL_FORMAT_AYUV			(8 << 24)
>>> +#define   PLANE_CTL_FORMAT_XYUV			(8 << 24)
>> It's the same format as AYUV, don't add a separate definition here for it.
>> The only difference is we ignore the alpha channel.
> I think he's just renaming the format that's already been added to be
> more consistent with how we name our other PLANE_CTL_FORMAT_
> definitions.  I.e., all the rgb types use "XRGB" in the name.
>
Ah k, with your explanation it makes more sense then. :)
Yeah just zap the AYUV if there's no alpha channel.

~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx