Re: [PATCH] drm/i915/display: Fix macro HAS_ULTRAJOINER

[Karthik B S <karthik.b.s@intel.com>]

On 6/11/2025 11:00 AM, Ankit Nautiyal wrote:
> Currently, Ultrajoiner is supported only on Xe2_HPD.
> Update the HAS_ULTRAJOINER macro to reflect the same.
>
> v2: Clarify the commit message to specify platform. (Jani)
>
> Bspec: 69556
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

LGTM.

Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display_device.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 0ac5484c0043..4308822f0415 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -192,9 +192,8 @@ struct intel_display_platforms {
>   #define HAS_TRANSCODER(__display, trans)	((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \
>   						  BIT(trans)) != 0)
>   #define HAS_UNCOMPRESSED_JOINER(__display)	(DISPLAY_VER(__display) >= 13)
> -#define HAS_ULTRAJOINER(__display)	((DISPLAY_VER(__display) >= 20 || \
> -					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
> -					 HAS_DSC(__display))
> +#define HAS_ULTRAJOINER(__display)	(((__display)->platform.dgfx && \
> +					  DISPLAY_VER(__display) == 14) && HAS_DSC(__display))
>   #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
>   #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>   #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)