Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: Fix macro HAS_ULTRAJOINER
Date: Fri, 06 Jun 2025 16:33:10 +0300	[thread overview]
Message-ID: <6444da4dfedf172aef83804dc85c3828e0f8b115@intel.com> (raw)
In-Reply-To: <20250605052616.3368990-1-ankit.k.nautiyal@intel.com>

On Thu, 05 Jun 2025, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
> Not all platforms that have display >= 20 support ultrajoiner.

That implies some of them do, but the patch says none of them do.

> Fix the macro HAS_ULTRAJOINER with correct platforms.
>
> Bspec: 69556
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 0ac5484c0043..4308822f0415 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -192,9 +192,8 @@ struct intel_display_platforms {
>  #define HAS_TRANSCODER(__display, trans)	((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \
>  						  BIT(trans)) != 0)
>  #define HAS_UNCOMPRESSED_JOINER(__display)	(DISPLAY_VER(__display) >= 13)
> -#define HAS_ULTRAJOINER(__display)	((DISPLAY_VER(__display) >= 20 || \
> -					  ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \
> -					 HAS_DSC(__display))
> +#define HAS_ULTRAJOINER(__display)	(((__display)->platform.dgfx && \
> +					  DISPLAY_VER(__display) == 14) && HAS_DSC(__display))
>  #define HAS_VRR(__display)		(DISPLAY_VER(__display) >= 11)
>  #define INTEL_NUM_PIPES(__display)	(hweight8(DISPLAY_RUNTIME_INFO(__display)->pipe_mask))
>  #define OVERLAY_NEEDS_PHYSICAL(__display)	(DISPLAY_INFO(__display)->overlay_needs_physical)

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2025-06-06 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  5:26 [PATCH] drm/i915/display: Fix macro HAS_ULTRAJOINER Ankit Nautiyal
2025-06-05  6:15 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2025-06-05  6:39 ` ✓ i915.CI.BAT: success " Patchwork
2025-06-05  8:19 ` ✓ i915.CI.Full: " Patchwork
2025-06-06 13:33 ` Jani Nikula [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-11  5:30 [PATCH] " Ankit Nautiyal
2025-06-23  8:49 ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6444da4dfedf172aef83804dc85c3828e0f8b115@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox