From: Kenneth Graunke <kenneth@whitecape.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Ivybridge still has fences!
Date: Sun, 23 Oct 2011 13:45:21 -0700 [thread overview]
Message-ID: <4EA47CE1.7020102@whitecape.org> (raw)
In-Reply-To: <aefc95$1v3t51@orsmga001.jf.intel.com>
On 10/23/2011 04:23 AM, Chris Wilson wrote:
> Regardless of the outcome of Jesse's request for an if-ladder, the
> substance of the patches look sound.
>
> However, I remain unconvinced that there are 32 fence registers on IVB.
> Daniel's evidence is based upon the size of the register map (and not
> on the BSPEC explicitly stating a change to 32 ;-), but most tellingly
> the bitfields for fence-number in other registers have not been updated -
> so we can only safely allocated the first 16 anyway...
> (For instance, FBC_CTL).
> -Chris
It sure looks like it has 32 fence registers: BSpec vol1g GT Interface
Register [DevIVB] / GT Interface Register DevIVB / System Agent Config
Space lists FENCE0 through FENCE31. The simulator seems to indicate
this as well.
You're right that FBC_CTL still only has 4 bits for selecting a fence,
but notably, in the latest (WIP) version of the BSpec, it says "This
field must be programmed to 0000b." I'm not sure how it's supposed to
work now, but likely something has changed.
next prev parent reply other threads:[~2011-10-23 20:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 19:52 [PATCH 1/3] drm/i915: Ivybridge still has fences! Daniel Vetter
2011-10-09 19:52 ` [PATCH 2/3] drm/i915: add constants to size fence arrays and fields Daniel Vetter
2011-10-09 19:54 ` Daniel Vetter
2011-10-09 19:52 ` [PATCH 3/3] drm/i915: enable support for 32 fences on ivybridge Daniel Vetter
2011-10-10 17:58 ` [PATCH 1/3] drm/i915: Ivybridge still has fences! Jesse Barnes
2011-10-23 10:12 ` Daniel Vetter
2011-10-23 10:18 ` Jesse Barnes
2011-10-23 11:23 ` Chris Wilson
2011-10-23 12:09 ` Daniel Vetter
2011-10-23 12:35 ` Chris Wilson
2011-11-03 16:23 ` Keith Packard
2011-10-23 20:45 ` Kenneth Graunke [this message]
2011-10-23 22:16 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA47CE1.7020102@whitecape.org \
--to=kenneth@whitecape.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox